[Contextual Suggestions] Offline icon does not appear when suggestion is downloaded |
|||
Issue descriptionCurrently we show a offline icon when an article suggestion is downloaded, but we don't show any icon when a contextual suggestion is downloaded. It would be nice to show the offline icon for consistency.
,
Sep 11 2017
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec25514c37e94aaff1545a5080516fc1f9e925dd commit ec25514c37e94aaff1545a5080516fc1f9e925dd Author: galinap <galinap@google.com> Date: Wed Sep 13 11:39:41 2017 [Contextual Suggestions] Add offline icon when suggestion is downloaded This CL adds an offline icon when the user downloads a suggestion from the context menu. This is done by registering an OfflineModelObserver in the SuggestionsCarouselAdapter. Bug: 763390 Change-Id: I8cf9adf54706927b5f11628c7e330b42eb4f2e94 Reviewed-on: https://chromium-review.googlesource.com/660538 Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org> Commit-Queue: Galia Peycheva <galinap@google.com> Cr-Commit-Position: refs/heads/master@{#501594} [modify] https://crrev.com/ec25514c37e94aaff1545a5080516fc1f9e925dd/chrome/android/java/src/org/chromium/chrome/browser/suggestions/ContextualSuggestionsCardViewHolder.java [modify] https://crrev.com/ec25514c37e94aaff1545a5080516fc1f9e925dd/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java [modify] https://crrev.com/ec25514c37e94aaff1545a5080516fc1f9e925dd/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsCarousel.java [modify] https://crrev.com/ec25514c37e94aaff1545a5080516fc1f9e925dd/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsCarouselAdapter.java
,
Sep 13 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by vitaliii@chromium.org
, Sep 8 2017