New issue
Advanced search Search tips

Issue 763386 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

[css-grid] Stretching auto tracks should be done as part of the track sizing algorithm

Project Member Reported by r...@igalia.com, Sep 8 2017

Issue description


CSS WG has agreed to modify the track sizing algorithm to include a new step: https://drafts.csswg.org/css-grid/#algo-stretch

We used to do the stretch of the "auto" tracks at the end of the track sizing algorithm, however the change integrates this into the algorithm itself as the last step.

See: https://github.com/w3c/csswg-drafts/issues/1150
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb05a60c04d5754764ca5c8f35b7fa0c77fce9e3

commit bb05a60c04d5754764ca5c8f35b7fa0c77fce9e3
Author: Manuel Rego Casasnovas <rego@igalia.com>
Date: Tue Sep 12 13:25:35 2017

[css-grid] Move stretch of "auto" tracks into the track sizing algorithm

CSS WG has agreed to modify the track sizing algorithm to include
a new step: https://drafts.csswg.org/css-grid/#algo-stretch
We used to do the stretch of the "auto" tracks at the end of
the track sizing algorithm, however this change integrates it
into the algorithm itself as the last step.
See: https://github.com/w3c/csswg-drafts/issues/1150

The patch moves the method
LayoutGrid::ApplyStretchAlignmentToTracksIfNeeded() to
GridTrackSizingAlgorithm::StretchAutoTracksIfNeeded().
And then modifies the grid track sizing algorithm to execute
the new step.

This also modifies the test to check the new expected behavior.

BUG= 763386 
TEST=external/wpt/css/css-grid-1/grid-items/grid-minimum-size-grid-items-021.html

Change-Id: Ieb31e822989ae4655d0e632885215e4a032dd445
Reviewed-on: https://chromium-review.googlesource.com/657578
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Reviewed-by: Sergio Villar <svillar@igalia.com>
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Cr-Commit-Position: refs/heads/master@{#501249}
[modify] https://crrev.com/bb05a60c04d5754764ca5c8f35b7fa0c77fce9e3/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/grid-items/grid-minimum-size-grid-items-021.html
[modify] https://crrev.com/bb05a60c04d5754764ca5c8f35b7fa0c77fce9e3/third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp
[modify] https://crrev.com/bb05a60c04d5754764ca5c8f35b7fa0c77fce9e3/third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.h
[modify] https://crrev.com/bb05a60c04d5754764ca5c8f35b7fa0c77fce9e3/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
[modify] https://crrev.com/bb05a60c04d5754764ca5c8f35b7fa0c77fce9e3/third_party/WebKit/Source/core/layout/LayoutGrid.h

Comment 2 by r...@igalia.com, Sep 12 2017

Status: Fixed (was: Started)

Comment 3 by r...@igalia.com, Oct 11 2017

JFTR, this cause a regression. See  bug #773625 .

Sign in to add a comment