New issue
Advanced search Search tips

Issue 763384 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Security



Sign in to add a comment

Crash in libGLESv2_swiftshader

Project Member Reported by ClusterFuzz, Sep 8 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5940011987107840

Fuzzer: inferno_twister_c
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: UNKNOWN READ
Crash Address: 0x2729ba10
Crash State:
  libGLESv2_swiftshader
  libGLESv2_swiftshader
  libGLESv2_swiftshader
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=500372:500415

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5940011987107840

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by sheriffbot@chromium.org, Sep 9 2017

Labels: M-62
Project Member

Comment 2 by sheriffbot@chromium.org, Sep 9 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Sep 9 2017

Labels: Pri-1
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 10 2017

Labels: -Security_Impact-Head Security_Impact-Beta
Components: Internals>GPU>SwiftShader

Comment 6 by mea...@chromium.org, Sep 15 2017

Owner: sugoi@chromium.org
Status: Assigned (was: Untriaged)
sugoi: Assigning to you, please feel free to reassign. Thanks.
Project Member

Comment 7 by sheriffbot@chromium.org, Sep 23 2017

sugoi: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
sugoi@ have you been able to take a look at this bug? It's currently impacting Beta and is blocking Stable for M62 and we're closing in on M62 Final Beta.

Thanks!

Comment 9 by sugoi@chromium.org, Oct 3 2017

Cc: capn@chromium.org
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://swiftshader.googlesource.com/SwiftShader.git/+/355a5dc1b228bc57a5ffe932b0b9b69d8726b63a

commit 355a5dc1b228bc57a5ffe932b0b9b69d8726b63a
Author: Alexis Hetu <sugoi@google.com>
Date: Tue Oct 03 13:43:56 2017

Adding support for more format/internalformat combinations

OpenGLES 3.0 allows for more combinations of format/internalformat
for floating point types. These types were already supported, just
not using the combinations added here.

 Bug chromium:763384 

Change-Id: I146548c2920799c7ea0d5d537d556ba562708147
Reviewed-on: https://swiftshader-review.googlesource.com/12928
Tested-by: Alexis Hétu <sugoi@google.com>
Reviewed-by: Nicolas Capens <nicolascapens@google.com>

[modify] https://crrev.com/355a5dc1b228bc57a5ffe932b0b9b69d8726b63a/src/OpenGL/common/Image.cpp

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5955bc576d147925fb8966ca7b91a23f7c91591e

commit 5955bc576d147925fb8966ca7b91a23f7c91591e
Author: Alexis Hetu <sugoi@google.com>
Date: Wed Oct 04 01:03:13 2017

Roll SwiftShader bc6ce4f..9d56da2

https://swiftshader.googlesource.com/SwiftShader.git/+log/bc6ce4f..9d56da2

BUG= chromium:763382 , chromium:763384 , chromium:763435 , chromium:765094 , chromium:765791 , chromium:765939 

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: Idd52bdc26eba54615838baf5dc65705a8a4be631
Reviewed-on: https://chromium-review.googlesource.com/699156
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506259}
[modify] https://crrev.com/5955bc576d147925fb8966ca7b91a23f7c91591e/DEPS

Project Member

Comment 12 by ClusterFuzz, Oct 4 2017

ClusterFuzz has detected this issue as fixed in range 506256:506287.

Detailed report: https://clusterfuzz.com/testcase?key=5940011987107840

Fuzzer: inferno_twister_c
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: UNKNOWN READ
Crash Address: 0x26cbb110
Crash State:
  libGLESv2_swiftshader
  libGLESv2_swiftshader
  libGLESv2_swiftshader
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=500372:500415
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=506256:506287

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5940011987107840

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by ClusterFuzz, Oct 4 2017

ClusterFuzz has detected this issue as fixed in range 506256:506287.

Detailed report: https://clusterfuzz.com/testcase?key=5940011987107840

Fuzzer: inferno_twister_c
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: UNKNOWN READ
Crash Address: 0x26cbb110
Crash State:
  libGLESv2_swiftshader
  libGLESv2_swiftshader
  libGLESv2_swiftshader
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=500372:500415
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=506256:506287

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5940011987107840

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 14 by ClusterFuzz, Oct 4 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5940011987107840 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 15 by sheriffbot@chromium.org, Oct 4 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Project Member

Comment 17 by sheriffbot@chromium.org, Jan 10 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 18 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Beta -M-62 M-65 Security_Impact-Stable

Sign in to add a comment