Issue metadata
Sign in to add a comment
|
Ext4-Migration: Necessary battery level to start migration is inconsistent. |
||||||||||||||||||||||
Issue descriptionChrome Version: ToT OS: Chrome What steps will reproduce the problem? (1) Create a profile in ecryptfs (for example, create a profile in M58) (2) Update Chrome OS version which requires ext4 crypto. (3) Attempt to login to the created user in 1). (4) Observe the message "Update will begin when battery reaches 30%". What is the expected result? / What happens instead? The UI says update will begin when battery reaches 30%, but it actually starts when battery reaches 10%. The necessary battery level was reduced from 30% to 10% (https://chromium-review.googlesource.com/c/chromium/src/+/641473), but the UI does not catch up with the change.
,
Sep 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4a0a2f1cea01e9f212e75b3d32f8469be70ad54d commit 4a0a2f1cea01e9f212e75b3d32f8469be70ad54d Author: Naoki Fukino <fukino@chromium.org> Date: Mon Sep 11 07:54:09 2017 Ext4 Migration: Pass the actual minimum battery level to start migration to UI. The minimum battery level was reduced from 30% to 10%, but the message in the migration UI did not catch up with the change. The minimum level should be passed to the UI instead of using fixed value. Bug: 763370 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3c20423ac0ff47b49c6e6b9a73effef076741a0f Reviewed-on: https://chromium-review.googlesource.com/657777 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#500855} [modify] https://crrev.com/4a0a2f1cea01e9f212e75b3d32f8469be70ad54d/chrome/browser/resources/chromeos/login/encryption_migration.html [modify] https://crrev.com/4a0a2f1cea01e9f212e75b3d32f8469be70ad54d/chrome/browser/resources/chromeos/login/encryption_migration.js [modify] https://crrev.com/4a0a2f1cea01e9f212e75b3d32f8469be70ad54d/chrome/browser/resources/chromeos/login/screen_encryption_migration.js [modify] https://crrev.com/4a0a2f1cea01e9f212e75b3d32f8469be70ad54d/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
,
Sep 11 2017
I'd like to merge the fix to M62, and M61 is possible. The UI says "Update will begin when battery reaches 30%", but it actually starts when battery reaches 10%. This does not cause any migration failures, but the wrong message on screen can surprise users. The fix is simple (only changes the message in migration screen), so should be relatively safe.
,
Sep 11 2017
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 11 2017
,
Sep 11 2017
Approving merge to M61 and M62.
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12f8e31c561c96e049e2be986a5c86754bb6e118 commit 12f8e31c561c96e049e2be986a5c86754bb6e118 Author: Naoki Fukino <fukino@chromium.org> Date: Tue Sep 12 03:56:39 2017 Ext4 Migration: Pass the actual minimum battery level to start migration to UI. The minimum battery level was reduced from 30% to 10%, but the message in the migration UI did not catch up with the change. The minimum level should be passed to the UI instead of using fixed value. Bug: 763370 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3c20423ac0ff47b49c6e6b9a73effef076741a0f Reviewed-on: https://chromium-review.googlesource.com/657777 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#500855}(cherry picked from commit 4a0a2f1cea01e9f212e75b3d32f8469be70ad54d) Reviewed-on: https://chromium-review.googlesource.com/661999 Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#156} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/12f8e31c561c96e049e2be986a5c86754bb6e118/chrome/browser/resources/chromeos/login/encryption_migration.html [modify] https://crrev.com/12f8e31c561c96e049e2be986a5c86754bb6e118/chrome/browser/resources/chromeos/login/encryption_migration.js [modify] https://crrev.com/12f8e31c561c96e049e2be986a5c86754bb6e118/chrome/browser/resources/chromeos/login/screen_encryption_migration.js [modify] https://crrev.com/12f8e31c561c96e049e2be986a5c86754bb6e118/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c8cea5ae3684dda3225b0001fbdbc0308a0c1c5 commit 2c8cea5ae3684dda3225b0001fbdbc0308a0c1c5 Author: Naoki Fukino <fukino@chromium.org> Date: Tue Sep 12 03:57:39 2017 Ext4 Migration: Pass the actual minimum battery level to start migration to UI. The minimum battery level was reduced from 30% to 10%, but the message in the migration UI did not catch up with the change. The minimum level should be passed to the UI instead of using fixed value. Bug: 763370 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3c20423ac0ff47b49c6e6b9a73effef076741a0f Reviewed-on: https://chromium-review.googlesource.com/657777 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Pavol Marko <pmarko@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#500855}(cherry picked from commit 4a0a2f1cea01e9f212e75b3d32f8469be70ad54d) Reviewed-on: https://chromium-review.googlesource.com/662000 Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#1169} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/2c8cea5ae3684dda3225b0001fbdbc0308a0c1c5/chrome/browser/resources/chromeos/login/encryption_migration.html [modify] https://crrev.com/2c8cea5ae3684dda3225b0001fbdbc0308a0c1c5/chrome/browser/resources/chromeos/login/encryption_migration.js [modify] https://crrev.com/2c8cea5ae3684dda3225b0001fbdbc0308a0c1c5/chrome/browser/resources/chromeos/login/screen_encryption_migration.js [modify] https://crrev.com/2c8cea5ae3684dda3225b0001fbdbc0308a0c1c5/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
,
Sep 12 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pmarko@chromium.org
, Sep 9 2017