Issue metadata
Sign in to add a comment
|
Regression: Gap is reduced and looks weird between Copies textbox and Collate checkbox for Hindi language.
Reported by
dchau...@etouch.net,
Sep 8 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version: 62.0.3202.13 (Official Build)8aba0a34f8ab922b12535ce172e7ae6434d8e603-refs/branch-heads/3202@{#75} (32/64 bit). OS: Windows (7,8,10). What steps will reproduce the problem? 1. Launch chrome and change browser language to Hindi. 2. Give print command on any page and enter 2 in प्रतियां section. 3. Now observe the gap between textbox and checkbox. Gap is not seen properly between textbox and checkbox. (Refer Screenshot) Gap should seen properly between textbox and checkbox. This is a regression issue, broken in M-56 series, below is manual regression range. Good build: 56.0.2897.0 Bad build: 56.0.2899.0 Note: This issue is not seen on Mac and Linux OS. You are probably looking for a change made after 426690 (known good), but no later than 426691 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/664d4716b91e01c779a77702e9f219c2744724e0..ee33e4e0e8e7da42e4f7cae338da35e851b300fa Suspecting: https://chromium.googlesource.com/chromium/src/+/ee33e4e0e8e7da42e4f7cae338da35e851b300fa @rbpotter: Kindly help to reassign, if your changes are not related to this issue.
,
Sep 11 2017
Hi, This is not a localization bug. Can't confirm that it's still relevant to the current English UI. Regards!
,
Sep 12 2017
With response to comment #2: Retested this issue on Windows machines using latest Canary 63.0.3212.0 (Official Build). It's still reproducible for Hindi language. Note: This issue is only reproducible after changing the browser language to Hindi, It is not reproducible for English UI, i.e. GAP is proper between Copies and Collate checkbox for English UI. Attaching screen-cast for the same.
,
Sep 12 2017
RE: comment 2, the issue more generally is that the Collate textbox gets pushed onto a second line in languages where the translation of "Collate" is long. This also reproduces in Russian, for example. The checkbox moving to the next line does not appear to have been planned for, so it looks odd both before and after the change (though the change definitely makes things slightly worse by reducing the gap).
,
Sep 12 2017
Hi, This is noted and thanks for the clarifications. We'll check on this case and let you know for any updates. Kind Regards, Marvin
,
Sep 12 2017
Hi, This has now been reported. We'll update you all if the POC's already responded. Regards!
,
Sep 14 2017
Hi All, Please see the below response of the POC: "I don't think this is a linguistic issue and shortening the translation will perhaps have no impact. Nonetheless, I have shortened the translation as much as I could." Kind Regards, Marvin
,
Sep 14 2017
,
Sep 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23d9fca0c4804dc045f254937c53961879125130 commit 23d9fca0c4804dc045f254937c53961879125130 Author: rbpotter <rbpotter@chromium.org> Date: Tue Sep 19 17:55:37 2017 Print Preview: Make collate look better when on second line The collate checkbox looks odd in languages (Hindi, Russian) where the "Collate" text is too long and the box is pushed onto another line (below the "Copies" input box). Make the input box + checkbox look like the scaling input box + fit to page checkbox in languages where this is the case. Bug: 763339 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifd83fdb5c274beafcf790b3f469804980c47f6b2 Reviewed-on: https://chromium-review.googlesource.com/662177 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#502890} [modify] https://crrev.com/23d9fca0c4804dc045f254937c53961879125130/chrome/browser/resources/print_preview/print_preview.css [modify] https://crrev.com/23d9fca0c4804dc045f254937c53961879125130/chrome/browser/resources/print_preview/print_preview.html [delete] https://crrev.com/6651aff71ddd37cc86bcb99e459a718da06d759e/chrome/browser/resources/print_preview/settings/copies_settings.css [delete] https://crrev.com/6651aff71ddd37cc86bcb99e459a718da06d759e/chrome/browser/resources/print_preview/settings/scaling_settings.css [modify] https://crrev.com/23d9fca0c4804dc045f254937c53961879125130/chrome/browser/resources/print_preview/settings/settings_box.css |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbpotter@chromium.org
, Sep 8 2017