New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763337 link

Starred by 20 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

box-shadow behaviour on <td> elements while using overflow: auto

Reported by lukas.po...@googlemail.com, Sep 8 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.79 Safari/537.36

Steps to reproduce the problem:
Run: https://jsfiddle.net/1q98o385/5/ in "Version 61.0.3163.79 (Official Build) (64-Bit)"

What is the expected behavior?
No scrollbars while hovering.

What went wrong?
Scrollbars are shown when right or bottom table cells are getting hovered.
The width of the specified box-shadow seems to be taken into account.

Did this work before? Yes Not exactly sure. It worked until this update.

Does this work in other browsers? Yes

Chrome version: 61.0.3163.79  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 26.0 r0

https://jsfiddle.net/1q98o385/5/
 
test.txt
572 bytes View Download

Comment 1 Deleted

Cc: gov...@chromium.org e...@chromium.org
Components: Blink>Layout
Labels: ReleaseBlock-Stable M-61
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 7,10 and the same wasn't reproducible on Mac. 

Please find bisect result below :

You are probably looking for a change made after 476218 (known good), but no lat
er than 476219 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/3ac5e57d366931ea57244c45b01d55c01774fdfb..ed6724976ba56938ae7be863b63758456e0b2387
Labels: -ReleaseBlock-Stable -M-61 M-62
Will fix in M-62.
Components: -Blink>CSS
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5eb082d971e76308d9f95167db1bb67222a28e7

commit b5eb082d971e76308d9f95167db1bb67222a28e7
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Sep 12 06:18:43 2017

Fix table layout overflow that included all contents visual overflows

crrev.com/c/515606 overly simplified table layout overflow which is
expected to cover all collapsed border overflows. The CL added all
visual overflow into layout overflow causing it to also unexpectedly
cover all contents overflows (e.g. shadow and outlines of descendants).

Fix the issue by just include collapsed border overflow.

Bug:  763337 
Change-Id: I6c53afba3f00729a483588dfea46c86a8b78562a
Reviewed-on: https://chromium-review.googlesource.com/657815
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@opera.com>
Cr-Commit-Position: refs/heads/master@{#501201}
[modify] https://crrev.com/b5eb082d971e76308d9f95167db1bb67222a28e7/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/file/file-input-direction-expected.txt
[modify] https://crrev.com/b5eb082d971e76308d9f95167db1bb67222a28e7/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/file/file-input-direction-expected.txt
[modify] https://crrev.com/b5eb082d971e76308d9f95167db1bb67222a28e7/third_party/WebKit/LayoutTests/platform/mac/fast/forms/file/file-input-direction-expected.txt
[modify] https://crrev.com/b5eb082d971e76308d9f95167db1bb67222a28e7/third_party/WebKit/Source/core/layout/LayoutTable.cpp
[modify] https://crrev.com/b5eb082d971e76308d9f95167db1bb67222a28e7/third_party/WebKit/Source/core/layout/LayoutTable.h
[modify] https://crrev.com/b5eb082d971e76308d9f95167db1bb67222a28e7/third_party/WebKit/Source/core/layout/LayoutTableTest.cpp

Labels: Merge-Request-62
This CL need to be merged together with the CL for  bug 764284 .
Labels: OS-Android OS-Chrome OS-Linux OS-Mac
Project Member

Comment 8 by sheriffbot@chromium.org, Sep 14 2017

Labels: -Merge-Request-62 Merge-Review-62 Hotlist-Merge-Review
This bug requires manual review: M62 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-62 Merge-Approved-62
Approving merge to M62. Branch:3202
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 14 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d28d639f2b1e403f10c8352b5ed95e60d37d13e

commit 4d28d639f2b1e403f10c8352b5ed95e60d37d13e
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Sep 14 23:21:41 2017

Fix table layout overflow that included all contents visual overflows

crrev.com/c/515606 overly simplified table layout overflow which is
expected to cover all collapsed border overflows. The CL added all
visual overflow into layout overflow causing it to also unexpectedly
cover all contents overflows (e.g. shadow and outlines of descendants).

Fix the issue by just include collapsed border overflow.

TBR=wangxianzhu@chromium.org

(cherry picked from commit b5eb082d971e76308d9f95167db1bb67222a28e7)

Bug:  763337 
Change-Id: I6c53afba3f00729a483588dfea46c86a8b78562a
Reviewed-on: https://chromium-review.googlesource.com/657815
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@opera.com>
Cr-Original-Commit-Position: refs/heads/master@{#501201}
Reviewed-on: https://chromium-review.googlesource.com/667744
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#240}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/4d28d639f2b1e403f10c8352b5ed95e60d37d13e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/file/file-input-direction-expected.txt
[modify] https://crrev.com/4d28d639f2b1e403f10c8352b5ed95e60d37d13e/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/file/file-input-direction-expected.txt
[modify] https://crrev.com/4d28d639f2b1e403f10c8352b5ed95e60d37d13e/third_party/WebKit/LayoutTests/platform/mac/fast/forms/file/file-input-direction-expected.txt
[modify] https://crrev.com/4d28d639f2b1e403f10c8352b5ed95e60d37d13e/third_party/WebKit/Source/core/layout/LayoutTable.cpp
[modify] https://crrev.com/4d28d639f2b1e403f10c8352b5ed95e60d37d13e/third_party/WebKit/Source/core/layout/LayoutTable.h
[modify] https://crrev.com/4d28d639f2b1e403f10c8352b5ed95e60d37d13e/third_party/WebKit/Source/core/layout/LayoutTableTest.cpp

Status: Fixed (was: Assigned)
Cc: sc00335...@techmahindra.com wangxianzhu@chromium.org
 Issue 767286  has been merged into this issue.
Cc: divya.pa...@techmahindra.com
 Issue 767436  has been merged into this issue.
 Issue 768803  has been merged into this issue.
 Issue 768767  has been merged into this issue.
 Issue 769791  has been merged into this issue.
Labels: Merge-Review-61
PMs, given that multiple bugs have been reported on M61, it seems that the bug has some real impact. Do you think we should merge the fix into M61? The fix has been in beta channel for 2 weeks and should have been baked well.
Cc: pbomm...@chromium.org abdulsyed@chromium.org cma...@chromium.org
This bug requires two merges(change listed at #5 and #6). Will both changes will be fully safe to merge as M61 is already out at 100% stable?

Also at the moment there is no plan for M61 Desktop respin. Is this bug itself require stable respin? Or we can pick it for future M61 refresh (if any)?

I think both of the merges are safe. It doesn't require a respin. It'll be good if there is a refresh.

 Issue 769697  has been merged into this issue.
 Issue 770835  has been merged into this issue.
Labels: -Merge-Review-61
Let's just wait for M-62 stable.
Cc: susanjuniab@chromium.org
 Issue 774486  has been merged into this issue.

Sign in to add a comment