Issue metadata
Sign in to add a comment
|
51.4% regression in smoothness.gpu_rasterization.tough_path_rendering_cases at 499965:500084 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Sep 8 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8969026334403378096
,
Sep 8 2017
=== Auto-CCing suspected CL author egdaniel@google.com === Hi egdaniel@google.com, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Greg Daniel Commit : 52cb5fe23b8f960bb3248620c8f4e2f2957b6685 Date : Wed Sep 06 14:41:18 2017 Subject: Remove isMipMapped from GrSurfaceDesc Bisect Details Configuration: android_one_perf_bisect Benchmark : smoothness.gpu_rasterization.tough_path_rendering_cases Metric : frame_times/GUIMark Vector Chart Test Change : 44.42% | 46.9117234262 -> 67.7478226302 Revision Result N chromium@499964 46.9117 +- 4.78573 6 good chromium@500024 46.0572 +- 1.28099 6 good chromium@500054 46.2382 +- 1.90185 6 good chromium@500062 46.176 +- 0.99383 6 good chromium@500063 46.0252 +- 1.22502 6 good chromium@500063,skia@52cb5fe23b 67.4306 +- 1.18556 6 bad <-- chromium@500063,skia@e1fbf17058 66.9666 +- 2.2766 6 bad chromium@500064 67.3929 +- 1.4935 6 bad chromium@500066 67.8482 +- 1.57946 6 bad chromium@500069 67.0627 +- 1.75965 6 bad chromium@500084 67.7478 +- 1.21909 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=GUIMark.Vector.Chart.Test smoothness.gpu_rasterization.tough_path_rendering_cases More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8969026334403378096 For feedback, file a bug with component Speed>Bisection
,
Sep 8 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8969005598547412096
,
Sep 8 2017
=== BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Greg Daniel Commit : 52cb5fe23b8f960bb3248620c8f4e2f2957b6685 Date : Wed Sep 06 14:41:18 2017 Subject: Remove isMipMapped from GrSurfaceDesc Bisect Details Configuration: android_one_perf_bisect Benchmark : smoothness.gpu_rasterization.tough_path_rendering_cases Metric : frame_times/GUIMark Vector Chart Test Change : 43.79% | 46.9445800338 -> 67.5022499941 Revision Result N chromium@499964 46.9446 +- 4.99801 6 good chromium@500024 46.308 +- 0.643747 6 good chromium@500054 45.9445 +- 0.758138 6 good chromium@500062 46.0451 +- 0.299592 6 good chromium@500063 46.1515 +- 0.891444 6 good chromium@500063,skia@52cb5fe23b 67.1178 +- 0.926095 6 bad <-- chromium@500063,skia@e1fbf17058 67.3102 +- 1.73315 6 bad chromium@500064 67.3807 +- 1.64398 6 bad chromium@500066 68.2932 +- 2.10038 6 bad chromium@500069 67.1181 +- 2.23316 6 bad chromium@500084 67.5022 +- 1.35017 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=GUIMark.Vector.Chart.Test smoothness.gpu_rasterization.tough_path_rendering_cases More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8969005598547412096 For feedback, file a bug with component Speed>Bisection
,
Sep 8 2017
The following revision refers to this bug: https://skia.googlesource.com/skia/+/21918231b25037f6ae98a9a431d9e107e8b29f08 commit 21918231b25037f6ae98a9a431d9e107e8b29f08 Author: Greg Daniel <egdaniel@google.com> Date: Fri Sep 08 19:58:18 2017 Revert "Remove isMipMapped from GrSurfaceDesc" and follow up find exact scratch CL This reverts commit 52cb5fe23b8f960bb3248620c8f4e2f2957b6685. This reverts commit e1fbf170580a4b932d0abcb11593fb1ef0cac60b. TBR:bsalomon@googole.com Bug: chromium:763333 Change-Id: Ie94e00c3c7231e32f009b9dc7bb51ebb53baf7b1 Reviewed-on: https://skia-review.googlesource.com/44400 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com> [modify] https://crrev.com/21918231b25037f6ae98a9a431d9e107e8b29f08/src/effects/SkBlurMaskFilter.cpp [modify] https://crrev.com/21918231b25037f6ae98a9a431d9e107e8b29f08/include/gpu/GrTypes.h [modify] https://crrev.com/21918231b25037f6ae98a9a431d9e107e8b29f08/tests/ResourceCacheTest.cpp [modify] https://crrev.com/21918231b25037f6ae98a9a431d9e107e8b29f08/tests/GrSurfaceTest.cpp [modify] https://crrev.com/21918231b25037f6ae98a9a431d9e107e8b29f08/src/gpu/GrResourceProvider.cpp [modify] https://crrev.com/21918231b25037f6ae98a9a431d9e107e8b29f08/src/gpu/GrTextureProxy.cpp [modify] https://crrev.com/21918231b25037f6ae98a9a431d9e107e8b29f08/src/gpu/SkGr.cpp [modify] https://crrev.com/21918231b25037f6ae98a9a431d9e107e8b29f08/src/gpu/GrTexturePriv.h [modify] https://crrev.com/21918231b25037f6ae98a9a431d9e107e8b29f08/src/gpu/GrSurfaceProxy.cpp [modify] https://crrev.com/21918231b25037f6ae98a9a431d9e107e8b29f08/src/gpu/GrTexture.cpp [modify] https://crrev.com/21918231b25037f6ae98a9a431d9e107e8b29f08/src/gpu/GrResourceProvider.h [modify] https://crrev.com/21918231b25037f6ae98a9a431d9e107e8b29f08/src/gpu/GrBackendTextureImageGenerator.cpp
,
Sep 25 2017
fixed by reverting original change |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Sep 8 2017