Implement according to spec.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0229213f6bf1791880a60bc7ed0fdb0bc99bb9fa commit 0229213f6bf1791880a60bc7ed0fdb0bc99bb9fa Author: Guido Urdaneta <guidou@chromium.org> Date: Mon Jan 08 13:30:50 2018 Remove unused parameters in UserMediaProcessor. This concerns audio tracks and is a cleanup previous to supporing applyConstraints() for audio tracks. Bug: 763320 Change-Id: I0c6d524b5d501a0615bdc08728f3431dae08b61d Reviewed-on: https://chromium-review.googlesource.com/836889 Reviewed-by: Harald Alvestrand <hta@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#527621} [modify] https://crrev.com/0229213f6bf1791880a60bc7ed0fdb0bc99bb9fa/content/renderer/media/user_media_client_impl_unittest.cc [modify] https://crrev.com/0229213f6bf1791880a60bc7ed0fdb0bc99bb9fa/content/renderer/media/user_media_processor.cc [modify] https://crrev.com/0229213f6bf1791880a60bc7ed0fdb0bc99bb9fa/content/renderer/media/user_media_processor.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d257bc72a2090cd638ae3b0de72b6306933df3a commit 3d257bc72a2090cd638ae3b0de72b6306933df3a Author: Guido Urdaneta <guidou@chromium.org> Date: Tue Jan 16 12:51:37 2018 Add MediaStreamTrack.applyConstraints() support to audio tracks This implementation adds spec-compliant support, but it does not allow changing settings. applyConstraints() calls that can be satisfied with the track's current settings will succeed and all other cases will result in a rejected promise in accordance to the spec. This replaces the current behavior of always rejecting the promise, which is not spec compliant. The ability to change the settings of an audio track will be added in the future. Bug: 763320 Change-Id: Idd0b49bf755b73cb0c2bd5ef0bb5e473b87e1397 Reviewed-on: https://chromium-review.googlesource.com/857472 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#529408} [modify] https://crrev.com/3d257bc72a2090cd638ae3b0de72b6306933df3a/content/renderer/media/apply_constraints_processor.cc [modify] https://crrev.com/3d257bc72a2090cd638ae3b0de72b6306933df3a/content/renderer/media/apply_constraints_processor.h [modify] https://crrev.com/3d257bc72a2090cd638ae3b0de72b6306933df3a/content/renderer/media/local_media_stream_audio_source.cc [modify] https://crrev.com/3d257bc72a2090cd638ae3b0de72b6306933df3a/content/renderer/media/local_media_stream_audio_source.h [modify] https://crrev.com/3d257bc72a2090cd638ae3b0de72b6306933df3a/content/renderer/media/media_stream_audio_processor_options.cc [modify] https://crrev.com/3d257bc72a2090cd638ae3b0de72b6306933df3a/content/renderer/media/media_stream_audio_processor_options.h [modify] https://crrev.com/3d257bc72a2090cd638ae3b0de72b6306933df3a/content/renderer/media/media_stream_audio_processor_unittest.cc [modify] https://crrev.com/3d257bc72a2090cd638ae3b0de72b6306933df3a/content/renderer/media/media_stream_audio_source.cc [modify] https://crrev.com/3d257bc72a2090cd638ae3b0de72b6306933df3a/content/renderer/media/media_stream_audio_source.h [modify] https://crrev.com/3d257bc72a2090cd638ae3b0de72b6306933df3a/content/renderer/media/media_stream_constraints_util.cc [modify] https://crrev.com/3d257bc72a2090cd638ae3b0de72b6306933df3a/content/renderer/media/media_stream_constraints_util_audio.cc [modify] https://crrev.com/3d257bc72a2090cd638ae3b0de72b6306933df3a/content/renderer/media/media_stream_constraints_util_audio.h [modify] https://crrev.com/3d257bc72a2090cd638ae3b0de72b6306933df3a/content/renderer/media/media_stream_constraints_util_audio_unittest.cc [modify] https://crrev.com/3d257bc72a2090cd638ae3b0de72b6306933df3a/content/renderer/media/rtc_peer_connection_handler_unittest.cc [modify] https://crrev.com/3d257bc72a2090cd638ae3b0de72b6306933df3a/content/renderer/media/user_media_processor.cc [modify] https://crrev.com/3d257bc72a2090cd638ae3b0de72b6306933df3a/content/renderer/media/webrtc/processed_local_audio_source.cc [modify] https://crrev.com/3d257bc72a2090cd638ae3b0de72b6306933df3a/content/renderer/media/webrtc/processed_local_audio_source.h [modify] https://crrev.com/3d257bc72a2090cd638ae3b0de72b6306933df3a/content/renderer/media/webrtc/processed_local_audio_source_unittest.cc [modify] https://crrev.com/3d257bc72a2090cd638ae3b0de72b6306933df3a/content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc
Closing since applyConstraints is now implemented according to spec. Support for specific constrainable properties and reconfiguration is tracked in separate bugs.
Comment 1 by guidou@chromium.org
, Sep 8 2017