Issue metadata
Sign in to add a comment
|
Regression : Unable to drag 'Name','Size','Type', 'Date modified' columns in Files App |
||||||||||||||||||||||
Issue descriptionChrome Version: 62.0.3202.12/9901.8.0 dev-channel Candy,Reks and Daisy OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Download image or Take Screenshot using 'Ctrl+F5(Overview Mode Button)' (2)Now go to Files App-> Try to drag 'Name','Size','Type', 'Date modified' columns and observe (Please refer Video) Expected: Should be able to drag 'Name','Size','Type', 'Date modified' columns Actual: Instead Unable to drag 'Name','Size','Type', 'Date modified' columns This is Regression Issue as same is working fine in 62.0.3193.0/9869.0.0 dev-channel Daisy @fukino : Please confirm the Issue Note: Issue is also seen on Latest M-63
,
Sep 8 2017
I've identified cr.ui.Splitter is not receiving mousedown event at all after this change as it's been cancelled at pointerdown event. https://chromium-review.googlesource.com/c/chromium/src/+/641010/9/ui/file_manager/file_manager/foreground/js/ui/file_table.js So we're reverting the change.
,
Sep 8 2017
,
Sep 8 2017
https://chromium.googlesource.com/chromium/src.git/+/0c2197b56fc84a027edb276958201cef7d0952a8 commit 0c2197b56fc84a027edb276958201cef7d0952a8 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Fri Sep 08 12:49:43 2017 Revert "Prevent long-tapping on the header from changing focus." This reverts commit 128d8d0b7d28106be840701b9e3aa87fe7ae07e4. Reason for revert: Regression; it prevented "resize column by mouse drag" functionality. https://bugs.chromium.org/p/chromium/issues/detail?id=763316
,
Sep 8 2017
Considering the branch point, this issue should be happening on M62 now. This is relatively large impact although the fix is simple. Should we merge the fix to M62 branch as well?
,
Sep 8 2017
Yes, let's merge the revert to M62.
,
Sep 8 2017
,
Sep 9 2017
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 11 2017
The fix was merged to M62. The commit message was updated on https://bugs.chromium.org/p/chromium/issues/detail?id=752389#c20 I manually changed the label Merge-Merged-62 to merge-merged-3202 on this issue. ----------------------------------------------------------------- The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae3d372b13143030f8e0e5284d812ae9a6df6709 commit ae3d372b13143030f8e0e5284d812ae9a6df6709 Author: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Date: Mon Sep 11 10:58:06 2017 Revert "Prevent long-tapping on the header from changing focus." This reverts commit 128d8d0b7d28106be840701b9e3aa87fe7ae07e4. Reason for revert: Regression; it prevented "resize column by mouse drag" functionality. https://bugs.chromium.org/p/chromium/issues/detail?id=763316 Original change's description: > Prevent long-tapping on the header from changing focus. > > Before: > Long-tapping the header caused losing focus on the list by triggering a 'contextmenu' > After: > Focus is no longer lost when long-tapping the header. > > Bug: 752389 > Test: manual tests > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I9e9bb58955feefc91d5b6425d2b020aad0a2949a > Reviewed-on: https://chromium-review.googlesource.com/641010 > Reviewed-by: Naoki Fukino <fukino@chromium.org> > Reviewed-by: Keigo Oka <oka@chromium.org> > Commit-Queue: Marianne Thieffry <mariannet@google.com> > Cr-Commit-Position: refs/heads/master@{#498418} TBR=fukino@chromium.org,oka@chromium.org,mariannet@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 752389 Change-Id: I79da44e2772b64fef59bdb1b6d1905fb4fb26999 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/657458 Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#500573}(cherry picked from commit 0c2197b56fc84a027edb276958201cef7d0952a8) Reviewed-on: https://chromium-review.googlesource.com/659639 Reviewed-by: Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#117} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/ae3d372b13143030f8e0e5284d812ae9a6df6709/ui/file_manager/file_manager/foreground/js/ui/file_table.js
,
Sep 11 2017
,
Oct 25 2017
9901.54.0, 62.0.3202.74 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by fukino@chromium.org
, Sep 8 2017Owner: yamaguchi@chromium.org