Issue metadata
Sign in to add a comment
|
Regression :Focus is not clear on checkbox in 'Add person' overlay.
Reported by
vineetha...@etouch.net,
Sep 8 2017
|
||||||||||||||||||||||
Issue descriptionVersion: 62.0.3202.13 8aba0a34f8ab922b12535ce172e7ae6434d8e603-refs/branch-heads/3202@{#75} OS: Windows (7,8,8.1,10) What steps will reproduce the problem? 1.Launch chrome, click on Avatar icon at the top R.H.S. and then click on "Manage People". 2.Click on Add Person, try to get focus on the checkbox "Create a desktop shortcut for this user" and observe. Actual Result: Focus is not clear on checkbox. Expected Result: Focus should be clear on checkbox. This is regression issue, broken in ‘M 62’ and below is the CL : Good build:62.0.3193.0 Bad build: 62.0.3194.0 Change Log URL: https://chromium.googlesource.com/chromium/src/+log/62.0.3193.0..62.0.3194.0?pretty=fuller&n=10000 Note:Providing the bisect from Change Log URL as script were not giving possible CL Suspecting : r496369 ? from Change Log @stevenjb : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note : Issue is not seen on Mac and Linux OS.
,
Sep 8 2017
Handing off to Hector (thanks Hector!).
,
Sep 9 2017
,
Sep 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69781235340f1cd476ebb8baa0b7a6fae5fcc31e commit 69781235340f1cd476ebb8baa0b7a6fae5fcc31e Author: Hector Carmona <hcarmona@chromium.org> Date: Sat Sep 09 03:03:45 2017 Style the checkboxes in the 'Add person' overlay. R=dschuyler@chromium.org Bug: 763309 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5692d0e828a217e2bb38409e27c2f6b5f62a9592 Reviewed-on: https://chromium-review.googlesource.com/658493 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#500785} [modify] https://crrev.com/69781235340f1cd476ebb8baa0b7a6fae5fcc31e/chrome/browser/resources/md_user_manager/create_profile.html
,
Sep 11 2017
Tested the issue on Windows-10 & 7 using chrome latest Canary M63-63.0.3212.0 by following steps mentioned in the original comment. Observed that focus is displaying as expected. Hence adding TE-Verified label. Please find the screen shot for reference. Thank you!
,
Sep 11 2017
,
Sep 12 2017
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c71ad722c89ba972089fd22bf78b32423b567dd commit 7c71ad722c89ba972089fd22bf78b32423b567dd Author: Hector Carmona <hcarmona@chromium.org> Date: Wed Sep 13 00:35:31 2017 Style the checkboxes in the 'Add person' overlay. R=dschuyler@chromium.org TBR=hcarmona@chromium.org (cherry picked from commit 69781235340f1cd476ebb8baa0b7a6fae5fcc31e) Bug: 763309 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5692d0e828a217e2bb38409e27c2f6b5f62a9592 Reviewed-on: https://chromium-review.googlesource.com/658493 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#500785} Reviewed-on: https://chromium-review.googlesource.com/664360 Reviewed-by: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#190} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/7c71ad722c89ba972089fd22bf78b32423b567dd/chrome/browser/resources/md_user_manager/create_profile.html
,
Sep 13 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by steve...@chromium.org
, Sep 8 2017Owner: dschuyler@chromium.org