New issue
Advanced search Search tips

Issue 763265 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

[css-grid] Use transferred size over content size for automatic minimum size

Project Member Reported by r...@igalia.com, Sep 8 2017

Issue description

CSS WG has agreed to modify the spec so now the transferred size is used
(if it exists) independently if it's bigger or smaller
than the content size.
See: https://github.com/w3c/csswg-drafts/issues/1149

The spec text (https://drafts.csswg.org/css-grid/#min-size-auto):
  "The automatic minimum size for a grid item in a given dimension is
   its specified size if it exists, otherwise its transferred size
   if that exists, else its content size"


 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a66cfe5eaf03ad45306671b5567b942cab7a60c2

commit a66cfe5eaf03ad45306671b5567b942cab7a60c2
Author: Manuel Rego Casasnovas <rego@igalia.com>
Date: Sat Sep 09 17:33:24 2017

[css-grid] Use transferred size over content size for automatic minimum

CSS WG has agreed to modify the spec so now the transferred size is used
(if it exists) independently if it's bigger or smaller
than the content size.
See: https://github.com/w3c/csswg-drafts/issues/1149

The spec text (https://drafts.csswg.org/css-grid/#min-size-auto):
  "The automatic minimum size for a grid item in a given dimension is
   its specified size if it exists, otherwise its transferred size
   if that exists, else its content size"

This patch modifies GridTrackSizingAlgorithmStrategy::MinSizeForChild()
so it always returns the transferred size (if any).
This also updates the tests to check the new behavior.

BUG= 763265 

Change-Id: If6134e7d031a3f9693b8d9ca62f8f41d3146add2
Reviewed-on: https://chromium-review.googlesource.com/657098
Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#500799}
[modify] https://crrev.com/a66cfe5eaf03ad45306671b5567b942cab7a60c2/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/grid-items/grid-minimum-size-grid-items-006.html
[modify] https://crrev.com/a66cfe5eaf03ad45306671b5567b942cab7a60c2/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/grid-items/grid-minimum-size-grid-items-007.html
[modify] https://crrev.com/a66cfe5eaf03ad45306671b5567b942cab7a60c2/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/grid-items/grid-minimum-size-grid-items-008.html
[modify] https://crrev.com/a66cfe5eaf03ad45306671b5567b942cab7a60c2/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/grid-items/grid-minimum-size-grid-items-009.html
[modify] https://crrev.com/a66cfe5eaf03ad45306671b5567b942cab7a60c2/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/grid-items/grid-minimum-size-grid-items-021.html
[add] https://crrev.com/a66cfe5eaf03ad45306671b5567b942cab7a60c2/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/grid-items/support/25x50-green.png
[add] https://crrev.com/a66cfe5eaf03ad45306671b5567b942cab7a60c2/third_party/WebKit/LayoutTests/external/wpt/css/css-grid-1/grid-items/support/50x25-green.png
[modify] https://crrev.com/a66cfe5eaf03ad45306671b5567b942cab7a60c2/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-automatic-minimum-intrinsic-aspect-ratio.html
[modify] https://crrev.com/a66cfe5eaf03ad45306671b5567b942cab7a60c2/third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp

Comment 2 by r...@igalia.com, Sep 11 2017

Status: Fixed (was: Started)

Sign in to add a comment