New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763263 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression

Blocked on:
issue 705042



Sign in to add a comment

Non-BattOr desktop power monitoring code is failing, should be removed

Project Member Reported by mgiuca@chromium.org, Sep 8 2017

Issue description

telemetry_perf_unittests failing on 2 builders

benchmarks.benchmark_smoke_unittest.BenchmarkSmokeTest.dromaeo.domcoretraverse is flaky.

Builders failed on: 
- Win 7 Tests x64 (1): 
  https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29
- Win7 Tests (1): 
  https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29

Failing intermittently. Disabling test.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8a3adda2749fe8d6c58be9efee2a524ca62a87f

commit f8a3adda2749fe8d6c58be9efee2a524ca62a87f
Author: Matt Giuca <mgiuca@chromium.org>
Date: Fri Sep 08 06:56:03 2017

Disabled dromaeo.domcoretraverse benchmark on Windows.

Flaky on builders.

Bug:  763263 
Tbr: rnephew@chromium.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Idcc71bd1863a2fc21c464e3009e13dbdfb0a3ab2
Reviewed-on: https://chromium-review.googlesource.com/656740
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500529}
[modify] https://crrev.com/f8a3adda2749fe8d6c58be9efee2a524ca62a87f/tools/perf/benchmarks/dromaeo.py

Cc: mgiuca@chromium.org
Labels: -Sheriff-Chromium Pri-2 Type-Bug-Regression
Owner: rnep...@chromium.org
Status: Assigned (was: Started)
rnephew@: Please look at this test (which has been disabled), fix flake, and re-enable. Thanks.
Cc: nedngu...@google.com martiniss@chromium.org jbroman@chromium.org
The problem appears to be with accessing a dll called WinRing0x64.dll

I know very little about this benchmark, and even less about that dll.

Traceback (most recent call last):
    RunBenchmark at e:\b\swarm_slave\w\ir\third_party\catapult\telemetry\telemetry\internal\story_runner.py:332
      expectations=expectations, metadata=benchmark.GetMetadata())
    Run at e:\b\swarm_slave\w\ir\third_party\catapult\telemetry\telemetry\internal\story_runner.py:203
      _RunStoryAndProcessErrorIfNeeded(story, results, state, test)
    _RunStoryAndProcessErrorIfNeeded at e:\b\swarm_slave\w\ir\third_party\catapult\telemetry\telemetry\internal\story_runner.py:98
      state.WillRunStory(story)
    traced_function at e:\b\swarm_slave\w\ir\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py:52
      return func(*args, **kwargs)
    WillRunStory at e:\b\swarm_slave\w\ir\third_party\catapult\telemetry\telemetry\page\shared_page_state.py:247
      self._StartBrowser(page)
    traced_function at e:\b\swarm_slave\w\ir\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py:52
      return func(*args, **kwargs)
    _StartBrowser at e:\b\swarm_slave\w\ir\third_party\catapult\telemetry\telemetry\page\shared_page_state.py:205
      self._test.WillStartBrowser(self.platform)
    traced_function at e:\b\swarm_slave\w\ir\third_party\catapult\common\py_trace_event\py_trace_event\trace_event_impl\decorators.py:52
      return func(*args, **kwargs)
    WillStartBrowser at e:\b\swarm_slave\w\ir\tools\perf\benchmarks\dromaeo.py:30
      self._power_metric = power.PowerMetric(platform)
    __init__ at e:\b\swarm_slave\w\ir\tools\perf\metrics\power.py:39
      self._MeasureQuiescentPower(quiescent_measurement_time_s)
    _MeasureQuiescentPower at e:\b\swarm_slave\w\ir\tools\perf\metrics\power.py:59
      if (not self._platform.CanMonitorPower() or
    CanMonitorPower at e:\b\swarm_slave\w\ir\third_party\catapult\telemetry\telemetry\core\platform.py:256
      return self._platform_backend.CanMonitorPower()
    CanMonitorPower at e:\b\swarm_slave\w\ir\third_party\catapult\telemetry\telemetry\internal\platform\win_platform_backend.py:362
      return self._power_monitor.CanMonitorPower()
    CanMonitorPower at e:\b\swarm_slave\w\ir\third_party\catapult\telemetry\telemetry\internal\platform\power_monitor\msr_power_monitor.py:135
      return self._CheckMSRs()
    _CheckMSRs at e:\b\swarm_slave\w\ir\third_party\catapult\telemetry\telemetry\internal\platform\power_monitor\msr_power_monitor.py:86
      if self._PackageEnergyJoules() <= 0:
    _PackageEnergyJoules at e:\b\swarm_slave\w\ir\third_party\catapult\telemetry\telemetry\internal\platform\power_monitor\msr_power_monitor.py:73
      return (self._backend.ReadMsr(MSR_PKG_ENERGY_STATUS, 0, 32) *
    ReadMsr at e:\b\swarm_slave\w\ir\third_party\catapult\telemetry\telemetry\internal\platform\win_platform_backend.py:404
      self._StartMsrServerIfNeeded()
    _StartMsrServerIfNeeded at e:\b\swarm_slave\w\ir\third_party\catapult\telemetry\telemetry\internal\platform\win_platform_backend.py:377
      _InstallWinRing0()
    _InstallWinRing0 at e:\b\swarm_slave\w\ir\third_party\catapult\telemetry\telemetry\internal\platform\win_platform_backend.py:89
      zip_file.extract(dll_file_name, executable_dir)
    extract at c:\infra-system\bin\lib\zipfile.py:1031
      return self._extract_member(member, path, pwd)
    _extract_member at c:\infra-system\bin\lib\zipfile.py:1086
      file(targetpath, "wb") as target:
  IOError: [Errno 13] Permission denied: 'c:\\infra-system\\bin\\WinRing0x64.dll'


Adding one of the test owners, and some speed ops people to see if we updated something infra-wise that may cause this to happen.
Cc: charliea@chromium.org
 Issue 763340  has been merged into this issue.
Let's just remove the legacy power code instead of spending effort fixing this.
I dont know the release criteria for windows, but I know for android we can't remove the legacy code yet though.
Its usage in desktop benchmarks should be removable.
Cc: -charliea@chromium.org rnep...@chromium.org
Owner: charliea@chromium.org
Blockedon: 705042
Just to give an update on what's happening here: the first step in removing this code for desktop platforms is in resolving  issue 705042 , which is slated to be done on Wednesday.
Summary: Non-BattOr desktop power monitoring code is failing, should be removed (was: telemetry_perf_unittests (BenchmarkSmokeTest.dromaeo.domcoretraverse) flaky on 2 builders)
Hopeful fix is in the CQ: https://codereview.chromium.org/3016533002
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82d8bf6944563c44ca7c3aa8adf8345d2c2f9685

commit 82d8bf6944563c44ca7c3aa8adf8345d2c2f9685
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Tue Sep 19 22:59:38 2017

Roll src/third_party/catapult/ ab30bb20a..5626d32b6 (5 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ab30bb20a857..5626d32b69f2

$ git log ab30bb20a..5626d32b6 --date=short --no-merges --format='%ad %ae %s'
2017-09-19 charliea Remove Linux MSR power monitoring code
2017-09-19 simonhatch Dashboard - Populate bug_id with uri parameter if available.
2017-09-19 dtu [pinpoint] Increase default repeat count from 12 to 15.
2017-09-19 estevenson [Dashboard] Fix M62 reference rev.
2017-09-19 dtu [pinpoint] Use _JobState.Differences() in _JobState.Explore().

Created with:
  roll-dep src/third_party/catapult
BUG= 763263 ,765703


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I64ace3f03be21adb34f0b8216a58c7763ead8a95
Reviewed-on: https://chromium-review.googlesource.com/673743
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#502977}
[modify] https://crrev.com/82d8bf6944563c44ca7c3aa8adf8345d2c2f9685/DEPS

Comment 14 by kolos@chromium.org, Sep 20 2017

Cc: -kolos@chromium.org
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf85e75ca59de5ec8f8108edc741857c15e38abf

commit bf85e75ca59de5ec8f8108edc741857c15e38abf
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Wed Sep 20 15:35:42 2017

Roll src/third_party/catapult/ 6926f20b3..ae4ec0ee0 (2 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/6926f20b399d..ae4ec0ee0ffa

$ git log 6926f20b3..ae4ec0ee0 --date=short --no-merges --format='%ad %ae %s'
2017-09-20 charliea Remove Mac powermetrics power monitoring code
2017-09-20 perezju [Telemetry] Explicitly disable ModalPermissionPrompts on Android

Created with:
  roll-dep src/third_party/catapult
BUG= 763263 ,760901


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Idd97c1a27226a30a96b68790f77658a1e604d922
Reviewed-on: https://chromium-review.googlesource.com/674095
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503154}
[modify] https://crrev.com/bf85e75ca59de5ec8f8108edc741857c15e38abf/DEPS

Project Member

Comment 16 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85a22f0208bbb10870c9d37a55ebd99cc7e9bc63

commit 85a22f0208bbb10870c9d37a55ebd99cc7e9bc63
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Thu Sep 21 00:23:50 2017

Roll src/third_party/catapult/ 45b6c18a0..6be590cea (1 commit)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/45b6c18a069e..6be590cea276

$ git log 45b6c18a0..6be590cea --date=short --no-merges --format='%ad %ae %s'
2017-09-20 charliea Remove Windows MSR power monitoring code

Created with:
  roll-dep src/third_party/catapult
BUG= 763263 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I8069ac6a2b59620f47485013c8f9452672029cd2
Reviewed-on: https://chromium-review.googlesource.com/675910
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503292}
[modify] https://crrev.com/85a22f0208bbb10870c9d37a55ebd99cc7e9bc63/DEPS

Project Member

Comment 17 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05cb878b0c32c9c47dc3518cffa1713ab252473f

commit 05cb878b0c32c9c47dc3518cffa1713ab252473f
Author: Charlie Andrews <charliea@chromium.org>
Date: Thu Sep 21 20:12:49 2017

Remove power.py code that was used solely by powermetrics

Bug:  763263 
Change-Id: I676208668f59efaab83ee8a26bad8ba30ff0e5f9
Reviewed-on: https://chromium-review.googlesource.com/677089
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503544}
[modify] https://crrev.com/05cb878b0c32c9c47dc3518cffa1713ab252473f/tools/perf/metrics/power.py

Project Member

Comment 18 by bugdroid1@chromium.org, Sep 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7bbcdcd3a3ba1614ec72713911badbb3a79f90f

commit c7bbcdcd3a3ba1614ec72713911badbb3a79f90f
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Sat Sep 23 00:42:33 2017

Roll src/third_party/catapult/ ba9bf6aa3..fdacc64db (2 commits)

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/ba9bf6aa3e74..fdacc64db061

$ git log ba9bf6aa3..fdacc64db --date=short --no-merges --format='%ad %ae %s'
2017-09-22 charliea Delete CrOS power monitoring code
2017-09-22 charliea Removes the after_load:power_avg metric

Created with:
  roll-dep src/third_party/catapult
BUG= 763263 


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Id01dba79f9002bbe3af1bc484c57aa14dcb4e327
Reviewed-on: https://chromium-review.googlesource.com/679605
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503918}
[modify] https://crrev.com/c7bbcdcd3a3ba1614ec72713911badbb3a79f90f/DEPS

Project Member

Comment 19 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f19a17198d90a9622a12988b689ada5c422161d

commit 6f19a17198d90a9622a12988b689ada5c422161d
Author: Charlie Andrews <charliea@chromium.org>
Date: Tue Oct 17 15:51:56 2017

Remove metric-side code for legacy power measurement methods

The Catapult-side code that integrates with the monsoon power monitor
has already been removed.

Bug:  763263 
Change-Id: I6980459006ca56af591285d1c9bbe303bd71a921
Reviewed-on: https://chromium-review.googlesource.com/721866
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509396}
[modify] https://crrev.com/6f19a17198d90a9622a12988b689ada5c422161d/tools/perf/metrics/power.py

Status: fixed (was: Assigned)
Project Member

Comment 21 by bugdroid1@chromium.org, Oct 30 2017

Sign in to add a comment