chromeos-firmwareupdate -h does not output updater options on workstation (with unibuild enabled) |
|||||||
Issue description
Running FW updater on workstation (whether in chroot or not) with "-h" option to get help does not properly output all information. The updater options are all missing. It works correctly when executing on an actual CrOS device.
(cr) pberny@pberny0 ~/trunk/src/build/images/coral/tmp $ /build/coral/usr/sbin/chromeos-firmwareupdate -h │··························································
│··························································
USAGE: /build/coral/usr/sbin/chromeos-firmwareupdate [bundle_option|--] [updater_options] │··························································
│··························································
bundle_option (only one option can be selected): │··························································
-h,--help: Show usage help │··························································
-V: show version and content of bundle │··························································
--force: force execution and ignore /root/.leave_firmware_alone │··························································
--sb_extract [PATH]: extract bundle content to a temporary folder │··························································
--sb_repack PATH: update bundle content from given folder │··························································
│··························································
updater_options: │··························································
│··························································
Cannot open lockfile //run/lock/firmware_utility_lock: Permission denied │··························································ERROR: Cannot get model.
,
Sep 14 2017
,
Sep 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/bee2662d6424e6312d4ffdee2c67f371a79a92e8 commit bee2662d6424e6312d4ffdee2c67f371a79a92e8 Author: Patrick Berny <pberny@chromium.org> Date: Sat Sep 16 06:39:26 2017 Fix output of FW updater help when run on workstation Fix the output of "chromeos-firmwareupdate -h" from unibuild enabled build target to properly display the updater options when run on workstation (instead of CrOS device) . BUG= chromium:763257 TEST=emerge-coral chromeos-firmware-coral Run "/build/coral/usr/sbin/chromeos-firmwareupdate -h" and --sb_extract in chroot and on regular system Change-Id: If987c0f857b65cb42d50ae15b82a843ed07dbfd0 Reviewed-on: https://chromium-review.googlesource.com/657057 Commit-Ready: Patrick Berny <pberny@chromium.org> Tested-by: Patrick Berny <pberny@chromium.org> Reviewed-by: Nick Sanders <nsanders@chromium.org> Reviewed-by: C Shapiro <shapiroc@google.com> [modify] https://crrev.com/bee2662d6424e6312d4ffdee2c67f371a79a92e8/pack_dist/updater4.sh
,
Sep 21 2017
Simon, assigning the bug to you as requested in CL:657057.
,
Sep 27 2017
,
Sep 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/firmware/+/a30afa1b4d176fa93c1bed82bc6a4bc1e9b930c4 commit a30afa1b4d176fa93c1bed82bc6a4bc1e9b930c4 Author: Simon Glass <sjg@chromium.org> Date: Wed Sep 27 19:57:55 2017 pack_firmware: Add a test for -h Add a simple test which checks that the firmware update prints help both from the stub and from the updater script itself. BUG= chromium:763257 TEST=emerge-reef-uni -q chromeos-firmware-reef Signed-off-by: Simon Glass <sjg@chromium.org> Change-Id: I0d614831225d32c60a9583eb456035c9aacd95f3 Reviewed-on: https://chromium-review.googlesource.com/686998 Commit-Ready: Simon Glass <sjg@chromium.org> Tested-by: Simon Glass <sjg@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/a30afa1b4d176fa93c1bed82bc6a4bc1e9b930c4/pack_firmware_functest.py
,
Sep 29 2017
,
Jan 22 2018
,
Jan 23 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by sjg@chromium.org
, Sep 8 2017