BrowserDialogTests for GlobalErrorBubbles |
||||||||||||||||||||
Issue descriptionChrome Version : 62.0.3198.0 We need a way to show the following: - GlobalError - ExternalInstallMenuAlert - ErrorBadge - GlobalErrorWithStandardBubble - ExtensionDisabledGlobalError - ExtensionGlobalError - ExternalInstallBubbleAlert - RecoveryInstallGlobalError - SRTGlobalError - SigninGlobalError
,
Sep 8 2017
Wow adding tests for these is a nightmare. -> https://chromium-review.googlesource.com/656742 Attached - ExtensionGlobalError (malware? is it just malware that shows this?) - ExtensionDisabledGlobalError (upgraded permissions, and added-remotely)
,
Sep 13 2017
Here's a full suite when running with --secondary-ui-md Note that... the icon is usually removed with --secondary-ui-md. But the rationale for that is that the dialog shouldn't be duplicated. Except these "global error" dialogs don't seem to guarantee that there is always an extension icon. And some have nothing to do with extensions anyway :/ still missing SRTGlobalError - need to bounce to Windows for that.
,
Sep 20 2017
Is this bug only about adding tests (so we can show these automatically), not about actually Harmonizing them, which would be covered separately?
,
Sep 21 2017
Correct - https://chromium-review.googlesource.com/c/chromium/src/+/656742 is in now review for this. These slip under the radar a little, since they don't implement DialogDelegate, but rely on GlobalErrorWithStandardBubble. Also they're obscure and hard to summon. Issue 675496 was originally a MacViews thing, but it could makes sense to use that for Harmonization. (or a new bug. or this :) - I'm not fussed). It's unlikely these will get separate mocks. UX team feedback in the meeting was: - "Details" button should be left aligned in the extra view slot - Body text should align under the title text, not under the icon For the icon, Harmony doesn't _repeat_ icons in the bubble title area when it matches the anchor. Most cases when these are shown "For Real", the bubble should be anchored to the extension icon, or to the app menu showing the orange [!]. But for "extension is disabled" case, the app menu shows "[!]" but the bubble shows the extension icon, so we may want to show the icon for that specific case.
,
Sep 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/300d540fe1c48277139e0461c291650cbe3b7a71 commit 300d540fe1c48277139e0461c291650cbe3b7a71 Author: Trent Apted <tapted@chromium.org> Date: Mon Sep 25 06:48:38 2017 Dialog tests for GlobalErrorBubbles These are typically hard to summon. This adds tests to show - ExtensionGlobalError (blacklisted extension) - ExtensionDisabledGlobalError - ExternalInstallBubbleAlert - RecoveryInstallGlobalError (Windows and Mac) - SigninGlobalError (non-ChromeOS) - Software Removal Tool's SRTGlobalError (Windows) Bug: 763233 Change-Id: I78646b6694d2e5e1ff85471475eb203f3db167fa Reviewed-on: https://chromium-review.googlesource.com/656742 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#503992} [add] https://crrev.com/300d540fe1c48277139e0461c291650cbe3b7a71/chrome/browser/ui/global_error/global_error_browsertest.cc [modify] https://crrev.com/300d540fe1c48277139e0461c291650cbe3b7a71/chrome/test/BUILD.gn [modify] https://crrev.com/300d540fe1c48277139e0461c291650cbe3b7a71/extensions/browser/extension_prefs.cc [modify] https://crrev.com/300d540fe1c48277139e0461c291650cbe3b7a71/extensions/browser/extension_prefs.h
,
Sep 25 2017
Next step: 675496 |
||||||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||||||
Comment 1 by tapted@chromium.org
, Sep 8 2017