Issue metadata
Sign in to add a comment
|
S13nServiceWorker: Set performance timing info |
||||||||||||||||||||||
Issue description
Currently there is a TODO in service_worker_loader_job_unittest.cc:
// TODO(falken): start and ready time should be set.
Currently ResourceResponseHead::service_worker_start_time and service_worker_ready_time are always null.
But we should set these times in ServiceWorkerURLLoaderJob. Then the tests should be able to test that the times are not null.
You can look at ServiceWorkerURLRequestJob for reference about how to do this.
,
Sep 11 2017
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75074c50f653493c4d5e29c622dc3b06ed063398 commit 75074c50f653493c4d5e29c622dc3b06ed063398 Author: Emi Morikawa <emim@google.com> Date: Tue Sep 12 02:22:02 2017 service worker: Set performance timing info in ServiceWorkerURLLoaderJob. Set ResourceResponseHead::service_worker_start_time and service_worker_ready_time in ServiceWorkerURLLoaderJob. Bug: 763232 Change-Id: I52b8f3495bbae076ef10608b11065e77fa7c3c43 Reviewed-on: https://chromium-review.googlesource.com/659480 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Emi Morikawa <emim@google.com> Cr-Commit-Position: refs/heads/master@{#501156} [modify] https://crrev.com/75074c50f653493c4d5e29c622dc3b06ed063398/content/browser/service_worker/service_worker_url_loader_job.cc [modify] https://crrev.com/75074c50f653493c4d5e29c622dc3b06ed063398/content/browser/service_worker/service_worker_url_loader_job_unittest.cc
,
Sep 12 2017
,
Sep 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5274d45ada19abceb7dd90609be32757a4538739 commit 5274d45ada19abceb7dd90609be32757a4538739 Author: Emi Morikawa <emim@google.com> Date: Fri Sep 22 06:29:42 2017 service worker: Delete unused lines in service_worker_url_loader_job_unittest.cc. Delete lines that are no longer used. This is a follow-up for https://chromium-review.googlesource.com/c/chromium/src/+/659480. Bug: 763232 Change-Id: I626d6241d568a1e1effd77a8c69fcd3d6cdde5ab Reviewed-on: https://chromium-review.googlesource.com/678275 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Reviewed-by: Kinuko Yasuda (slow) <kinuko@chromium.org> Commit-Queue: Emi Morikawa <emim@google.com> Cr-Commit-Position: refs/heads/master@{#503672} [modify] https://crrev.com/5274d45ada19abceb7dd90609be32757a4538739/content/browser/service_worker/service_worker_url_loader_job_unittest.cc
,
Nov 7 2017
,
Nov 7 2017
Apologies, applied the wrong component in bulk. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by falken@chromium.org
, Sep 8 2017