New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 763230 link

Starred by 1 user
Status: Fixed
Owner:
mattm@chromium.org
Closed: Sep 2017
Cc:
█ mgiuca@chromium.org
kolos@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

net_unittests failing on chromium.linux/Linux Tests (dbg)(1)(32)

Project Member Reported by mgiuca@chromium.org, Sep 8 2017 
net_unittests failing on chromium.linux/Linux Tests (dbg)(1)(32)

Builders failed on: 
- Linux Tests (dbg)(1)(32): 
  https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29

First failing build:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/44054 [r500460..r500476].

3 tests failing:
net_unittests: X509UtilTest.CreateChannelBindings_SHA1
net_unittests: SSLClientSocketTest.ConnectBadValidity
unit_tests: DownloadProtectionServiceTest.GetCertificateWhitelistStrings

Suspect CL: r500472 (https://chromium-review.googlesource.com/c/chromium/src/+/578568) (mattm@)
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae23e2d50d88a10b79c52c54646c6c4bd22d525e

commit ae23e2d50d88a10b79c52c54646c6c4bd22d525e
Author: Matt Giuca <mgiuca@chromium.org>
Date: Fri Sep 08 04:22:32 2017

Revert "Convert Linux and ChromeOS to use X509CertificateBytes."

This reverts commit 48218d16dc459752e54ba7f6cb6813199285ba03.

Reason for revert: Suspect broke 3 tests on Linux. See bug.

Original change's description:
> Convert Linux and ChromeOS to use X509CertificateBytes.
> 
> Bug:  671420 
> Change-Id: I41ffc51eb0d639b702917e0b823f33cd80c8d9dc
> Reviewed-on: https://chromium-review.googlesource.com/578568
> Reviewed-by: David Benjamin <davidben@chromium.org>
> Commit-Queue: Matt Mueller <mattm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#500472}

TBR=davidben@chromium.org,mattm@chromium.org

Change-Id: I869efd17584d4e0f24d06fb198a15e6f1ea6cdc4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  763230 
Reviewed-on: https://chromium-review.googlesource.com/656479
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500505}
[modify] https://crrev.com/ae23e2d50d88a10b79c52c54646c6c4bd22d525e/net/BUILD.gn

Comment 2 by mgiuca@chromium.org, Sep 8 2017 

Somewhat concerned by r500508 which appears to remove the code that is no longer needed after r500472, but would still be needed after my revert in r500505.

The revert has made a successful build:
https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/44059

But there hasn't yet been a build for r500508. That may need to be reverted also.

Comment 3 by mgiuca@chromium.org, Sep 8 2017

Cc: -mattm@chromium.org kolos@chromium.org mgiuca@chromium.org
Labels: -Sheriff-Chromium M
Owner: mattm@chromium.org
Status: Fixed (was: Started)

Comment 4 by mgiuca@chromium.org, Sep 8 2017

Labels: -M
►

Sign in to add a comment