Harmony - update "Critical Update" dialog (Windows only) [needs mocks] |
||||||||
Issue descriptionChrome Version : 62.0.3198.0 This dialog is only shown on Windows. It starts a countdown timer and force-restarts the browser. Attaching what it looks like. The dialog class is CriticalUpdateBubbleView It's plumbed through similar to the "Can't update chrome" dialog - Issue 651648
,
Dec 20 2017
Chromium will restart in 17 seconds A special security update for Chromium was just applied. Restart now and we'll restore your tabs. [Restart now] [Cancel] ----- + remove punctuation in title + new body copy + new primary button string + apply all anchored dialog properties: no arrow, active state
,
Dec 20 2017
Thanks Alan!
,
Jan 10 2018
,
Feb 26 2018
One more item to go on this one. Change "Don't restart" button to just "Cancel".
,
Feb 28 2018
Ready for UX review
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/113cfb65e42332c11623a12ef3899cb5b22e501c commit 113cfb65e42332c11623a12ef3899cb5b22e501c Author: Allen Bauer <kylixrd@chromium.org> Date: Wed Nov 21 19:36:16 2018 Harmony - Changed button and body text on CriticalNotificationBubbleView Removed IDS_CRITICAL_NOTIFICATION_RESTART; use IDS_CANCEL instead. Reworded IDS_CRITICAL_NOTIFICATION_TEXT content per referenced bug. TBR=cpu@chromium.org Bug: 763227 Change-Id: Ie8bf0157da2a62f0e1d32807b9b5ea022d02bd49 Reviewed-on: https://chromium-review.googlesource.com/c/938186 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#610166} [modify] https://crrev.com/113cfb65e42332c11623a12ef3899cb5b22e501c/chrome/app/chromium_strings.grd [modify] https://crrev.com/113cfb65e42332c11623a12ef3899cb5b22e501c/chrome/app/generated_resources.grd [modify] https://crrev.com/113cfb65e42332c11623a12ef3899cb5b22e501c/chrome/app/google_chrome_strings.grd [modify] https://crrev.com/113cfb65e42332c11623a12ef3899cb5b22e501c/chrome/browser/ui/views/critical_notification_bubble_view.cc
,
Nov 21
The CL for this had been ignored to a while... it was just approved and the fix has actually landed. Sorry for the delay.
,
Nov 30
So sorry to reopen this, but I just became aware of this change through a localization bug that was filed on this string. We avoid language like "You should" in user-facing UI because it sounds unfriendly. Given the context, I'd recommend using "Please restart Google Chrome now" instead.
<message name="IDS_CRITICAL_NOTIFICATION_TITLE_ALTERNATE" desc="The title for a bubble that appears when there is a critical update and Chrome must restart to install it. The title was previously countng down to an automatic restart and now it has finished. Will only be seen if a web page stops the shutdown process.">
You should restart Google Chrome now
</message>
,
Nov 30
One other thing: we can drop "Google" because presumably this dialog exists in the context of Chrome, not outside of it: "Please restart Chrome now" |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bsep@chromium.org
, Dec 14 2017Owner: bettes@chromium.org
Status: Assigned (was: Untriaged)