Issue metadata
Sign in to add a comment
|
Unable to open rar file.
Reported by
mikachen...@gmail.com,
Sep 8 2017
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; CrOS x86_64 9920.0.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3207.0 Safari/537.36 Platform: 9920.0.0 (Official Build) dev-channel reef test Steps to reproduce the problem: 1. Upload the rar file to the Files folder. 2. Open the rar file What is the expected behavior? The rar file can be opened. What went wrong? The rar file can't be opened. Pop up the error message as "Unable to open "TestFile.rar:error_internal". Did this work before? N/A Chrome version: 63.0.3207.0 Channel: dev OS Version: 9920.0.0 Flash Version: 27.0.0.130 According to the following link, chromebook can use the rar file type. https://support.google.com/chromebook/answer/183093?hl=en
,
Sep 26 2017
,
Oct 9 2017
,
Oct 23 2017
Issue 777244 has been merged into this issue.
,
Oct 23 2017
Issue 766317 has been merged into this issue.
,
Oct 23 2017
,
Oct 23 2017
,
Oct 23 2017
cros-disks seems to need following capabilities to create directories for avfs. CAP_DAC_OVERRIDE: to create /run/avfsroot and its sub directories under /run. CAP_FOWNER: to change permission of those directories. Owner of /run/avfsroot and its sub directories is avfs, not cros-disks. Also /run is owned by root. I'll prepare a CL to add those capabilities to cros-disks.
,
Oct 23 2017
yawano@, I think you forgot to mention that this got very likely broken by https://crrev.com/c/563738 and that's why you cc'ed jorgelo@.
,
Oct 23 2017
Yes, I forgot to mention it. Thank you. I suspect that this becomes broken after the CL. I've uploaded a fix at https://crrev.com/c/732810.
,
Oct 23 2017
Do we not have automatic testing for .rar files? It's probably a good idea to add that to the platform_CrosDisks Autotest tests. I don't know if we need those caps, how about we make cros-disks a member of group avfs? Does that work?
,
Oct 24 2017
No, we don't have the test for now. That should prevent this kind of issue happening again. For the later part, benchan@ is working on the fix. Assign this issue to benchan@ now for https://crrev.com/c/734299 and other related CLs. Thank you!
,
Oct 24 2017
The suspected CL https://crrev.com/c/563738 has landed on Aug 15, and the CL should be included from M62. I suspect that this issue becomes to happen from M62.
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/ddc66b1fb0f5c16a4f5af91cbe1a4deecf456f3c commit ddc66b1fb0f5c16a4f5af91cbe1a4deecf456f3c Author: Ben Chan <benchan@chromium.org> Date: Tue Oct 24 19:57:44 2017 Add 'cros-disks' user to 'avfs' group in usergroup_baseline.py CL:734313 adds the 'cros-disks' user to the 'avfs' group. BUG= chromium:763225 CQ-DEPEND=CL:734313 TEST=Run remote trybot runs. Change-Id: Ifebfbea473bb498ed698ec617f29e1bc42336b60 Reviewed-on: https://chromium-review.googlesource.com/733957 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/ddc66b1fb0f5c16a4f5af91cbe1a4deecf456f3c/cros/test/usergroup_baseline.py
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/eclass-overlay/+/dc3b51764fb155f79a82a497e990e4848c7d9c21 commit dc3b51764fb155f79a82a497e990e4848c7d9c21 Author: Ben Chan <benchan@chromium.org> Date: Tue Oct 24 19:57:44 2017 Add 'cros-disks' user to 'avfs' group. cros-disks now runs as the 'cros-disks' user and needs to be in the 'avfs' for accessing sub-directories under /run/avfsroot, which belongs to the 'avfs' group, for mounting archive files via AVFS. BUG= chromium:763225 CQ-DEPEND=CL:734297 CQ-DEPEND=CL:733957 TEST=Verify that Files.app can mount a RAR archive via cros-disks. TEST=Run updated security_AccountsBaseline (CL:734297). Change-Id: If6d19b6462548952c01aa2d884e85b367f8da976 Reviewed-on: https://chromium-review.googlesource.com/734313 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/dc3b51764fb155f79a82a497e990e4848c7d9c21/profiles/base/accounts/group/avfs
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/1b894223bdf97f542e19f6ceba8736ab0995742c commit 1b894223bdf97f542e19f6ceba8736ab0995742c Author: Ben Chan <benchan@chromium.org> Date: Tue Oct 24 19:57:44 2017 security_AccountsBaseline: add 'cros-disks' user to 'avfs' group CL:734313 adds the 'cros-disks' user to the 'avfs' group. This CL updates security_AccountsBaseline accordingly. BUG= chromium:763225 CQ-DEPEND=CL:734313 TEST=Run security_AccountsBaseline with CL:734313. Change-Id: I21285e5acbf2a9b2f782ffe9090424d2240c6b83 Reviewed-on: https://chromium-review.googlesource.com/734297 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/1b894223bdf97f542e19f6ceba8736ab0995742c/client/site_tests/security_AccountsBaseline/baseline.group
,
Oct 25 2017
i thought we had autotest coverage here ? if not, i guess we should add it ?
,
Oct 25 2017
I'll resurrect the deleted platform_CrosDisksArchive tests.
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/77232b332a6ba89c491cfdfd58473913720e0933 commit 77232b332a6ba89c491cfdfd58473913720e0933 Author: Ben Chan <benchan@chromium.org> Date: Wed Oct 25 05:47:58 2017 cros-disks: fix creation of /run/avfsroot directory tree cros-disks now runs as a non-privileged process (CL:563738) and no longer has the permission to create the directory tree under /run/avfsroot. This CL moves the creation of the /run/avfsroot directory tree out from the cros-disks process to the pre-start script of the cros-disks upstart job instead. BUG= chromium:763225 CQ-DEPEND=CL:734313 TEST=With CL:734313, verify that Files.app can mount a RAR archive via cros-disks. Change-Id: I4b129b0adbec43c9c44250747953ce33493941e9 Reviewed-on: https://chromium-review.googlesource.com/734299 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/77232b332a6ba89c491cfdfd58473913720e0933/cros-disks/archive_manager.cc [modify] https://crrev.com/77232b332a6ba89c491cfdfd58473913720e0933/cros-disks/cros-disks.conf
,
Oct 25 2017
,
Oct 25 2017
,
Oct 25 2017
Adding Merge-Request-62 since it's broken in M62 as well
,
Oct 25 2017
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 25 2017
,
Oct 25 2017
If this is verified on ToT, feel free to merge to 62.
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/0210ec957eb354de503cf957619163fefe5cc7b9 commit 0210ec957eb354de503cf957619163fefe5cc7b9 Author: Ben Chan <benchan@chromium.org> Date: Wed Oct 25 22:42:54 2017 cros-disks: fix creation of /run/avfsroot directory tree cros-disks now runs as a non-privileged process (CL:563738) and no longer has the permission to create the directory tree under /run/avfsroot. This CL moves the creation of the /run/avfsroot directory tree out from the cros-disks process to the pre-start script of the cros-disks upstart job instead. BUG= chromium:763225 CQ-DEPEND=CL:734313 TEST=With CL:734313, verify that Files.app can mount a RAR archive via cros-disks. Change-Id: I4b129b0adbec43c9c44250747953ce33493941e9 Reviewed-on: https://chromium-review.googlesource.com/734299 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit 77232b332a6ba89c491cfdfd58473913720e0933) Reviewed-on: https://chromium-review.googlesource.com/737516 Reviewed-by: Ben Chan <benchan@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/0210ec957eb354de503cf957619163fefe5cc7b9/cros-disks/archive_manager.cc [modify] https://crrev.com/0210ec957eb354de503cf957619163fefe5cc7b9/cros-disks/cros-disks.conf
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/eclass-overlay/+/2f151133da8a2ffe71027716a4cc056b4741c6de commit 2f151133da8a2ffe71027716a4cc056b4741c6de Author: Ben Chan <benchan@chromium.org> Date: Wed Oct 25 22:42:54 2017 Add 'cros-disks' user to 'avfs' group. cros-disks now runs as the 'cros-disks' user and needs to be in the 'avfs' for accessing sub-directories under /run/avfsroot, which belongs to the 'avfs' group, for mounting archive files via AVFS. BUG= chromium:763225 CQ-DEPEND=CL:734297 CQ-DEPEND=CL:733957 TEST=Verify that Files.app can mount a RAR archive via cros-disks. TEST=Run updated security_AccountsBaseline (CL:734297). Change-Id: If6d19b6462548952c01aa2d884e85b367f8da976 Reviewed-on: https://chromium-review.googlesource.com/734313 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit dc3b51764fb155f79a82a497e990e4848c7d9c21) Reviewed-on: https://chromium-review.googlesource.com/737517 Reviewed-by: Ben Chan <benchan@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/2f151133da8a2ffe71027716a4cc056b4741c6de/profiles/base/accounts/group/avfs
,
Oct 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/043a03c2d8857a3db01467815a59011cd882e66d commit 043a03c2d8857a3db01467815a59011cd882e66d Author: Ben Chan <benchan@chromium.org> Date: Wed Oct 25 22:42:54 2017 security_AccountsBaseline: add 'cros-disks' user to 'avfs' group CL:734313 adds the 'cros-disks' user to the 'avfs' group. This CL updates security_AccountsBaseline accordingly. BUG= chromium:763225 CQ-DEPEND=CL:734313 TEST=Run security_AccountsBaseline with CL:734313. Change-Id: I21285e5acbf2a9b2f782ffe9090424d2240c6b83 Reviewed-on: https://chromium-review.googlesource.com/734297 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit 1b894223bdf97f542e19f6ceba8736ab0995742c) Reviewed-on: https://chromium-review.googlesource.com/738450 Reviewed-by: Ben Chan <benchan@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/043a03c2d8857a3db01467815a59011cd882e66d/client/site_tests/security_AccountsBaseline/baseline.group
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/316b7cdd114e1948b5b0485500cf5a655ff225cb commit 316b7cdd114e1948b5b0485500cf5a655ff225cb Author: Ben Chan <benchan@chromium.org> Date: Thu Oct 26 02:13:44 2017 cros-disks: fix creation of /run/avfsroot directory tree cros-disks now runs as a non-privileged process (CL:563738) and no longer has the permission to create the directory tree under /run/avfsroot. This CL moves the creation of the /run/avfsroot directory tree out from the cros-disks process to the pre-start script of the cros-disks upstart job instead. BUG= chromium:763225 CQ-DEPEND=CL:734313 TEST=With CL:734313, verify that Files.app can mount a RAR archive via cros-disks. Change-Id: I4b129b0adbec43c9c44250747953ce33493941e9 Reviewed-on: https://chromium-review.googlesource.com/734299 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit 77232b332a6ba89c491cfdfd58473913720e0933) Reviewed-on: https://chromium-review.googlesource.com/737967 Reviewed-by: Ben Chan <benchan@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/316b7cdd114e1948b5b0485500cf5a655ff225cb/cros-disks/archive_manager.cc [modify] https://crrev.com/316b7cdd114e1948b5b0485500cf5a655ff225cb/cros-disks/cros-disks.conf
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/eclass-overlay/+/617ae0f2a8183e14a06eb76b05569377faee7b7a commit 617ae0f2a8183e14a06eb76b05569377faee7b7a Author: Ben Chan <benchan@chromium.org> Date: Thu Oct 26 02:13:44 2017 Add 'cros-disks' user to 'avfs' group. cros-disks now runs as the 'cros-disks' user and needs to be in the 'avfs' for accessing sub-directories under /run/avfsroot, which belongs to the 'avfs' group, for mounting archive files via AVFS. BUG= chromium:763225 CQ-DEPEND=CL:734297 CQ-DEPEND=CL:733957 TEST=Verify that Files.app can mount a RAR archive via cros-disks. TEST=Run updated security_AccountsBaseline (CL:734297). Change-Id: If6d19b6462548952c01aa2d884e85b367f8da976 Reviewed-on: https://chromium-review.googlesource.com/734313 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit dc3b51764fb155f79a82a497e990e4848c7d9c21) Reviewed-on: https://chromium-review.googlesource.com/738852 Reviewed-by: Ben Chan <benchan@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/617ae0f2a8183e14a06eb76b05569377faee7b7a/profiles/base/accounts/group/avfs
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/069a27905bf9a0c564dbeefef782a752e696d773 commit 069a27905bf9a0c564dbeefef782a752e696d773 Author: Ben Chan <benchan@chromium.org> Date: Thu Oct 26 02:13:44 2017 security_AccountsBaseline: add 'cros-disks' user to 'avfs' group CL:734313 adds the 'cros-disks' user to the 'avfs' group. This CL updates security_AccountsBaseline accordingly. BUG= chromium:763225 CQ-DEPEND=CL:734313 TEST=Run security_AccountsBaseline with CL:734313. Change-Id: I21285e5acbf2a9b2f782ffe9090424d2240c6b83 Reviewed-on: https://chromium-review.googlesource.com/734297 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> (cherry picked from commit 1b894223bdf97f542e19f6ceba8736ab0995742c) Reviewed-on: https://chromium-review.googlesource.com/738853 Reviewed-by: Ben Chan <benchan@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/069a27905bf9a0c564dbeefef782a752e696d773/client/site_tests/security_AccountsBaseline/baseline.group
,
Oct 26 2017
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/fb1049af45d812e87ae0918c9febe46fef9c024c commit fb1049af45d812e87ae0918c9febe46fef9c024c Author: Ben Chan <benchan@chromium.org> Date: Thu Oct 26 16:42:58 2017 Revert "Remove platform_CrosDisksArchive test." This reverts commit 38b7871f8af661df4c1dd6c78f274dd4d1eb58d6. CL:465507 removed platform_CrosDisksArchive as support for ZIP and TAR archive was removed from cros-disks. However, we need to resurrect platform_CrosDisksArchive for the following reasons: CL:732797 temporarily re-enables ZIP archive support in cros-disks, so we would like to temporarily resurrect platform_CrosDisksArchive to verify ZIP archive support in cros-disks. Also, to prevent future regressions on RAR archive support, we will extend platform_CrosDisksArchive to verify RAR archive support in cros-disks. BUG= chromium:763225 BUG= chromium:777254 TEST=Run platform_CrosDisksArchive. Change-Id: I1cdcc7223da38a5bd0af6e1c6ddaa3429b373ecd Reviewed-on: https://chromium-review.googlesource.com/737941 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [add] https://crrev.com/fb1049af45d812e87ae0918c9febe46fef9c024c/client/site_tests/platform_CrosDisksArchive/control [add] https://crrev.com/fb1049af45d812e87ae0918c9febe46fef9c024c/client/site_tests/platform_CrosDisksArchive/platform_CrosDisksArchive.py
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f71adcbbc552cea9df8c5ea09e72162f7469f865 commit f71adcbbc552cea9df8c5ea09e72162f7469f865 Author: Ben Chan <benchan@chromium.org> Date: Thu Oct 26 22:57:45 2017 Revert "autotest-tests: remove platform_CrosDisksArchive test" This reverts commit 84e4d7433beb8c75d0a3abf8ed64f0d7feb17196. CL:465507 removed platform_CrosDisksArchive as support for ZIP and TAR archive was removed from cros-disks. However, we need to resurrect platform_CrosDisksArchive for the following reasons: CL:732797 temporarily re-enables ZIP archive support in cros-disks, so we would like to temporarily resurrect platform_CrosDisksArchive to verify ZIP archive support in cros-disks. Also, to prevent future regressions on RAR archive support, we will extend platform_CrosDisksArchive to verify RAR archive support in cros-disks. BUG= chromium:763225 BUG= chromium:777254 CQ-DEPEND=CL:737941 CQ-DEPEND=CL:737942 TEST=Remote trybot runs. Change-Id: I7a745b884e41aa6fd0dee938eddf8d587cd8cdd2 Reviewed-on: https://chromium-review.googlesource.com/738797 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/f71adcbbc552cea9df8c5ea09e72162f7469f865/chromeos-base/autotest-tests-cros-disks/autotest-tests-cros-disks-9999.ebuild
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/cf0668dd4d93484764f3d1b62cecffcb6ebb63c8 commit cf0668dd4d93484764f3d1b62cecffcb6ebb63c8 Author: Ben Chan <benchan@chromium.org> Date: Fri Oct 27 01:09:30 2017 Extend platform_CrosDisksArchive to verify RAR support in cros-disks. BUG= chromium:763225 TEST=Run platform_CrosDisksArchive. Change-Id: I821c9a1dbfb596f2d1f60b3342ff0cd10437167c Reviewed-on: https://chromium-review.googlesource.com/737943 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/cf0668dd4d93484764f3d1b62cecffcb6ebb63c8/client/site_tests/platform_CrosDisksArchive/control [add] https://crrev.com/cf0668dd4d93484764f3d1b62cecffcb6ebb63c8/client/site_tests/platform_CrosDisksArchive/data/test.rar [modify] https://crrev.com/cf0668dd4d93484764f3d1b62cecffcb6ebb63c8/client/site_tests/platform_CrosDisksArchive/platform_CrosDisksArchive.py
,
Nov 1 2017
The issue is verified pass on Coral-R64-10050.0.0, thank you!
,
Nov 1 2017
Sorry for my typo. Change the version to Coral-R64-10069.0.0.
,
Nov 8 2017
Verified on M64 dev build (10109.0.0, 64.0.3261.0).
,
Jan 19 2018
We can reproduce this issue on Scarlet R65-10308.0.0. (Failure rate: 3/3) We'll keep watching it. Thanks. - Chrome OS version: R65-10308.0.0 - BIOS version: Google_Scarlet.10210.0.0 - EC: Scarlet_v1.1.7496-931c942f5
,
Jan 26 2018
This issue is verified pass on Scarlet R65-10321.0.0. Thanks. - Chrome OS version: R65-10321.0.0 - BIOS version: Google_Scarlet.10210.0.0 - EC: Scarlet_v1.1.7496-931c942f5
,
Feb 7 2018
Can reproduce this issue on Coral R64-10176.58.0. (Failure rate: 3/3) - Chrome OS version: R64-10176.58.0 - BIOS version: Google_Coral.10068.37.0 - EC: coral_v1.1.7267-b7254f389
,
Feb 7 2018
Re #41: That's because 123.rar is a *ZIP* file, not an actual RAR file |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ligim...@chromium.org
, Sep 8 2017