New issue
Advanced search Search tips

Issue 763223 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug


Sign in to add a comment

Enable pointer events for touch input

Project Member Reported by girard@chromium.org, Sep 8 2017

Issue description

For Win8+ we should use pointer events instead of touch events for raw input. 

Touch pointer events were enabled in https://codereview.chromium.org/2904113002 but introduced a number of regressions including  issue 762665  and  issue 762386 

The code was reverted in https://chromium-review.googlesource.com/c/chromium/src/+/655645

Fix the regressions and enable touch pointer events.

 

Comment 1 by girard@chromium.org, Sep 22 2017

Blocking: 767885

Comment 2 by girard@chromium.org, Oct 20 2017

Blocking: 772359
Blocking: 777319
Blocking: 764637
Blocking: 778195
Status: Started (was: Assigned)
Patch is at https://chromium-review.googlesource.com/#/c/chromium/src/+/757617
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65a5563ae004031e6d1b5868bc8cc2bd1b29c915

commit 65a5563ae004031e6d1b5868bc8cc2bd1b29c915
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Sat Feb 10 01:54:48 2018

Fix using WM_POINTER instead of WM_TOUCH

- Add runtime setting to disable/enable WM_POINTER for touch. Defaults
  to disabled in this patch. Will be enabled as a followup change.
- Fix min/max/exit buttons for touch. For unhandled events do a hit test
  and check if they are in the client area. If they are mark them as
  handled as we don't want windows to send us compatibility events if
  we've already dispatched them from the pointer events.
- Set the last_touch_or_pen_message_time for touch events via WM_POINTER.

BUG= 792892 , 763223 

Change-Id: I4350c7e84f96271b9ec27119815bf37a9461d489
Reviewed-on: https://chromium-review.googlesource.com/911752
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535925}
[modify] https://crrev.com/65a5563ae004031e6d1b5868bc8cc2bd1b29c915/content/browser/renderer_host/legacy_render_widget_host_win.cc
[modify] https://crrev.com/65a5563ae004031e6d1b5868bc8cc2bd1b29c915/ui/base/ui_base_features.cc
[modify] https://crrev.com/65a5563ae004031e6d1b5868bc8cc2bd1b29c915/ui/base/ui_base_features.h
[modify] https://crrev.com/65a5563ae004031e6d1b5868bc8cc2bd1b29c915/ui/views/win/hwnd_message_handler.cc
[modify] https://crrev.com/65a5563ae004031e6d1b5868bc8cc2bd1b29c915/ui/views/win/hwnd_message_handler.h

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6d8dfe11405486dac1603adbd00acfb4f687159

commit a6d8dfe11405486dac1603adbd00acfb4f687159
Author: Dave Tapuska <dtapuska@chromium.org>
Date: Mon Feb 12 18:29:16 2018

Enable PointerEventsForTouch by default.

Enable flag to use WM_POINTER instead of WM_TOUCH

BUG= 792892 , 763223 

Change-Id: Icc7c352a114209a737996db618e7156887cc21a7
Reviewed-on: https://chromium-review.googlesource.com/912533
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536136}
[modify] https://crrev.com/a6d8dfe11405486dac1603adbd00acfb4f687159/ui/base/ui_base_features.cc

Status: Fixed (was: Started)
Owner: dtapu...@chromium.org

Sign in to add a comment