New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763220 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

InsertUnorderedList crashes with unusual HTML

Project Member Reported by ClusterFuzz, Sep 8 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5579750264537088

Fuzzer: bj_broddelwerk
Job Type: windows_syzyasan_chrome
Platform Id: windows

Crash Type: Null-dereference
Crash Address: 0x00000003
Crash State:
  blink::TextIteratorAlgorithm<blink::EditingAlgorithm<blink::NodeTraversal> >::Te
  blink::TextIteratorAlgorithm<blink::EditingAlgorithm<blink::NodeTraversal> >::Ra
  blink::CompositeEditCommand::MoveParagraphs
  
Memory Tool: SYZYASAN

Regressed: https://clusterfuzz.com/revisions?job=windows_syzyasan_chrome&range=454233:454289

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5579750264537088

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Cc: msrchandra@chromium.org
Labels: M-61 Test-Predator-Wrong
Owner: xiaoche...@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.
Using Code Search for the file, "textiterator.cpp" assigning to the concern owner from GIT Blame.

Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/c8070f461957f5f2aaaf41147538ebe811b4abce

@xiaochengh -- Could you please look into it issue, kindly re-assign if this not related your changes.
Thank You.
Components: Blink>Editing>Command
Owner: ----
Status: Available (was: Assigned)
Hit DCHECK in CompositeEditCommand::RemoveNodeAndPruneAncestors():

CompositeEditCommand.cpp(421) Check failed: node != exclude_node (TEXTAREA class="CLASS1" (editable) vs. TEXTAREA class="CLASS1" (editable))

DOM tree at DCHECK hit site:

#document (editable)
	HTML (editable)
		HEAD (editable)
			SCRIPT (editable)
			#text "\n"
			STYLE (editable)
			#text "\n"
		BODY (editable)
			DL (editable)
				#text "\n"
				UL (editable)
*					TEXTAREA class="CLASS1" (editable)
						#shadow-root
							DIV id="inner-editor" (editable)
								#text "<dd"
						#text "<dd"
				BR (editable)

Project Member

Comment 3 by ClusterFuzz, Oct 1 2017

Components: Blink>Editing
Labels: Test-Predator-AutoComponents
Automatically applying components based on information from OWNERS files. If this seems incorrect, please apply the Test-Predator-Wrong-Components label.

Comment 4 by yosin@chromium.org, Oct 25 2017

Components: -Blink>Editing
Labels: -Pri-1 Pri-3
Summary: InsertUnorderedList crashes with unusual HTML (was: Null-dereference in blink::TextIteratorAlgorithm<blink::EditingAlgorithm<blink::NodeTraversal> >::Te)
Lower to Pri-3 since real world usage of InsertUnorderedList crashes with unusual HTML is low.
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
Project Member

Comment 6 by ClusterFuzz, Nov 7 2017

Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

https://chromium.googlesource.com/chromium/src/+/7c02de6787d8499ce5e8be12063db19daeace77e (Revert "Import web-platform-tests/editing/." by grt@chromium.org)https://chromium.googlesource.com/chromium/src/+/2211504ac2b999a125b2215ce7f6be9e50878fea (Make PositionIterator to skip contents of INPUT/SELECT/TEXTAREA by yosin@chromium.org)
If this is incorrect, please apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 7 by ClusterFuzz, Nov 8 2017

Automatically adding ccs based on suspected regression changelists:

https://chromium.googlesource.com/chromium/src/+/7c02de6787d8499ce5e8be12063db19daeace77e (Revert "Import web-platform-tests/editing/." by grt@chromium.org)https://chromium.googlesource.com/chromium/src/+/2211504ac2b999a125b2215ce7f6be9e50878fea (Make PositionIterator to skip contents of INPUT/SELECT/TEXTAREA by yosin@chromium.org)
If this is incorrect, please apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 8 by ClusterFuzz, Nov 8 2017

Automatically adding ccs based on suspected regression changelists:

https://chromium.googlesource.com/chromium/src/+/7c02de6787d8499ce5e8be12063db19daeace77e (Revert "Import web-platform-tests/editing/." by grt@chromium.org)https://chromium.googlesource.com/chromium/src/+/2211504ac2b999a125b2215ce7f6be9e50878fea (Make PositionIterator to skip contents of INPUT/SELECT/TEXTAREA by yosin@chromium.org)
If this is incorrect, please apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 9 by ClusterFuzz, Nov 8 2017

Automatically adding ccs based on suspected regression changelists:

https://chromium.googlesource.com/chromium/src/+/7c02de6787d8499ce5e8be12063db19daeace77e (Revert "Import web-platform-tests/editing/." by grt@chromium.org)https://chromium.googlesource.com/chromium/src/+/2211504ac2b999a125b2215ce7f6be9e50878fea (Make PositionIterator to skip contents of INPUT/SELECT/TEXTAREA by yosin@chromium.org)
If this is incorrect, please apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 10 by ClusterFuzz, Nov 8 2017

Automatically adding ccs based on suspected regression changelists:

https://chromium.googlesource.com/chromium/src/+/7c02de6787d8499ce5e8be12063db19daeace77e (Revert "Import web-platform-tests/editing/." by grt@chromium.org)https://chromium.googlesource.com/chromium/src/+/2211504ac2b999a125b2215ce7f6be9e50878fea (Make PositionIterator to skip contents of INPUT/SELECT/TEXTAREA by yosin@chromium.org)
If this is incorrect, please apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 11 by ClusterFuzz, Nov 8 2017

Automatically adding ccs based on suspected regression changelists:

https://chromium.googlesource.com/chromium/src/+/7c02de6787d8499ce5e8be12063db19daeace77e (Revert "Import web-platform-tests/editing/." by grt@chromium.org)https://chromium.googlesource.com/chromium/src/+/2211504ac2b999a125b2215ce7f6be9e50878fea (Make PositionIterator to skip contents of INPUT/SELECT/TEXTAREA by yosin@chromium.org)
If this is incorrect, please apply the Test-Predator-Wrong-CLs label.
Please ignore the Test-Predator-Auto-CC comment spam above, there was a bug in our script that caused it to create same comment multiple times and also didn't add ccs properly. 

Comment 13 Deleted

Project Member

Comment 14 by ClusterFuzz, Dec 6 2017

ClusterFuzz has detected this issue as fixed in range 521421:521451.

Detailed report: https://clusterfuzz.com/testcase?key=5579750264537088

Fuzzer: bj_broddelwerk
Job Type: windows_asan_chrome
Platform Id: windows

Crash Type: Null-dereference
Crash Address: 0x00000003
Crash State:
  blink::TextIteratorAlgorithm<blink::EditingAlgorithm<blink::NodeTraversal> >::Te
  blink::TextIteratorAlgorithm<blink::EditingAlgorithm<blink::NodeTraversal> >::Ra
  blink::CompositeEditCommand::MoveParagraphs
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=454233:454289
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_chrome&range=521421:521451

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5579750264537088

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 15 by ClusterFuzz, Dec 6 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Available)
ClusterFuzz testcase 5579750264537088 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment