New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 763216 link

Starred by 1 user
Status: Fixed
Owner:
█ reve...@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Cc:
█ elizabethchiu@chromium.org
zalcorn@chromium.org
steve...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Add geometry user image set

Project Member Reported by reve...@chromium.org, Sep 8 2017 
This set of user images currently include animated images that are too large to be included. geo5 is the main culprit.

Alternatives

1. include all user images but geo5
2. only include stills for geometry set
3. re-design geometry set so it compress to APNG format better
4. use SVG format when supported as user icons by future version of chrome

Comment 1 by elizabethchiu@chromium.org, Oct 12 2017 

Agree that we should use SVG for future version. For now, can we include a few of the geo icons that compressed well.

Comment 2 by elizabethchiu@chromium.org, Oct 12 2017

Cc: -larua@google.com elizabethchiu@chromium.org
Owner: reve...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e17497f3579fc221310f9452be1129e1f9103f0

commit 3e17497f3579fc221310f9452be1129e1f9103f0
Author: David Reveman <reveman@chromium.org>
Date: Mon Oct 16 21:00:27 2017

ui: Add new geo default user images.

This adds a new set of geometric figure images.

BUG=721647, 763216 

Change-Id: I415a6d201e78852f1e274bf98effa47e92764a69
Reviewed-on: https://chromium-review.googlesource.com/576998
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509164}
[modify] https://crrev.com/3e17497f3579fc221310f9452be1129e1f9103f0/chrome/browser/chromeos/login/users/default_user_image/default_user_images.cc
[add] https://crrev.com/3e17497f3579fc221310f9452be1129e1f9103f0/ui/chromeos/resources/default_100_percent/default_user_images/geo/avatar_geo1.png
[add] https://crrev.com/3e17497f3579fc221310f9452be1129e1f9103f0/ui/chromeos/resources/default_100_percent/default_user_images/geo/avatar_geo2.png
[add] https://crrev.com/3e17497f3579fc221310f9452be1129e1f9103f0/ui/chromeos/resources/default_100_percent/default_user_images/geo/avatar_geo3.png
[add] https://crrev.com/3e17497f3579fc221310f9452be1129e1f9103f0/ui/chromeos/resources/default_100_percent/default_user_images/geo/avatar_geo4.png
[add] https://crrev.com/3e17497f3579fc221310f9452be1129e1f9103f0/ui/chromeos/resources/default_100_percent/default_user_images/geo/avatar_geo5.png
[add] https://crrev.com/3e17497f3579fc221310f9452be1129e1f9103f0/ui/chromeos/resources/default_200_percent/default_user_images/geo/avatar_geo1.png
[add] https://crrev.com/3e17497f3579fc221310f9452be1129e1f9103f0/ui/chromeos/resources/default_200_percent/default_user_images/geo/avatar_geo2.png
[add] https://crrev.com/3e17497f3579fc221310f9452be1129e1f9103f0/ui/chromeos/resources/default_200_percent/default_user_images/geo/avatar_geo3.png
[add] https://crrev.com/3e17497f3579fc221310f9452be1129e1f9103f0/ui/chromeos/resources/default_200_percent/default_user_images/geo/avatar_geo4.png
[add] https://crrev.com/3e17497f3579fc221310f9452be1129e1f9103f0/ui/chromeos/resources/default_200_percent/default_user_images/geo/avatar_geo5.png
[modify] https://crrev.com/3e17497f3579fc221310f9452be1129e1f9103f0/ui/chromeos/resources/ui_chromeos_resources.grd
[modify] https://crrev.com/3e17497f3579fc221310f9452be1129e1f9103f0/ui/chromeos/ui_chromeos_strings.grd

Comment 4 by reve...@chromium.org, Oct 20 2017

Status: Fixed (was: Assigned)
elizabethchiu@, let me know if you want these merged to M63.

Comment 5 by elizabethchiu@chromium.org, Oct 20 2017 

Sounds good to me. Thanks David!

Comment 6 by reve...@chromium.org, Oct 20 2017

Labels: Merge-Request-63 M-63
Project Member

Comment 7 by sheriffbot@chromium.org, Oct 20 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 45 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by josa...@chromium.org, Oct 27 2017

Labels: -Merge-Review-63 Merge-Approved-63
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 27 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bad696f67fcc1ebad42c2f52de14df4d1736ed44

commit bad696f67fcc1ebad42c2f52de14df4d1736ed44
Author: David Reveman <reveman@chromium.org>
Date: Fri Oct 27 04:22:33 2017

ui: Add new geo default user images.

This adds a new set of geometric figure images.

BUG=721647, 763216 
TBR=reveman@chromium.org

(cherry picked from commit 3e17497f3579fc221310f9452be1129e1f9103f0)

Change-Id: I415a6d201e78852f1e274bf98effa47e92764a69
Reviewed-on: https://chromium-review.googlesource.com/576998
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509164}
Reviewed-on: https://chromium-review.googlesource.com/741342
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#260}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/bad696f67fcc1ebad42c2f52de14df4d1736ed44/chrome/browser/chromeos/login/users/default_user_image/default_user_images.cc
[add] https://crrev.com/bad696f67fcc1ebad42c2f52de14df4d1736ed44/ui/chromeos/resources/default_100_percent/default_user_images/geo/avatar_geo1.png
[add] https://crrev.com/bad696f67fcc1ebad42c2f52de14df4d1736ed44/ui/chromeos/resources/default_100_percent/default_user_images/geo/avatar_geo2.png
[add] https://crrev.com/bad696f67fcc1ebad42c2f52de14df4d1736ed44/ui/chromeos/resources/default_100_percent/default_user_images/geo/avatar_geo3.png
[add] https://crrev.com/bad696f67fcc1ebad42c2f52de14df4d1736ed44/ui/chromeos/resources/default_100_percent/default_user_images/geo/avatar_geo4.png
[add] https://crrev.com/bad696f67fcc1ebad42c2f52de14df4d1736ed44/ui/chromeos/resources/default_100_percent/default_user_images/geo/avatar_geo5.png
[add] https://crrev.com/bad696f67fcc1ebad42c2f52de14df4d1736ed44/ui/chromeos/resources/default_200_percent/default_user_images/geo/avatar_geo1.png
[add] https://crrev.com/bad696f67fcc1ebad42c2f52de14df4d1736ed44/ui/chromeos/resources/default_200_percent/default_user_images/geo/avatar_geo2.png
[add] https://crrev.com/bad696f67fcc1ebad42c2f52de14df4d1736ed44/ui/chromeos/resources/default_200_percent/default_user_images/geo/avatar_geo3.png
[add] https://crrev.com/bad696f67fcc1ebad42c2f52de14df4d1736ed44/ui/chromeos/resources/default_200_percent/default_user_images/geo/avatar_geo4.png
[add] https://crrev.com/bad696f67fcc1ebad42c2f52de14df4d1736ed44/ui/chromeos/resources/default_200_percent/default_user_images/geo/avatar_geo5.png
[modify] https://crrev.com/bad696f67fcc1ebad42c2f52de14df4d1736ed44/ui/chromeos/resources/ui_chromeos_resources.grd
[modify] https://crrev.com/bad696f67fcc1ebad42c2f52de14df4d1736ed44/ui/chromeos/ui_chromeos_strings.grd

Comment 10 by gkihumba@google.com, Nov 3 2017

Labels: -Hotlist-Merge-Review
►

Sign in to add a comment