New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763208 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit 28 days ago
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

webkit_layout_tests failing on WebKit Linux Trusty

Project Member Reported by mgiuca@chromium.org, Sep 8 2017

Issue description

virtual/mojo-loading/http/tests/devtools/sources/debugger-ui/source-frame-count.html

Builders failed on: 
- WebKit Linux Trusty: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty

Expected vs actual diff:

 Tests that scripts panel does not create too many source frames.
 
 
 Running: testSourceFramesCount
 Reloading page...
 Page reloaded.
-Less than 3 frames opened
+Too many frames opened: 4
 Visible view: script5.js

Last known good: 500449
First known bad: r500457

Nothing in that (rather small) range is obvious.
 
This is now clearly flaky, so I am just going to disable this test:
virtual/mojo-loading/http/tests/devtools/sources/debugger-ui/source-frame-count.html
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05c6df68ff4993f278e4b41e78dd5dc68981bfc8

commit 05c6df68ff4993f278e4b41e78dd5dc68981bfc8
Author: Matt Giuca <mgiuca@chromium.org>
Date: Fri Sep 08 05:25:33 2017

Disabled test source-frame-count.html on Linux.

Flaky (sometimes "Too many frames opened").

Bug:  763208 
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Tbr: mgiuca@chromium.org
Change-Id: Iede426020f8742ca5220362319103cf6e06af218
Reviewed-on: https://chromium-review.googlesource.com/656659
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500515}
[modify] https://crrev.com/05c6df68ff4993f278e4b41e78dd5dc68981bfc8/third_party/WebKit/LayoutTests/TestExpectations

Cc: dgozman@chromium.org mgiuca@chromium.org
Labels: -Sheriff-Chromium
Owner: pfeldman@chromium.org
Status: Assigned (was: Started)
Assigning to pfeldman who edited this test file recently. (And dgozman who owns devtools.)

Please re-assign if necessary and fix flake, then re-enable test. Thanks.
Owner: lushnikov@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23787bf1fc8ed901459bccc471d97a7a31b441b1

commit 23787bf1fc8ed901459bccc471d97a7a31b441b1
Author: Jesse Doherty <jwd@chromium.org>
Date: Thu Sep 21 21:14:39 2017

sheriff: Disabling correct source-frame-count.html webkit_layout_test for Mac10.12.

Bug:  763208 ,  766952 
Change-Id: I1451eb7dd378ee8e9e65dd5d0f9b0a8e75265d45
TBR: japhet@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/677628
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503565}
[modify] https://crrev.com/23787bf1fc8ed901459bccc471d97a7a31b441b1/third_party/WebKit/LayoutTests/TestExpectations

Cc: chenwilliam@chromium.org
 Issue 766952  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d38d873528abc1ce5876431652c75c7fd972a1dd

commit d38d873528abc1ce5876431652c75c7fd972a1dd
Author: Will Chen <chenwilliam@chromium.org>
Date: Thu Sep 28 02:23:18 2017

DevTools: disable test source-frame-count.html because it's flaky

Bug:  763208 
Change-Id: I13138fb65c7f8071838f99b9297086edd2ea8415
Reviewed-on: https://chromium-review.googlesource.com/660995
Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#504871}
[modify] https://crrev.com/d38d873528abc1ce5876431652c75c7fd972a1dd/third_party/WebKit/LayoutTests/TestExpectations

Labels: -Pri-1 Pri-2
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4cbe8ee5fd2f658f07c3a7d2f959f3cc8e2facb2

commit 4cbe8ee5fd2f658f07c3a7d2f959f3cc8e2facb2
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Fri Dec 15 02:08:39 2017

DevTools: remove the source-frame-count.js test

The test is fundamentally flaky: amount of created source frames is not
constrained by anything.

TBR=kozy,dgozman
BUG= 763208 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I7069ead229589dd03c04358c68641e3a7f0619f5
Reviewed-on: https://chromium-review.googlesource.com/828289
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524290}
[modify] https://crrev.com/4cbe8ee5fd2f658f07c3a7d2f959f3cc8e2facb2/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
[modify] https://crrev.com/4cbe8ee5fd2f658f07c3a7d2f959f3cc8e2facb2/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/9f8d4632b417d2f4fa8216f9be3a19a16554806c/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/source-frame-count.js

Status: Fixed (was: Assigned)

Sign in to add a comment