New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 763202 link

Starred by 1 user
Status: Fixed
Owner:
cjgrant@chromium.org
Closed: Sep 2017
Cc:
█ mgiuca@chromium.org
mac-bugs-priority@chromium.org
creis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug
Team-Security-UX



Sign in to add a comment

TextEliderTest.TestGeneralEliding failing on Mac10.10 Tests

Project Member Reported by mgiuca@chromium.org, Sep 8 2017 
Builders failed on: 
- Mac10.10 Tests: 
  https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests

Test failure:

[ RUN      ] TextEliderTest.TestGeneralEliding
../../components/url_formatter/elide_url_unittest.cc:96: Failure
      Expected: expected_utf16
      Which is: google.com/intl/?
To be equal to: elided
      Which is: google.com/intl/e?
Google Test trace:
../../components/url_formatter/elide_url_unittest.cc:67: Eliding http://www.google.com/intl/en/ads/
[  FAILED  ] TextEliderTest.TestGeneralEliding (29 ms)

Not sure why it fails on this one specific bot. Could be a font issue. May have to make that test more robust. :(

Comment 1 by mgiuca@chromium.org, Sep 8 2017 

The culprit is r500385. Reverting.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed6173edcc8f043217548894f5efd0f1418bcaab

commit ed6173edcc8f043217548894f5efd0f1418bcaab
Author: Matt Giuca <mgiuca@chromium.org>
Date: Fri Sep 08 01:35:13 2017

Revert "ElideUrl: Re-land progressive elision approach."

This reverts commit f205fcfb6248e13bc1d4a8a953932c5fa1b720c8.

Reason for revert: TestGeneralEliding fails on Mac10.10 bot.

Bug:  763202 

Original change's description:
> ElideUrl: Re-land progressive elision approach.
> 
> Several elision test cases specify multiple progressively shorter
> versions of the same original URL. With this change, we'll test that
> progression more thoroughly by specifying the expected sequence of
> consecutive results that should be generated as available space
> decreases.
> 
> This helps eliminate the risk of a broken corner case.
> 
> BUG= 753789 
> 
> Change-Id: I6e7d8fcece3895b5b1c2595b2afacf34adea78b5
> Reviewed-on: https://chromium-review.googlesource.com/655397
> Commit-Queue: Christopher Grant <cjgrant@chromium.org>
> Reviewed-by: Tommy Li <tommycli@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#500385}

TBR=tommycli@chromium.org,cjgrant@chromium.org,shrike@chromium.org

Change-Id: Ia6008f6f33c79a6368919b0a4324bdda1fd291bd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  753789 
Reviewed-on: https://chromium-review.googlesource.com/656797
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500476}
[modify] https://crrev.com/ed6173edcc8f043217548894f5efd0f1418bcaab/components/url_formatter/elide_url_unittest.cc

Comment 3 by mgiuca@chromium.org, Sep 8 2017

Cc: -cjgrant@chromium.org mgiuca@chromium.org
Owner: cjgrant@chromium.org
Status: Fixed (was: Started)
►

Sign in to add a comment