Update shill clients to avoid using deprecated shill DBus APIs, and then remove those deprecated DBus APIs in shill.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9a35ac289e460094b3bbdcc841239f64751566d9 commit 9a35ac289e460094b3bbdcc841239f64751566d9 Author: Ben Chan <benchan@chromium.org> Date: Fri Sep 08 17:22:00 2017 Remove deprecated ShillDeviceClient::AddIPConfig method. shill has deprecated the AddIPConfig method of the Device interface long time ago (see chromium:213436 and CL:23150). This CL removes the client binding of this method. BUG= 763198 TEST=Run chromeos_unittests. Change-Id: Id8255ba2a9683631949e6262d7599dae8f0b11e2 Reviewed-on: https://chromium-review.googlesource.com/656574 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#500613} [modify] https://crrev.com/9a35ac289e460094b3bbdcc841239f64751566d9/chromeos/dbus/fake_shill_device_client.cc [modify] https://crrev.com/9a35ac289e460094b3bbdcc841239f64751566d9/chromeos/dbus/fake_shill_device_client.h [modify] https://crrev.com/9a35ac289e460094b3bbdcc841239f64751566d9/chromeos/dbus/shill_device_client.cc [modify] https://crrev.com/9a35ac289e460094b3bbdcc841239f64751566d9/chromeos/dbus/shill_device_client.h [modify] https://crrev.com/9a35ac289e460094b3bbdcc841239f64751566d9/chromeos/dbus/shill_device_client_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/system_api/+/f76589aaa750debccb7b276ed475a3abceca619f commit f76589aaa750debccb7b276ed475a3abceca619f Author: Ben Chan <benchan@chromium.org> Date: Sat Sep 09 09:26:16 2017 shill: remove kAddIPConfigFunction constant shill deprecated the AddIPConfig method of the Device interface long time ago (see chromium:213436 and CL:23150). ShillDeviceClient::AddIPConfig on the Chrome side was also removed (CL:656574). The kAddIPConfigFunction constant is no longer in use. BUG= chromium:763198 TEST=Remote trybot runs. Change-Id: I7f9c23e0e9291c38edd226dda8edf09bd7af8edd Reviewed-on: https://chromium-review.googlesource.com/658149 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/f76589aaa750debccb7b276ed475a3abceca619f/dbus/shill/dbus-constants.h
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/aa9c8c188e4d5cc87abde00f53e9531b7255e374 commit aa9c8c188e4d5cc87abde00f53e9531b7255e374 Author: Ben Chan <benchan@chromium.org> Date: Sat Sep 09 20:48:49 2017 shill: remove deprecated AddIPConfig method from Device interface This CL removes the the AddIPConfig method from the Device interface, which has been deprecated long time ago (see chromium:213436 and CL:23150). The ShillDeviceClient on the Chrome side has been updated to remove the corresponding binding (CL:656574). BUG= chromium:763198 TEST=Run unit tests. Change-Id: Ia9cb52e17415221da6adb9929aa69075367242c6 Reviewed-on: https://chromium-review.googlesource.com/658405 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/aa9c8c188e4d5cc87abde00f53e9531b7255e374/doc/device-api.txt [modify] https://crrev.com/aa9c8c188e4d5cc87abde00f53e9531b7255e374/dbus/chromeos_device_dbus_adaptor.cc [modify] https://crrev.com/aa9c8c188e4d5cc87abde00f53e9531b7255e374/dbus/chromeos_device_dbus_adaptor.h [modify] https://crrev.com/aa9c8c188e4d5cc87abde00f53e9531b7255e374/dbus_bindings/org.chromium.flimflam.Device.dbus-xml
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/84236529ec7d6f0ec4ad6c30a7047bcc4a9e8028 commit 84236529ec7d6f0ec4ad6c30a7047bcc4a9e8028 Author: Ben Chan <benchan@chromium.org> Date: Tue Sep 12 11:19:30 2017 shill: remove deprecated GetVPNService method from Manager interface This CL removes the the GetVPNService method from the Manager interface, which has been deprecated and no longer used by any client. BUG= chromium:763198 TEST=Run unit tests. Change-Id: I3a6ae50e8f41549d69b85a88ccda10a3b3ecb6fc Reviewed-on: https://chromium-review.googlesource.com/661157 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/84236529ec7d6f0ec4ad6c30a7047bcc4a9e8028/doc/manager-api.txt [modify] https://crrev.com/84236529ec7d6f0ec4ad6c30a7047bcc4a9e8028/dbus/chromeos_manager_dbus_adaptor.cc [modify] https://crrev.com/84236529ec7d6f0ec4ad6c30a7047bcc4a9e8028/dbus/chromeos_manager_dbus_adaptor.h [modify] https://crrev.com/84236529ec7d6f0ec4ad6c30a7047bcc4a9e8028/dbus_bindings/org.chromium.flimflam.Manager.dbus-xml
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/12afb4453596c6f645c6ff5d93ec30f54d2241ef commit 12afb4453596c6f645c6ff5d93ec30f54d2241ef Author: Ben Chan <benchan@chromium.org> Date: Tue Sep 12 11:19:30 2017 shill: remove deprecated GetWifiService method from Manager interface This CL removes the the GetWifiService method from the Manager interface, which has been deprecated and no longer used by any client. BUG= chromium:763198 TEST=Run unit tests. Change-Id: I0faccf7c854dd6b7c2bed81fa42a19de7516f888 Reviewed-on: https://chromium-review.googlesource.com/661158 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/12afb4453596c6f645c6ff5d93ec30f54d2241ef/doc/manager-api.txt [modify] https://crrev.com/12afb4453596c6f645c6ff5d93ec30f54d2241ef/dbus/chromeos_manager_dbus_adaptor.cc [modify] https://crrev.com/12afb4453596c6f645c6ff5d93ec30f54d2241ef/dbus/chromeos_manager_dbus_adaptor.h [modify] https://crrev.com/12afb4453596c6f645c6ff5d93ec30f54d2241ef/dbus_bindings/org.chromium.flimflam.Manager.dbus-xml
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/system_api/+/3748b699c4e547883b4cfeee05ee4338209c795e commit 3748b699c4e547883b4cfeee05ee4338209c795e Author: Ben Chan <benchan@chromium.org> Date: Tue Sep 12 11:19:32 2017 shill: remove kGetVPNServiceFunction and kGetWifiServiceFunction constant The GetVPNService and kGetWifiService method of the shill Manager interface have been deprecated and no longer used by any client. BUG= chromium:763198 TEST=Remote trybot runs. Change-Id: Ia9b47920d1140e3c1596e5d53f63dbf96d15ed77 Reviewed-on: https://chromium-review.googlesource.com/661180 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/3748b699c4e547883b4cfeee05ee4338209c795e/dbus/shill/dbus-constants.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4b7ead02c6b027570dd8a618ac04827983aa52d1 commit 4b7ead02c6b027570dd8a618ac04827983aa52d1 Author: Ben Chan <benchan@chromium.org> Date: Thu Oct 05 18:17:15 2017 Remove bindings to shill's deprecated Device.ProposeScan DBus method. shill's Device.ProposeScan DBus method has been deprecated and superseded by the Device.RequestScan DBus method. BUG= 763198 TEST=chromeos_unittests Change-Id: I9ae4a115ee2e0f14a10f06a5bdbe4e48b21bba83 Reviewed-on: https://chromium-review.googlesource.com/701622 Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ben Chan <benchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#506791} [modify] https://crrev.com/4b7ead02c6b027570dd8a618ac04827983aa52d1/chromeos/dbus/fake_shill_device_client.cc [modify] https://crrev.com/4b7ead02c6b027570dd8a618ac04827983aa52d1/chromeos/dbus/fake_shill_device_client.h [modify] https://crrev.com/4b7ead02c6b027570dd8a618ac04827983aa52d1/chromeos/dbus/shill_device_client.cc [modify] https://crrev.com/4b7ead02c6b027570dd8a618ac04827983aa52d1/chromeos/dbus/shill_device_client.h [modify] https://crrev.com/4b7ead02c6b027570dd8a618ac04827983aa52d1/chromeos/dbus/shill_device_client_unittest.cc [modify] https://crrev.com/4b7ead02c6b027570dd8a618ac04827983aa52d1/chromeos/network/fake_network_device_handler.cc [modify] https://crrev.com/4b7ead02c6b027570dd8a618ac04827983aa52d1/chromeos/network/fake_network_device_handler.h [modify] https://crrev.com/4b7ead02c6b027570dd8a618ac04827983aa52d1/chromeos/network/mock_network_device_handler.h [modify] https://crrev.com/4b7ead02c6b027570dd8a618ac04827983aa52d1/chromeos/network/network_device_handler.h [modify] https://crrev.com/4b7ead02c6b027570dd8a618ac04827983aa52d1/chromeos/network/network_device_handler_impl.cc [modify] https://crrev.com/4b7ead02c6b027570dd8a618ac04827983aa52d1/chromeos/network/network_device_handler_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/910797912c2af5757a1716299542edb30f63126f commit 910797912c2af5757a1716299542edb30f63126f Author: Ben Chan <benchan@chromium.org> Date: Fri Oct 06 04:24:41 2017 shill: test-scripts: drop support for device-level scan The ProposeScan method provided by the Device interface has been deprecated and will be removed. This CL drops the support for device-level scan in the test-flimflam script. BUG= chromium:763198 TEST=Manual sanity check on test-flimflam script. Change-Id: If05150de9848586aed0b46f3a6e28acce658de2c Reviewed-on: https://chromium-review.googlesource.com/702759 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> [modify] https://crrev.com/910797912c2af5757a1716299542edb30f63126f/test-scripts/test-flimflam
The following revision refers to this bug: https://chromium.googlesource.com/aosp/platform/system/connectivity/shill/+/96136b4eef1d5d684989bcfb386e9ffa097d784e commit 96136b4eef1d5d684989bcfb386e9ffa097d784e Author: Ben Chan <benchan@chromium.org> Date: Fri Oct 06 07:21:29 2017 shill: remove deprecated ProposeScan method from Device interface This CL removes the the ProposeScan method from the Device interface, which has been deprecated and no longer used by any client. The description about the ProposeScan method is also moved to the RequestScan method. BUG= chromium:763198 TEST=Run unit tests. Change-Id: I4f468b8d7669bfa3fdba7879e7ebb69414e12d28 Reviewed-on: https://chromium-review.googlesource.com/702760 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/96136b4eef1d5d684989bcfb386e9ffa097d784e/doc/manager-api.txt [modify] https://crrev.com/96136b4eef1d5d684989bcfb386e9ffa097d784e/doc/device-api.txt [modify] https://crrev.com/96136b4eef1d5d684989bcfb386e9ffa097d784e/dbus/chromeos_device_dbus_adaptor.cc [modify] https://crrev.com/96136b4eef1d5d684989bcfb386e9ffa097d784e/dbus/chromeos_device_dbus_adaptor.h [modify] https://crrev.com/96136b4eef1d5d684989bcfb386e9ffa097d784e/dbus_bindings/org.chromium.flimflam.Device.dbus-xml
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/system_api/+/b72ba4766084e577d9e31cfd5d56d24f56e64732 commit b72ba4766084e577d9e31cfd5d56d24f56e64732 Author: Ben Chan <benchan@chromium.org> Date: Fri Oct 06 10:57:46 2017 shill: remove kProposeScanFunction constant shill has deprecated and removed the ProposeScan method from the Device interface (CL:702760). No client references to the kProposeScanFunction constant. BUG= chromium:763198 TEST=Run unit tests. Change-Id: Ib1246ee828e82ab1d46b543fe729dcde4b91a9f1 Reviewed-on: https://chromium-review.googlesource.com/704399 Commit-Ready: Ben Chan <benchan@chromium.org> Tested-by: Ben Chan <benchan@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/b72ba4766084e577d9e31cfd5d56d24f56e64732/dbus/shill/dbus-constants.h
Comment 1 by benchan@chromium.org
, Sep 8 2017