Comments' timestamp should be shown in user's local time and/or relative time |
|||
Issue descriptionSheriff-O-Matic comment header reads: "shrike on Tue Sep 05 2017 15:44:16 GMT-0700" This requires mental arithmetic or time zone converter app to figure out how old this is. Please change to: "shrike on Tue Sep 06 2017 08:44:16 UTC+1000 (1h45m ago)" - Use my local time. - Use "UTC" instead of "GMT" (correct terminology). - Give the relative time (possibly just in a tooltip).
,
Sep 8 2017
,
Sep 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/2ff5ad4db1d23a3c82ab692e44fdfbd857eb46e8 commit 2ff5ad4db1d23a3c82ab692e44fdfbd857eb46e8 Author: Tiff Zhang <zhangtiff@google.com> Date: Mon Sep 11 18:52:15 2017 SoM: Add relative time to comment timestamps. Bug:763184 Change-Id: I27e488bda05c5c9e1a84cb8f62c92a6b2d2ff29a Reviewed-on: https://chromium-review.googlesource.com/658081 Reviewed-by: Sean McCullough <seanmccullough@chromium.org> Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org> [modify] https://crrev.com/2ff5ad4db1d23a3c82ab692e44fdfbd857eb46e8/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-annotations-test.html [modify] https://crrev.com/2ff5ad4db1d23a3c82ab692e44fdfbd857eb46e8/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-annotations.js
,
Sep 11 2017
,
Sep 12 2017
Thanks for doing this! It works, but as I noted on the CL, it doesn't show am/pm any more (small problem).
,
Sep 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/9f7d7ad72384f0cbe426a9ff07820c66ebfd1bf3 commit 9f7d7ad72384f0cbe426a9ff07820c66ebfd1bf3 Author: Tiff Zhang <zhangtiff@google.com> Date: Tue Sep 12 18:10:25 2017 SoM: Add PM/AM to comments timestamp. Bug:763184 Change-Id: I7fd5e7c7fe6e4221aa6b641a2c9e2fa68b022d5c Reviewed-on: https://chromium-review.googlesource.com/662244 Reviewed-by: Sean McCullough <seanmccullough@chromium.org> Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org> [modify] https://crrev.com/9f7d7ad72384f0cbe426a9ff07820c66ebfd1bf3/go/src/infra/appengine/sheriff-o-matic/frontend/test/som-annotations-test.html [modify] https://crrev.com/9f7d7ad72384f0cbe426a9ff07820c66ebfd1bf3/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-annotations/som-annotations.js |
|||
►
Sign in to add a comment |
|||
Comment 1 by seanmccullough@chromium.org
, Sep 8 2017Status: Available (was: Untriaged)