Issue 763183 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	afakhry@chromium.org
Closed:	Sep 2017
Components:	UI>Shell>Display
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug

Blocking:
issue 752767

ComputeBoundary is buggy

Project Member Reported by afakhry@chromium.org, Sep 8 2017

Issue description

While adding tests for the unified desktop APIs, I found bugs in display::ComputeBoundary(). It would calculate edges for displays that share no edges:

----------------

+----+       
|    |
+----+----+
     |    |
     +----+
 
----------------
     
+----+       
|    |
+----+
     
     +----+
     |    |
     +----+
     
----------------     
     
+----+       
|    |
+----+  +----+
        |    |
        +----+
        
----------------

Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55555ff3a78d388902ef403ed0d4b0c2bc160af1

commit 55555ff3a78d388902ef403ed0d4b0c2bc160af1
Author: Ahmed Fakhry <afakhry@google.com>
Date: Thu Sep 21 02:29:11 2017

Fix edge cases where ComputeBoundary() fails

Handle special cases when displays sides align but share no borders.

BUG= 763183 
TEST=Added display_unittests --gtest_filter=DisplayUtilitiesTest.ComputeBoundary

Change-Id: Id7b57e5be779bc62036246dd32bb7bd580bfc340
Reviewed-on: https://chromium-review.googlesource.com/656204
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503316}
[modify] https://crrev.com/55555ff3a78d388902ef403ed0d4b0c2bc160af1/ui/display/manager/display_manager_utilities.cc
[modify] https://crrev.com/55555ff3a78d388902ef403ed0d4b0c2bc160af1/ui/display/manager/display_manager_utilities_unittest.cc