New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763177 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

[MD settings] indent in displays

Project Member Reported by dschuyler@chromium.org, Sep 7 2017

Issue description

in chromeos chrome://settings/display
the indent is not the same as used elsewhere in MD webui.
Change the indent to be consistent with the rest of Md settings.
 
Screenshot from 2017-09-07 16:52:11.png
24.1 KB View Download
Screenshot from 2017-09-07 16:28:00.png
24.6 KB View Download
Labels: OS-Chrome
In the screen shots above:
The "16:52:11.png" is the wrong indent.
The "16:28:00.png" is the fixed indent that is consistent.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/673e8a437f569bff9705e9b6e9883d25b795d384

commit 673e8a437f569bff9705e9b6e9883d25b795d384
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Tue Sep 12 21:06:38 2017

[cr ui] use cr-link-row in MD settings

This CL expands the usage of cr-link-row into settings. This doesn't
replace all instances of link rows. It's a sampling of a few different
cases. Changes UI for: device display overscan, customize fonts,
passwords and forms links.

Bug:  757663 ,  763177 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id63d8b8c5a6c3c36e6804018ea66d8d03679f1ad
Reviewed-on: https://chromium-review.googlesource.com/656527
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501394}
[modify] https://crrev.com/673e8a437f569bff9705e9b6e9883d25b795d384/chrome/browser/resources/md_extensions/detail_view.html
[modify] https://crrev.com/673e8a437f569bff9705e9b6e9883d25b795d384/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/673e8a437f569bff9705e9b6e9883d25b795d384/chrome/browser/resources/settings/device_page/display.html
[modify] https://crrev.com/673e8a437f569bff9705e9b6e9883d25b795d384/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
[modify] https://crrev.com/673e8a437f569bff9705e9b6e9883d25b795d384/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/673e8a437f569bff9705e9b6e9883d25b795d384/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/673e8a437f569bff9705e9b6e9883d25b795d384/ui/webui/resources/cr_elements/cr_link_row/cr_link_row.html

Status: Fixed (was: Started)

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 6 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment