Quick settings UX for secondary users |
||||||||||
Issue descriptionWe should disable Instant Tethering in this case.
,
Sep 8 2017
Yes, let's hide the section entirely for secondary users if Bluetooth is disabled.
,
Sep 8 2017
Thanks - sounds good!
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/652b7c08768e3dfb6b4a48e796ef3a4d8b3a15ec commit 652b7c08768e3dfb6b4a48e796ef3a4d8b3a15ec Author: Kyle Horimoto <khorimoto@google.com> Date: Fri Sep 08 22:42:55 2017 [CrOS Tether] Adjust Mobile data quick settings visibility. When Bluetooth is disabled, we display a message in quick settings to tell the user that enabling Mobile data will enable Bluetooth. However, when multi-login is active, secondary users do not have the ability to enable or disable Bluetooth themselves (this is restricted to primary users only). Thus, the message no longer made sense, and the Mobile data section as a whole was useless. With this CL, that section is hidden for secondary users. Bug: 763164 , 672263 Change-Id: I478ab32aa4366881945cd423347f362b957a009a Reviewed-on: https://chromium-review.googlesource.com/657201 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Stefan Kuhne <skuhne@chromium.org> Cr-Commit-Position: refs/heads/master@{#500718} [modify] https://crrev.com/652b7c08768e3dfb6b4a48e796ef3a4d8b3a15ec/ash/system/network/network_list.cc [modify] https://crrev.com/652b7c08768e3dfb6b4a48e796ef3a4d8b3a15ec/ash/system/network/network_list.h
,
Sep 8 2017
,
Sep 8 2017
This bug requires manual review: Request affecting a post-stable build Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 11 2017
Approving merge to M61 and M62.
,
Sep 11 2017
,
Sep 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/97bc624d33ee96b39d96144dbb4540e5d81cf8fa commit 97bc624d33ee96b39d96144dbb4540e5d81cf8fa Author: Kyle Horimoto <khorimoto@google.com> Date: Mon Sep 11 17:50:31 2017 [CrOS Tether] Adjust Mobile data quick settings visibility. When Bluetooth is disabled, we display a message in quick settings to tell the user that enabling Mobile data will enable Bluetooth. However, when multi-login is active, secondary users do not have the ability to enable or disable Bluetooth themselves (this is restricted to primary users only). Thus, the message no longer made sense, and the Mobile data section as a whole was useless. With this CL, that section is hidden for secondary users. TBR=khorimoto@google.com (cherry picked from commit 652b7c08768e3dfb6b4a48e796ef3a4d8b3a15ec) Bug: 763164 , 672263 Change-Id: I478ab32aa4366881945cd423347f362b957a009a Reviewed-on: https://chromium-review.googlesource.com/657201 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Stefan Kuhne <skuhne@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#500718} Reviewed-on: https://chromium-review.googlesource.com/661060 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3163@{#1158} Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528} [modify] https://crrev.com/97bc624d33ee96b39d96144dbb4540e5d81cf8fa/ash/system/network/network_list.cc [modify] https://crrev.com/97bc624d33ee96b39d96144dbb4540e5d81cf8fa/ash/system/network/network_list.h
,
Sep 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1c07d7a38c286ace95a1c9fffcc32d48cba6c772 commit 1c07d7a38c286ace95a1c9fffcc32d48cba6c772 Author: Kyle Horimoto <khorimoto@google.com> Date: Mon Sep 11 18:09:05 2017 [CrOS Tether] Adjust Mobile data quick settings visibility. When Bluetooth is disabled, we display a message in quick settings to tell the user that enabling Mobile data will enable Bluetooth. However, when multi-login is active, secondary users do not have the ability to enable or disable Bluetooth themselves (this is restricted to primary users only). Thus, the message no longer made sense, and the Mobile data section as a whole was useless. With this CL, that section is hidden for secondary users. TBR=khorimoto@google.com (cherry picked from commit 652b7c08768e3dfb6b4a48e796ef3a4d8b3a15ec) Bug: 763164 , 672263 Change-Id: I478ab32aa4366881945cd423347f362b957a009a Reviewed-on: https://chromium-review.googlesource.com/657201 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Stefan Kuhne <skuhne@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#500718} Reviewed-on: https://chromium-review.googlesource.com/661069 Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#135} Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098} [modify] https://crrev.com/1c07d7a38c286ace95a1c9fffcc32d48cba6c772/ash/system/network/network_list.cc [modify] https://crrev.com/1c07d7a38c286ace95a1c9fffcc32d48cba6c772/ash/system/network/network_list.h
,
Jan 22 2018
,
Jan 23 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by khorimoto@chromium.org
, Sep 7 2017Owner: shibasheikh@chromium.org
Summary: Quick settings UX for secondary users (was: Tether component is enabled when secondary user signed in)