New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763164 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Quick settings UX for secondary users

Project Member Reported by khorimoto@chromium.org, Sep 7 2017

Issue description

We should disable Instant Tethering in this case.
 
Cc: sonnysasaka@chromium.org kuscher@chromium.org jennschen@chromium.org shibasheikh@chromium.org elizabethchiu@chromium.org
Owner: shibasheikh@chromium.org
Summary: Quick settings UX for secondary users (was: Tether component is enabled when secondary user signed in)
Actually, thinking about this further, we shouldn't disable it in this case. This could create a weird situation where a user logs in, starts tethering, then switches to a secondary user, which would cause a disconnection.

Instead, we need to revisit the quick settings UI for this case. Secondary users are disallowed from enabling/disabling Bluetooth, so the quick settings section which says "Enabling Mobile data will enable Bluetooth" no longer makes sense. UX, can you please let us know what you'd like us to do here?

IMO, we should just hide the section entirely if Bluetooth is disabled, and show it if Bluetooth is enabled. Thoughts?
Yes, let's hide the section entirely for secondary users if Bluetooth is disabled.
Owner: khorimoto@chromium.org
Status: Started (was: Assigned)
Thanks - sounds good!
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/652b7c08768e3dfb6b4a48e796ef3a4d8b3a15ec

commit 652b7c08768e3dfb6b4a48e796ef3a4d8b3a15ec
Author: Kyle Horimoto <khorimoto@google.com>
Date: Fri Sep 08 22:42:55 2017

[CrOS Tether] Adjust Mobile data quick settings visibility.

When Bluetooth is disabled, we display a message in quick settings to
tell the user that enabling Mobile data will enable Bluetooth. However,
when multi-login is active, secondary users do not have the ability to
enable or disable Bluetooth themselves (this is restricted to primary
users only). Thus, the message no longer made sense, and the Mobile data
section as a whole was useless.

With this CL, that section is hidden for secondary users.

Bug:  763164 , 672263
Change-Id: I478ab32aa4366881945cd423347f362b957a009a
Reviewed-on: https://chromium-review.googlesource.com/657201
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500718}
[modify] https://crrev.com/652b7c08768e3dfb6b4a48e796ef3a4d8b3a15ec/ash/system/network/network_list.cc
[modify] https://crrev.com/652b7c08768e3dfb6b4a48e796ef3a4d8b3a15ec/ash/system/network/network_list.h

Labels: Merge-Request-61
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 8 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: Request affecting a post-stable build
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by ketakid@google.com, Sep 11 2017

Labels: -Merge-Review-61 Merge-Approved-61 Merge-Approved-62
Approving merge to M61 and M62.
Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 11 2017

Labels: -merge-approved-61 merge-merged-3163
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97bc624d33ee96b39d96144dbb4540e5d81cf8fa

commit 97bc624d33ee96b39d96144dbb4540e5d81cf8fa
Author: Kyle Horimoto <khorimoto@google.com>
Date: Mon Sep 11 17:50:31 2017

[CrOS Tether] Adjust Mobile data quick settings visibility.

When Bluetooth is disabled, we display a message in quick settings to
tell the user that enabling Mobile data will enable Bluetooth. However,
when multi-login is active, secondary users do not have the ability to
enable or disable Bluetooth themselves (this is restricted to primary
users only). Thus, the message no longer made sense, and the Mobile data
section as a whole was useless.

With this CL, that section is hidden for secondary users.

TBR=khorimoto@google.com

(cherry picked from commit 652b7c08768e3dfb6b4a48e796ef3a4d8b3a15ec)

Bug:  763164 , 672263
Change-Id: I478ab32aa4366881945cd423347f362b957a009a
Reviewed-on: https://chromium-review.googlesource.com/657201
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500718}
Reviewed-on: https://chromium-review.googlesource.com/661060
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#1158}
Cr-Branched-From: ff259bab28b35d242e10186cd63af7ed404fae0d-refs/heads/master@{#488528}
[modify] https://crrev.com/97bc624d33ee96b39d96144dbb4540e5d81cf8fa/ash/system/network/network_list.cc
[modify] https://crrev.com/97bc624d33ee96b39d96144dbb4540e5d81cf8fa/ash/system/network/network_list.h

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 11 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c07d7a38c286ace95a1c9fffcc32d48cba6c772

commit 1c07d7a38c286ace95a1c9fffcc32d48cba6c772
Author: Kyle Horimoto <khorimoto@google.com>
Date: Mon Sep 11 18:09:05 2017

[CrOS Tether] Adjust Mobile data quick settings visibility.

When Bluetooth is disabled, we display a message in quick settings to
tell the user that enabling Mobile data will enable Bluetooth. However,
when multi-login is active, secondary users do not have the ability to
enable or disable Bluetooth themselves (this is restricted to primary
users only). Thus, the message no longer made sense, and the Mobile data
section as a whole was useless.

With this CL, that section is hidden for secondary users.

TBR=khorimoto@google.com

(cherry picked from commit 652b7c08768e3dfb6b4a48e796ef3a4d8b3a15ec)

Bug:  763164 , 672263
Change-Id: I478ab32aa4366881945cd423347f362b957a009a
Reviewed-on: https://chromium-review.googlesource.com/657201
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500718}
Reviewed-on: https://chromium-review.googlesource.com/661069
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#135}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/1c07d7a38c286ace95a1c9fffcc32d48cba6c772/ash/system/network/network_list.cc
[modify] https://crrev.com/1c07d7a38c286ace95a1c9fffcc32d48cba6c772/ash/system/network/network_list.h

Comment 11 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 12 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment