New issue
Advanced search Search tips

Issue 763153 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

service_worker.service_worker failing on 3 builders

Project Member Reported by oysteine@chromium.org, Sep 7 2017

Issue description

Cc: horo@chromium.org
Traceback (most recent call last):
  RunBenchmark at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py:332
    expectations=expectations, metadata=benchmark.GetMetadata())
  Run at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py:203
    _RunStoryAndProcessErrorIfNeeded(story, results, state, test)
  _RunStoryAndProcessErrorIfNeeded at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py:105
    state.RunStory(results)
  traced_function at /b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:52
    return func(*args, **kwargs)
  RunStory at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/page/shared_page_state.py:333
    self._current_page, self._current_tab, results)
  traced_function at /b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:75
    return func(*args, **kwargs)
  ValidateAndMeasurePage at /b/swarming/w/ir/tools/perf/benchmarks/service_worker.py:133
    self._speed_index.Stop(page, tab)
  Stop at /b/swarming/w/ir/tools/perf/metrics/speedindex.py:50
    self._impl.Stop(tab)
  Stop at /b/swarming/w/ir/tools/perf/metrics/speedindex.py:171
    for time, image in video_capture.GetVideoFrameIter()
  GetVideoFrameIter at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/image_processing/video.py:53
    for _, bmp in frame_generator:
  _FramesFromMp4 at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/image_processing/video.py:157
    dimensions = GetDimensions(mp4_file)
  GetDimensions at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/image_processing/video.py:132
    dimensions = map(int, dimensions.split()[0].split('x'))
ValueError: invalid literal for int() with base 10: 'bt470bg/bt470bg/smpte170m)'

=== BISECT JOB RESULTS ===
NO Test failure found

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : service_worker.service_worker
  Metric       : page_load_1st_speed_index/first_load

Revision             Exit Code      N
chromium@496720      0 +- N/A       5      good
chromium@496822      0 +- N/A       5      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=first.load service_worker.service_worker

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8969068758436794224


For feedback, file a bug with component Speed>Bisection
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcd4828171b901b55614f87ea154a849b06e5430

commit fcd4828171b901b55614f87ea154a849b06e5430
Author: Oystein Eftevaag <oysteine@chromium.org>
Date: Fri Sep 08 01:19:32 2017

Disable service_worker test on Android

TBR=nednguyen
BUG= 763153 

Change-Id: Ifbc45702b364a238928f4c763e83439c9c29f19b
Reviewed-on: https://chromium-review.googlesource.com/656512
Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500469}
[modify] https://crrev.com/fcd4828171b901b55614f87ea154a849b06e5430/tools/perf/benchmarks/service_worker.py

Comment 7 by falken@chromium.org, Sep 13 2017

Cc: falken@chromium.org nedngu...@google.com
 Issue 764545  has been merged into this issue.

Comment 8 by falken@chromium.org, Sep 13 2017

Cc: -falken@chromium.org
Owner: falken@chromium.org
Status: Started (was: Available)
Will disable the test completely, c#6 just disabled "first_load" but we have to disable all the loads.

Comment 9 by falken@chromium.org, Sep 13 2017

Components: Blink>ServiceWorker Tests>Telemetry
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b4a992ad329a590bd64ee1fd7ede5fb7eaca269

commit 4b4a992ad329a590bd64ee1fd7ede5fb7eaca269
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Sep 13 06:32:43 2017

Disable service_worker.service_worker perf test.

This is using the deprecated Speed Index. Apparently something changed that
broke us. We aren't really using this benchmark and can probably delete it
outright but let's wait until the new PWA benchmark is landed.

Bug:  763153 
Change-Id: I0fe734a145e9cf20b741f128e67456aff29e956c
Reviewed-on: https://chromium-review.googlesource.com/663799
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501555}
[modify] https://crrev.com/4b4a992ad329a590bd64ee1fd7ede5fb7eaca269/tools/perf/benchmarks/service_worker.py

Status: Fixed (was: Started)

Sign in to add a comment