Android tab previews broken |
|||||
Issue descriptionOn recent Chrome for Android builds, the tab switcher is not showing tab previews for tabs other than the current one. The tab previews are white. See attached screenshot. I bisected archived builds and landed exactly on this CL: https://chromium-review.googlesource.com/c/chromium/src/+/637003 Repro steps: 1. Open at least one tab to a page other than the "new tab" page. 2. Switch to the other tab. 3. Tap the tab selector button and view the previews.
,
Sep 7 2017
,
Sep 7 2017
I'm not intimately familiar with how it works, but I believe this is the method that gets called to capture the tab preview: https://chromium.googlesource.com/chromium/src/+/a33dfc460d880eb254b297c16ad9d56f0a36b211/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/content/TabContentManager.java#168
,
Sep 7 2017
,
Sep 7 2017
Looking over the Android-specific parts of the change, I think I may have found the issue. Looks like one call point was accidentally changed to return a bitmap instead of a texture: https://chromium-review.googlesource.com/c/chromium/src/+/637003/14/ui/android/delegated_frame_host_android.cc And, this breaks things because the callback is bound to a helper function that expects a texture, not a bitmap result: https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_view_android.cc?rcl=e8e49e184dbaf840d63be93f2163fa1dafa1e208&l=1164 So, the fix should be as simple as changing from viz::CopyOutputRequest::ResultFormat::RGBA_BITMAP to viz::CopyOutputRequest::ResultFormat::RGBA_TEXTURE in delegated_frame_host_android.cc. Can someone with an Android set up confirm this fixes the issue?
,
Sep 7 2017
Let me check real quick
,
Sep 7 2017
Yes, that fixes the issue :)
,
Sep 8 2017
,
Sep 8 2017
,
Sep 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7cdcb3e2776e69567d4457099d7af97b48c1ff6 commit d7cdcb3e2776e69567d4457099d7af97b48c1ff6 Author: Ryan Landay <rlanday@chromium.org> Date: Fri Sep 08 00:47:41 2017 Fix Android tab previews in tab selector In this CL: https://chromium-review.googlesource.com/c/chromium/src/+/637003 a call to CopyOutputRequest::CreateRequest() was accidentally changed to return a bitmap instead of a texture. The passed-in callback is bound to a helper function that expects a texture, which ended up preventing tabs from being read into bitmaps. This CL fixes this issue. Bug: 763150 Change-Id: I2f2dba76ab129349938a79d151a81ec81b5871c9 Reviewed-on: https://chromium-review.googlesource.com/656511 Reviewed-by: Yuri Wiitala <miu@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#500458} [modify] https://crrev.com/d7cdcb3e2776e69567d4457099d7af97b48c1ff6/ui/android/delegated_frame_host_android.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by wutao@chromium.org
, Sep 7 2017