Issue metadata
Sign in to add a comment
|
Typed Navigations from Redirects Don't Increment Typed Count |
||||||||||||||||||
Issue descriptionGoogle Chrome 61.0.3163.79 (Official Build) (64-bit) Revision 2bd57c7d956c47bc51eff132dd114136ec0a6db7-refs/branch-heads/3163@{#1092} OS Linux JavaScript V8 6.1.534.32 What steps will reproduce the problem? (1) Open a fresh install. (2) Type http://www.wellsfargo.com/ in the omnibox and press enter. (3) Observe that web site redirects to https://www.wellsfargo.com/ What is the expected result? The History database should show one typed visit to http://www.wellsfargo.com/ and one to https://www.wellsfargo.com/. What happens instead? The History database should show one typed visit to http://www.wellsfargo.com/ and no typed visits to https://www.wellsfargo.com/. If I look in the History database, I see both URLs. The URL table shows each has 1 in the visit_count field but only the http visit has 1 in the typed_count field. Both have correct (identical) last visit times. The visits table shows the http visit has transition type 268435457 ( = PAGE_TRANSITION_CHAIN_START, PAGE_TRANSITION_TYPED). The https visit has transition type 2684354561 ( = PAGE_TRANSITION_SERVER_REDIRECT, PAGE_TRANSITION_CHAIN_END, PAGE_TRANSITION_TYPED). Thus, it appears the redirect has the direct transition type--it's being marked as TYPED appropriately--but the typed count field isn't being updated.
,
Sep 7 2017
It looks like this is intentional. Chrome excludes redirects from incrementing the typed count. https://cs.chromium.org/chromium/src/components/history/core/browser/history_backend.cc?l=787 I traced this back with git blame to the initial comment. This behavior has existed for a long time. In the process, I found a comment from pkasting@ arguing that Chrome should exclude redirects from incrementing typed counts. See b/1148304 Assigning to pkasting@ to resolve his disagreement with himself. :-)
,
Sep 7 2017
Can you paste that comment? I don't have easy buganizer access atm. Indeed, we explicitly exclude redirects in HistoryBackend::AddPageVisit(). I remember writing this and debating what to do. The middle entries of a redirect chain pretty clearly shouldn't be marked as "typed". The first one definitely should. But the last one isn't clear; the user hasn't directly typed it, and marking it as such could make the omnibox behavior wonky, but not marking it prevents boostrapping new URLs. I don't know whether there's a middle ground where we mark this as typed when it's not "substantially different" than the chain start. Another middle ground would be to add some sort of more fine-grained stat tracking than visit and typed counts (e.g. distinguish between "link clicked", "visited via omnibox", and "visited via typing this URL directly in the omnibox" and then changing the history provider scoring. That sounds way too big and not likely to provide a huge win. I also wonder if this is why bug 701091 isn't fixed yet. I don't know how to resolve this and I don't have the mental bandwidth to own it.
,
Sep 8 2017
> Can you paste that comment? Not easily. You made multiple comments on that thread, including some referencing file attachments. If you want I can attach a PDF of the whole thread along with the file attachments to this bug thread, though that seems unnecessarily heavy-handed. Given your comment above "I remember writing this and debating what to do. ...", you're implying that we should not be marking redirects as typed or at minimum not incrementing the typed count for redirects. This statement is consistent with your previous comment on the bug thread and consistent with current behavior. There could be a middle ground of http<->https, a la what I proposed on bug 542484 comment 27. Perhaps here we can increment the typed count of the https page if a page does a http->https redirection. This helps promote https sites. It'll complement whatever improvement we make to bug 542484. I don't think there's a middle ground for more fine-grained stat collecting. And, yes, I'm pretty sure this is the reason why bug 701091 exists. In the code when checking whether an intranet site is a known host, we look for typed counts > 0. If we're not incrementing typed counts during redirects, then that's an obvious issue here. Again, I'm willing to go with WontFix on this bug, or maybe implementing the first middle ground I mention. But, regardless, we need to clearly understand that all pages on redirect chains will likely not have similar scores (unlike, say, what was claimed on bug 542484 comment 26).
,
Sep 8 2017
I'm fairly sure we should do something rather than do nothing. I'm less sure what the something is. I'd either just mark the chain_end as typed and hope it doesn't cause too much weirdness, or I'd put in something that says "mark it as typed if it's an intranet URL or has the same hostname as the chain start". Maybe that heuristic would catch most of the redirects that matter while excluding the sorts of things that would confuse users.
,
Sep 19 2017
Untriaged -> Available, as we want to do something and have a couple of ideas.
,
Sep 20
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 20
mpearson: assigning to you for your latest thoughts. Feel free to unassign yourself when done. Should we just NextAction it? Is it worth putting on the list of potential Q4 or Q1 work? I'm unclear on what the severity of this issue is.
,
Sep 20
,
Sep 20
I think the fix bug 542484 handled the common case, including the example in the original report. There might be something else to do there. How often do users go somewhere by typing part of a URL / title and that page redirects, then the user tries again later to go to the page using the omnibox and types part of the URL/title of the redirect, not part of the URL/title of the original page? That sounds unlikely to me. I might even WontFix this. My instinct says it's relatively low priority.
,
Sep 20
,
Jan 8
The NextAction date has arrived: 2019-01-08 |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by mpear...@chromium.org
, Sep 7 2017