Issue metadata
Sign in to add a comment
|
Keyboard input mode indicator bubble is huge |
||||||||||||||||||||||
Issue descriptionGoogle Chrome 62.0.3202.9 (Official Build) dev (64-bit) Revision 0 Platform 9901.7.0 (Official Build) dev-channel samus What steps will reproduce the problem? (1) Open new tab in browser. Click inside omnibox (2) Change keyboard input mode using Ctrl+Space shortcut What is the expected result? Tiny indicator is shown in the text input field to indicate that keyboard text input mode is switched What happens instead? Indicator is huge Attached screenshots.
,
Sep 18 2017
Looks like ModeIndicatorView needs to support hidpi screen. James, can you please help to triage? Thanks.
,
Sep 18 2017
Reproduces on tip of trunk. Does not repro on: Google Chrome 61.0.3163.80 (Official Build) beta (64-bit) Platform 9765.53.0 (Official Build) beta-channel samus So this is a regression between the M61 and M62 branch points, which per go/omahaproxy are r488528 and r499098. I touched ui/chromeos/ime/mode_indicator_view.cc in r483813, which is outside this range. Something must have changed in bubble size computations. Perhaps mode_indicator_view.cc needs to be updated. The bug can be reproduced on linux desktop by building with GN arg target_os="chromeos" and running with --ash-host-window-bounds="2000x1500*2" to simulate hidpi. You'll need to go into settings > input methods and add a second input method. I add Dvorak. tools/bisect-builds.py (with hacks from issue 764487 ) gives range https://chromium.googlesource.com/chromium/src/+log/d1e94bef2bffc1d48b882bf9d826be81a09d0dfe..0e29fac6b8debe413834ce98c44b1336e800c205 I suspect this CL: DialogClientView handles dialog content margins. https://chromium.googlesource.com/chromium/src/+/70ef329f8cf6cdc5cb663fa704dd66580c2f538b Bumping to P1 because this is a user-visible regression. If the fix is simple we should probably backport. bsep, can you take a look?
,
Sep 18 2017
Ah, yeah I think I know what the problem is.
,
Sep 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b01f8608cca6ff3f3fe354e330b7b64c8f1c20b8 commit b01f8608cca6ff3f3fe354e330b7b64c8f1c20b8 Author: Bret Sepulveda <bsep@chromium.org> Date: Tue Sep 19 00:48:11 2017 Fix the input mode bubble's margins being too large. This bubble was still passing margins to BubbleFrameView after that was handled by DialogClientView instead, which led to the margins being applied twice. Bug: 763137 Change-Id: Ifbdb5baa56cc6405b9434742602cdac6a9003f01 Reviewed-on: https://chromium-review.googlesource.com/671927 Reviewed-by: Jun Mukai <mukai@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#502735} [modify] https://crrev.com/b01f8608cca6ff3f3fe354e330b7b64c8f1c20b8/ui/chromeos/ime/mode_indicator_view.cc
,
Sep 19 2017
,
Oct 10 2017
Still able to repro issue. Build: 10009.0.0, 63.0.3230.0 eve
,
Nov 2 2017
Hmm... I can't repro the issue any more. Attached a screenshot of what I get on 64.0.3256.0, which looks correct to me. I checked and my patch is in 63.0.3230.0 so I don't know why you're still seeing it.
,
Nov 2 2017
Can't repro the issue on M63 latest build. We can close the bug. Thanks!
,
Nov 2 2017
,
Nov 2 2017
10032.21.0, 63.0.3239.26 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ovanieva@chromium.org
, Sep 15 2017