New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 763124 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Flake Analyzer - Swarming task timeouts are interpreted as non-existant tests.

Project Member Reported by wylieb@chromium.org, Sep 7 2017

Issue description

Looks like a problem in update_flake_analysis_data_points_pipeline

if tries > 0:
  assign pass rate
test not found

This code block should be improved a bit to support swarming errors as well.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/32c4e023183f3ec226dec71dfedffe598ecae4ae

commit 32c4e023183f3ec226dec71dfedffe598ecae4ae
Author: Brandon Wylie <wylieb@chromium.org>
Date: Fri Sep 08 01:00:01 2017

[Findit] Flake Analyzer - Ignore data point if swarming task error occured

Swarming task errors are being interpreted as not existent tests. If a
error occurs, we shouldn't add it to the analysis.

Bug:763124
Change-Id: I9fbde5a25492bc97dad2f9055d17096b8aa58f91
Reviewed-on: https://chromium-review.googlesource.com/656599
Reviewed-by: Jeffrey Li <lijeffrey@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>

[modify] https://crrev.com/32c4e023183f3ec226dec71dfedffe598ecae4ae/appengine/findit/waterfall/flake/update_flake_analysis_data_points_pipeline.py
[modify] https://crrev.com/32c4e023183f3ec226dec71dfedffe598ecae4ae/appengine/findit/waterfall/flake/test/update_flake_analysis_data_points_pipeline_test.py

Comment 2 by wylieb@chromium.org, Sep 11 2017

Status: Verified (was: Untriaged)

Sign in to add a comment