New issue
Advanced search Search tips

Issue 763083 link

Starred by 1 user

Issue metadata

Status: Fixed
Merged: issue 763079
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Chrome
Pri: 3
Type: Task


Show other hotlists

Hotlists containing this issue:
Payment-Conversion


Sign in to add a comment

PR editor is different from the autofill one

Project Member Reported by parastoog@chromium.org, Sep 7 2017

Issue description

We should reuse PR address editor and card editor for the autofill.
 
Mergedinto: 763079
Status: Duplicate (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06e0befee6341ca2099a79768eb21bf1c0fd25bd

commit 06e0befee6341ca2099a79768eb21bf1c0fd25bd
Author: Parastoo Geranmayeh <parastoog@google.com>
Date: Fri Oct 20 22:07:36 2017

Merge PR and Autofill address editors

-- on Android.

-- Use the payment request address editor code for the autofill, 
   and remove the redundant code.

-- The autofill address editor has an email field, whereas the
payment one doesn't. Change the address editor accordingly.

-- One cannot delete a payment profile, but can delete an autofill one,
change the editor dialog accordingly.

-- In AddressEditor, if there is no country saved for a profile,
we should use the default country.

-- Add tests for the AutofillProfilesFragment.

Bug:  763083 
Change-Id: I3d9c76f88485b8f93269637dc17e59e6b8dab3e8
Reviewed-on: https://chromium-review.googlesource.com/648191
Commit-Queue: Parastoo Geranmayeh <parastoog@google.com>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510577}
[delete] https://crrev.com/bf96f3100128419fb1dece60708d1c30b3ea9315/chrome/android/java/res/layout/autofill_profile_editor.xml
[delete] https://crrev.com/bf96f3100128419fb1dece60708d1c30b3ea9315/chrome/android/java/res/layout/preference_address_float_label_layout.xml
[modify] https://crrev.com/06e0befee6341ca2099a79768eb21bf1c0fd25bd/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java
[modify] https://crrev.com/06e0befee6341ca2099a79768eb21bf1c0fd25bd/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/06e0befee6341ca2099a79768eb21bf1c0fd25bd/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDialog.java
[modify] https://crrev.com/06e0befee6341ca2099a79768eb21bf1c0fd25bd/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java
[add] https://crrev.com/06e0befee6341ca2099a79768eb21bf1c0fd25bd/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorObserverForTest.java
[modify] https://crrev.com/06e0befee6341ca2099a79768eb21bf1c0fd25bd/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorTextField.java
[modify] https://crrev.com/06e0befee6341ca2099a79768eb21bf1c0fd25bd/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
[delete] https://crrev.com/bf96f3100128419fb1dece60708d1c30b3ea9315/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileEditor.java
[add] https://crrev.com/06e0befee6341ca2099a79768eb21bf1c0fd25bd/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileEditorPreference.java
[modify] https://crrev.com/06e0befee6341ca2099a79768eb21bf1c0fd25bd/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java
[modify] https://crrev.com/06e0befee6341ca2099a79768eb21bf1c0fd25bd/chrome/android/java_sources.gni
[modify] https://crrev.com/06e0befee6341ca2099a79768eb21bf1c0fd25bd/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestCommon.java
[modify] https://crrev.com/06e0befee6341ca2099a79768eb21bf1c0fd25bd/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestRule.java
[add] https://crrev.com/06e0befee6341ca2099a79768eb21bf1c0fd25bd/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragmentTest.java
[add] https://crrev.com/06e0befee6341ca2099a79768eb21bf1c0fd25bd/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/autofill/AutofillTestRule.java

Cc: parastoog@chromium.org
 Issue 763079  has been merged into this issue.
Status: Started (was: Duplicate)
Fixed?
Cc: -parastoog@chromium.org
Status: Fixed (was: Started)

Sign in to add a comment