New issue
Advanced search Search tips

Issue 763065 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

blink_perf.owp_storage failing on 7 builders

Project Member Reported by nedngu...@google.com, Sep 7 2017

Issue description

blink_perf.owp_storage failing on 7 builders

Builders failed on: 
- Android Nexus7v2 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf
- Linux Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf
- Win 10 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%2010%20Perf
- Win 7 ATI GPU Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%207%20ATI%20GPU%20Perf
- Win 7 Intel GPU Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%207%20Intel%20GPU%20Perf
- Win 7 x64 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%207%20x64%20Perf
- Win 8 Perf: 
  https://build.chromium.org/p/chromium.perf/builders/Win%208%20Perf


It's blink_perf.owp_storage/blob-build-all-then-read-parallel.html test that is failing everywhere.

Traceback (most recent call last):
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 105, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 333, in RunStory
    self._current_page, self._current_tab, results)
  File "/b/s/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/s/w/ir/tools/perf/benchmarks/blink_perf.py", line 311, in ValidateAndMeasurePage
    model, renderer_thread, trace_events_to_measure)
  File "/b/s/w/ir/tools/perf/benchmarks/blink_perf.py", line 211, in _ComputeTraceEventsThreadTimeForBlinkPerf
    intersect_wall_time * b.thread_or_wall_duration / b.bounds.bounds)
ZeroDivisionError: float division by zero
 
Cc: nedngu...@google.com dmu...@chromium.org
ah crazy! so it's so fast that the bounds are 0? I can try to fix this. Ccing ned.
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/af82d856b2cf6e849b67d6a6799d724ede557c7b

commit af82d856b2cf6e849b67d6a6799d724ede557c7b
Author: Daniel Murphy <dmurph@chromium.org>
Date: Thu Sep 07 23:42:10 2017

[BlinkPerf] Fixing DivByZero in trace event collapse code

R: nednguyen@google.com
Bug:  763065 
Change-Id: I9b7729597575a8242f7f893107defa6239280af9
Reviewed-on: https://chromium-review.googlesource.com/656144
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#500436}
[modify] https://crrev.com/af82d856b2cf6e849b67d6a6799d724ede557c7b/tools/perf/benchmarks/blink_perf.py

Status: Fixed (was: Assigned)

Sign in to add a comment