New issue
Advanced search Search tips

Issue 763032 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Sep 2017
Cc:
klausw@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature
Proj-XR



Sign in to add a comment

VR: Wait until Chrome is *actually* visible before starting WebVR rendering.

Project Member Reported by mthiesse@chromium.org, Sep 7 2017 
Despite what the Android lifecycle states, we're probably not actually visible when onResume is called. The real signal that we're visible is Activity#OnWindowFocusChanged. At least on debug builds, this leads to a few hundred milliseconds of webVR rendering before we're actually visible, so if we stop doing that we'll probably start up and become visible faster.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7877850aacaead4be004d301b876ac556a48a7ab

commit 7877850aacaead4be004d301b876ac556a48a7ab
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Thu Sep 07 23:13:42 2017

VR: Don't start rendering until the activity is visible.

This makes starting VR after the DON flow ~150ms faster on release
builds because we're not doing a bunch of work drawing frames that won't
be visible. This 150ms savings is measured in the time between onResume
and OnWindowFocusChanged, which dropped from ~250ms to ~100ms on a Pixel
XL.

Bug:  763032 ,  741823 
Change-Id: Ia915a46c72c27cfe838e0d6b8d0336c566d6f413
Reviewed-on: https://chromium-review.googlesource.com/655774
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500426}
[modify] https://crrev.com/7877850aacaead4be004d301b876ac556a48a7ab/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/7877850aacaead4be004d301b876ac556a48a7ab/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/7877850aacaead4be004d301b876ac556a48a7ab/chrome/browser/android/vr_shell/vr_shell_gl.cc
[modify] https://crrev.com/7877850aacaead4be004d301b876ac556a48a7ab/chrome/browser/android/vr_shell/vr_shell_gl.h

Comment 2 by mthiesse@chromium.org, Sep 8 2017

Status: Fixed (was: Available)

Comment 3 by btebbs@chromium.org, Jul 4

Components: Blink>WebXR
►

Sign in to add a comment