New issue
Advanced search Search tips

Issue 763005 link

Starred by 1 user
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Sep 2017
Cc:
seanmccullough@chromium.org
zhangtiff@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Change builders list in webkitpy from Python constant to JSON file

Project Member Reported by qyears...@chromium.org, Sep 7 2017 
Background: SoM also uses the same builders list, but currently has the list duplicated (https://chromium-review.googlesource.com/c/infra/infra/+/617609). After changing the list to JSON, it will be easier to change SoM to fetch and use the same list.

Specifically, what needs to be done here is:
 - Replace webkitpy/common/config/builders.json with webkitpy/common/config/builders.json.
 - Update tests which use the real builders list. Unit tests should probably use a smaller fake list.

Comment 1 by seanmccullough@chromium.org, Sep 8 2017

Labels: Milestone-Workflow
Owner: seanmccullough@chromium.org

Comment 2 by seanmccullough@chromium.org, Sep 8 2017

Status: Assigned (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3449467c5db13b3219808824d55c6c993bae78b

commit a3449467c5db13b3219808824d55c6c993bae78b
Author: Quinten Yearsley <qyearsley@chromium.org>
Date: Sat Sep 09 22:50:19 2017

Store builders as JSON instead of Python constant

Bug:  763005 
Change-Id: I3385cae4f96069a22e7db5d99eefeaade84efbb9
Reviewed-on: https://chromium-review.googlesource.com/655639
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500804}
[add] https://crrev.com/a3449467c5db13b3219808824d55c6c993bae78b/third_party/WebKit/Tools/Scripts/webkitpy/common/config/builders.json
[delete] https://crrev.com/975794ee43d7036fb94be988a9f6751db85c7a3a/third_party/WebKit/Tools/Scripts/webkitpy/common/config/builders.py
[modify] https://crrev.com/a3449467c5db13b3219808824d55c6c993bae78b/third_party/WebKit/Tools/Scripts/webkitpy/common/host.py
[modify] https://crrev.com/a3449467c5db13b3219808824d55c6c993bae78b/third_party/WebKit/Tools/Scripts/webkitpy/common/host_mock.py
[modify] https://crrev.com/a3449467c5db13b3219808824d55c6c993bae78b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/builder_list.py
[modify] https://crrev.com/a3449467c5db13b3219808824d55c6c993bae78b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/layout_package/bot_test_expectations_unittest.py
[modify] https://crrev.com/a3449467c5db13b3219808824d55c6c993bae78b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory_unittest.py
[modify] https://crrev.com/a3449467c5db13b3219808824d55c6c993bae78b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_flaky_expectations.py
[modify] https://crrev.com/a3449467c5db13b3219808824d55c6c993bae78b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/update_flaky_expectations_unittest.py

Comment 4 by qyears...@chromium.org, Sep 25 2017

Cc: -qyears...@chromium.org seanmccullough@chromium.org
Owner: qyears...@chromium.org
Status: Fixed (was: Assigned)
►

Sign in to add a comment