'fastboot' container not found |
|||||||
Issue descriptionChrome Version : 62.0.3202.8 OS Version: 9901.5.0 dev-channel samus From crosh with adb/fastboot extension installed c adb works c fastboot returns: Could not find container
,
Sep 7 2017
,
Sep 7 2017
Looks like there are six container.json entries in the extension file:
[15:39 sfo] x86-64 $ find . -name container.json | xargs tail -n +1
==> ./adb-dev/container.json <==
{
"manifest-version": 1,
"name": "adb-dev",
"version": "5.1.1"
}
==> ./fastboot.dev/container.json <==
{
"manifest-version": 1,
"name": "fastboot",
"version": "5.1.1"
}
==> ./fastboot/container.json <==
{
"manifest-version": 1,
"name": "fastboot",
"version": "5.1.1"
}
==> ./fastboot-dev/container.json <==
{
"manifest-version": 1,
"name": "fastboot-dev",
"version": "5.1.1"
}
==> ./adb/container.json <==
{
"manifest-version": 1,
"name": "adb",
"version": "5.1.1"
}
==> ./adb.dev/container.json <==
{
"manifest-version": 1,
"name": "adb-dev",
"version": "5.1.1"
}
adb is only named once, but fastboot is named twice. Looks like mount_extension_image finds fastboot.dev first, which fails signature verification when imageloader tries to load it. I assume this is because fastboot.dev is signed with dev keys so we still load something in dev mode but if this machine is in normal mode then that's not going to work.
Seems like the fix is to change the name in the fastboot.dev/container.json file and update the extension on the web store.
,
Sep 13 2017
Is there a work stream that will fix this bug?
,
Sep 13 2017
I'm not sure what you mean by that. https://chromium-review.googlesource.com/c/chromiumos/platform2/+/663835 is up and should fix the issue for this extension but probably in the future we are going to want to rejigger the naming on these containers so they operate the same way no matter which keys the images are signed with.
,
Sep 13 2017
i've published an updated extension that deletes the adb.dev and fastboot.dev folders. upgrade to 0.5.1.6 and see if that works better. Eric is also landing a CL to make this smoother in general by searching all matches.
,
Sep 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/2988f535b6db1534fe5464b72348fbf6a20a9b0b commit 2988f535b6db1534fe5464b72348fbf6a20a9b0b Author: Eric Caruso <ejcaruso@chromium.org> Date: Fri Sep 15 01:01:50 2017 container_utils: try multiple containers with the same name If there are multiple containers with the same name in the extension and we fail to load the first one, we don't try the others at all. This impedes our ability to supply extensions that contain both dev- and prod-signed containers. BUG= chromium:762996 TEST=load adb, fastboot, vont Change-Id: I2df6b2a4e1511cffdef296bc8a5f8a91d46e2499 Reviewed-on: https://chromium-review.googlesource.com/663835 Commit-Ready: Eric Caruso <ejcaruso@chromium.org> Tested-by: Eric Caruso <ejcaruso@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org> [modify] https://crrev.com/2988f535b6db1534fe5464b72348fbf6a20a9b0b/container_utils/mount_extension_image.cc
,
Jan 22 2018
,
Jan 23 2018
,
May 9 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by dgreid@chromium.org
, Sep 7 2017