New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762996 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

'fastboot' container not found

Project Member Reported by dgreid@chromium.org, Sep 7 2017

Issue description

Chrome Version       : 62.0.3202.8
OS Version: 9901.5.0 dev-channel samus

From crosh with adb/fastboot extension installed

c adb works

c fastboot 

returns:

Could not find container
 
ejcaruso, can you take a first pass and make sure everything looks mounted correctly?
Cc: -vapier@google.com vapier@chromium.org
Cc: -vapier@chromium.org ejcaruso@chromium.org
Owner: vapier@chromium.org
Looks like there are six container.json entries in the extension file:

[15:39 sfo] x86-64 $ find . -name container.json | xargs tail -n +1 
==> ./adb-dev/container.json <==
{
"manifest-version": 1,
"name": "adb-dev",
"version": "5.1.1"
}

==> ./fastboot.dev/container.json <==
{
"manifest-version": 1,
"name": "fastboot",
"version": "5.1.1"
}

==> ./fastboot/container.json <==
{
"manifest-version": 1,
"name": "fastboot",
"version": "5.1.1"
}

==> ./fastboot-dev/container.json <==
{
"manifest-version": 1,
"name": "fastboot-dev",
"version": "5.1.1"
}

==> ./adb/container.json <==
{
"manifest-version": 1,
"name": "adb",
"version": "5.1.1"
}

==> ./adb.dev/container.json <==
{
"manifest-version": 1,
"name": "adb-dev",
"version": "5.1.1"
}

adb is only named once, but fastboot is named twice. Looks like mount_extension_image finds fastboot.dev first, which fails signature verification when imageloader tries to load it. I assume this is because fastboot.dev is signed with dev keys so we still load something in dev mode but if this machine is in normal mode then that's not going to work.

Seems like the fix is to change the name in the fastboot.dev/container.json file and update the extension on the web store.

Comment 5 by genek@google.com, Sep 13 2017

Is there a work stream that will fix this bug?
I'm not sure what you mean by that.

https://chromium-review.googlesource.com/c/chromiumos/platform2/+/663835 is up and should fix the issue for this extension but probably in the future we are going to want to rejigger the naming on these containers so they operate the same way no matter which keys the images are signed with.

Comment 7 by vapier@chromium.org, Sep 13 2017

Status: Fixed (was: Assigned)
i've published an updated extension that deletes the adb.dev and fastboot.dev folders.  upgrade to 0.5.1.6 and see if that works better.

Eric is also landing a CL to make this smoother in general by searching all matches.
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/2988f535b6db1534fe5464b72348fbf6a20a9b0b

commit 2988f535b6db1534fe5464b72348fbf6a20a9b0b
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Fri Sep 15 01:01:50 2017

container_utils: try multiple containers with the same name

If there are multiple containers with the same name in the
extension and we fail to load the first one, we don't try the
others at all. This impedes our ability to supply extensions
that contain both dev- and prod-signed containers.

BUG= chromium:762996 
TEST=load adb, fastboot, vont

Change-Id: I2df6b2a4e1511cffdef296bc8a5f8a91d46e2499
Reviewed-on: https://chromium-review.googlesource.com/663835
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/2988f535b6db1534fe5464b72348fbf6a20a9b0b/container_utils/mount_extension_image.cc

Comment 9 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 10 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
Components: OS>Systems>Containers

Sign in to add a comment