New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762995 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Investigate additional hit test rect generated for fullscreen video track.

Project Member Reported by flackr@chromium.org, Sep 7 2017

Issue description

In https://chromium-review.googlesource.com/c/chromium/src/+/630141 we changed the compositor-touch-hit-rects-fullscreen-video-controls-expected.txt as we are getting an additional rect for the playback track:

handler: #document (56, 600, 712, 8)

It seems like we shouldn't be seeing this as the touch action on the body (none) is more restrictive than the track (pan-y).
 
Status: WontFix (was: Assigned)
obsolete :)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3faf6057ca1237a94d2e9fa7805acc9520017b2

commit b3faf6057ca1237a94d2e9fa7805acc9520017b2
Author: Robert Flack <flackr@chromium.org>
Date: Thu Sep 07 21:43:45 2017

Re-add test expectations from original touch action patch.

The test expectations from I4d160d64e895e270403f3bd826ac41b8231e4709 had
to be reverted when I1c226a85ff133b9bf440925b238abf7810c9482a landed but
since it has been reverted we need to re-add these expectations from the
original CL.

BUG= 746872 , 762995 
NOTRY=true
TBR=xidachen@chromium.org,dtapuska@chromium.org

Change-Id: I2992c8e8ae4fce5a9b4d3b3bd0211e3de3681830
Reviewed-on: https://chromium-review.googlesource.com/656199
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500399}
[modify] https://crrev.com/b3faf6057ca1237a94d2e9fa7805acc9520017b2/third_party/WebKit/LayoutTests/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls-expected.txt
[add] https://crrev.com/b3faf6057ca1237a94d2e9fa7805acc9520017b2/third_party/WebKit/LayoutTests/platform/mac/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls-expected.txt

Sign in to add a comment