New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762991 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2017
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove iTunes support from the media_galleries API

Project Member Reported by jcivelli@chromium.org, Sep 7 2017

Issue description

The iTunes support in the media_galleries API has been broken on Windows for more than a year since iTunes changed the library format.
Since that code is not used much, we should remove it on Windows and Mac.
 
Summary: Remove iTunes support from the media_galleries API (was: Remove iTunes support from the media_galleries)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf99550c9df48abf9c6b32a062320a26bf1624cd

commit cf99550c9df48abf9c6b32a062320a26bf1624cd
Author: Jay Civelli <jcivelli@google.com>
Date: Fri Sep 08 23:59:27 2017

Removing iTunes support from media_gallery API.

Removing iTunes support from media_gallery API on Windows and Mac, as it is
not maintained and has been broken on Windows since iTunes changed its
configuration file locations more than a year ago.

Bug:  762991 , 758355 
Tbr: tsepez, bbudge
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_dbg_ng
Change-Id: I258659e5241f27f5ad2b0cc86ba8f902f77a32e7
Reviewed-on: https://chromium-review.googlesource.com/646801
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Michael Nordman <michaeln@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500748}
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/WATCHLISTS
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/build/check_gn_headers_whitelist.txt
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/BUILD.gn
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/iapps_data_provider.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/iapps_data_provider.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/iapps_finder.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/iapps_finder_impl.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/iapps_finder_impl.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/iapps_finder_impl_mac.mm
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/iapps_finder_impl_win.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/iapps_finder_impl_win_browsertest.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/itunes_data_provider.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/itunes_data_provider.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/itunes_data_provider_browsertest.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/itunes_file_util.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/itunes_file_util.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/itunes_file_util_unittest.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/media_galleries/fileapi/media_file_system_backend.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/media_galleries/fileapi/media_file_system_backend.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/safe_iapps_library_parser.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/safe_iapps_library_parser.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/safe_itunes_pref_parser_win.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/fileapi/safe_itunes_pref_parser_win.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/imported_media_gallery_registry.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/browser/media_galleries/imported_media_gallery_registry.h
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/media_galleries/media_file_system_registry.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/media_galleries/media_galleries_histograms.h
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/media_galleries/media_galleries_preferences.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/media_galleries/media_galleries_preferences.h
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/media_galleries/media_galleries_preferences_unittest.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/media_galleries/media_galleries_test_util.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/browser/media_galleries/media_galleries_test_util.h
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/common/BUILD.gn
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/common/common_message_generator.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/common/extensions/chrome_utility_extensions_messages.h
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/common/extensions/docs/templates/intros/mediaGalleries.html
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/common/media_galleries/itunes_library.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/common/media_galleries/itunes_library.h
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/test/BUILD.gn
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/utility/BUILD.gn
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/utility/chrome_content_utility_client.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/utility/extensions/extensions_handler.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/chrome/utility/extensions/extensions_handler.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/utility/media_galleries/iapps_xml_utils.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/utility/media_galleries/iapps_xml_utils.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/utility/media_galleries/itunes_library_parser.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/utility/media_galleries/itunes_library_parser.h
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/utility/media_galleries/itunes_library_parser_unittest.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/utility/media_galleries/itunes_pref_parser_win.cc
[delete] https://crrev.com/2e554fa6cf64bfd3b2ee6d9813652ad4013a567c/chrome/utility/media_galleries/itunes_pref_parser_win.h
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/components/storage_monitor/media_storage_util.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/components/storage_monitor/storage_info.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/components/storage_monitor/storage_info.h
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/content/browser/renderer_host/pepper/pepper_file_io_host.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/storage/browser/fileapi/file_system_context.cc
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/storage/common/fileapi/file_system_types.h
[modify] https://crrev.com/cf99550c9df48abf9c6b32a062320a26bf1624cd/storage/common/fileapi/file_system_util.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment