New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 762982 link

Starred by 1 user
Status: Fixed
Owner:
dgozman@chromium.org
Closed: Oct 2017
Cc:
█ kozyatinskiy@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

[DevTools] simplify tracking scriptIds VS urls

Project Member Reported by kozyatinskiy@chromium.org, Sep 7 2017 
As first step we need to add missing urls into protocol.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d63594b684d7e65504b041fc70ddee85544a1058

commit d63594b684d7e65504b041fc70ddee85544a1058
Author: Alexey Kozyatinskiy <kozyatinskiy@chromium.org>
Date: Thu Sep 07 16:39:31 2017

[inspector] added url to Debugger.CallFrame

Runtime.CallFrame has url already. It allows to show stack traces on pause
without tacking all parsed scripts.

R=alph@chromium.org,pfeldman@chromium.org

Bug:  chromium:762982 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic4f096ade1cb6c9de42fec77280dcc3007c6a5cf
Reviewed-on: https://chromium-review.googlesource.com/648068
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#47895}
[modify] https://crrev.com/d63594b684d7e65504b041fc70ddee85544a1058/src/inspector/js_protocol.json
[modify] https://crrev.com/d63594b684d7e65504b041fc70ddee85544a1058/src/inspector/v8-debugger-agent-impl.cc
[add] https://crrev.com/d63594b684d7e65504b041fc70ddee85544a1058/test/inspector/debugger/call-frame-url-expected.txt
[add] https://crrev.com/d63594b684d7e65504b041fc70ddee85544a1058/test/inspector/debugger/call-frame-url.js
[modify] https://crrev.com/d63594b684d7e65504b041fc70ddee85544a1058/test/inspector/runtime/es6-module-expected.txt

Comment 2 by dgozman@chromium.org, Oct 4 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment