Issue metadata
Sign in to add a comment
|
Positioned inline element breaks css overflow property
Reported by
jsimo...@onshape.com,
Sep 7 2017
|
||||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/61.0.3163.79 Safari/537.36 Steps to reproduce the problem: 1. open https://codepen.io/jexordexan/pen/rzEVBR?editors=1100 2. notice the entire line of text is visible 3. comment or remove line 9 in the CSS 4. notice the text is now truncated correctly What is the expected behavior? The text should truncate whether the '.icon' element is positioned or not. What went wrong? The 2px adjustment to a positioned element broke the overflow rules for the parent div. Notice in the attached image that this is working properly in Firefox and Safari, and in older versions of Chrome (60 and below). Did this work before? Yes 60 Does this work in other browsers? Yes Chrome version: 61.0.3163.79 Channel: stable OS Version: OS X 10.12.5 Flash Version: Shockwave Flash 26.0 r0
,
Sep 7 2017
Able to reproduce the issue on Windows 7,10, Mac and Linux and below is he bisect result : You are probably looking for a change made after 486503 (known good), but no lat er than 486504 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/b694253de687440c5e180ffef488f5e1b6a6eee3..74bd1c084916b057eb7936bf9871721eb0e61fa3
,
Sep 7 2017
Based on clues in the changelog url, I have fixed the bug temporarily by positioning BOTH the icon and the label. This bug seems to only be present when static and relative inline elements are mixed.
,
Sep 7 2017
This is reproducible on latest Chrome Dev(62.0.3202.9) and Canary(63.0.3208.0), hence any CL which fixes this issue should get merged to M62 and M63.
,
Sep 7 2017
,
Sep 7 2017
M61-We can repro in Android side also
,
Sep 7 2017
,
Sep 7 2017
,
Sep 7 2017
,
Sep 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/04dcd8d58c19de98e9404f30d8106143484af9ed commit 04dcd8d58c19de98e9404f30d8106143484af9ed Author: Robert Hogan <robhogan@gmail.com> Date: Mon Sep 11 18:58:19 2017 Calculate overflow correctly for ellipses in presence of relative elements If overflow is present we use it to decide if a linebox needs ellipsis - so when adding overflow ensure we unite it with the root linebox rect, any relative offset will then get applied ensuring that the overflow rect represents the extent of the linebox plus overflow. Bug: 762978 Change-Id: I44df439cdf0f190d08d5fad587571f7298843328 Reviewed-on: https://chromium-review.googlesource.com/659077 Reviewed-by: Emil A Eklund <eae@chromium.org> Commit-Queue: Robert Hogan <robhogan@gmail.com> Cr-Commit-Position: refs/heads/master@{#500988} [add] https://crrev.com/04dcd8d58c19de98e9404f30d8106143484af9ed/third_party/WebKit/LayoutTests/fast/text/ellipsis-in-relative-inline-2-expected.html [add] https://crrev.com/04dcd8d58c19de98e9404f30d8106143484af9ed/third_party/WebKit/LayoutTests/fast/text/ellipsis-in-relative-inline-2.html [modify] https://crrev.com/04dcd8d58c19de98e9404f30d8106143484af9ed/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by jsimo...@onshape.com
, Sep 7 2017630 KB
630 KB View Download