+Theresa who has worked on the history page

+huayinz@ who has been making updates to the history page and privacy disclaimers.

Is there a spec for what this should look like in the signed-out, signed-in, and signed-in and synced states?

We should remove the notice in question in all states. Note that we shouldn't touch the other notice that's shown in certain states ("Your Google Account may have other forms of browsing history at history.google.com").

Is that sufficient in terms of a spec, or am I glossing over some complexities that I'm unaware of? :)

Also +Sky

I think that's sufficient, thanks!

Is there a target milestone for removal?

No target milestone, just whenever we have time to do it.

Note that we should remove it from all platforms (Desktop, Android, iOS). twellington/huayinz - can you handle this on Android?

Yes, we can. I filed issue 763536 to track the Android work.

After all platforms have had the message removed, we should clean up signature of BrowsingHistoryDriver::ShouldShowNoticeAboutOtherFormsOfBrowsingHistory() and remove BrowsingHistoryService::QueryResultsInfo::has_synced_results.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c404172705fb41940274e3a984af52fa4d39b9de

commit c404172705fb41940274e3a984af52fa4d39b9de
Author: Sky Malice <skym@chromium.org>
Date: Tue Oct 03 17:34:15 2017

Delete showing synced history notification on desktop.

Bug:  762974 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id660082209b84347cd0618485ab8cb2799f676cb
Reviewed-on: https://chromium-review.googlesource.com/691211
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506089}
[modify] https://crrev.com/c404172705fb41940274e3a984af52fa4d39b9de/chrome/app/generated_resources.grd
[modify] https://crrev.com/c404172705fb41940274e3a984af52fa4d39b9de/chrome/browser/resources/md_history/app.html
[modify] https://crrev.com/c404172705fb41940274e3a984af52fa4d39b9de/chrome/browser/resources/md_history/app.js
[modify] https://crrev.com/c404172705fb41940274e3a984af52fa4d39b9de/chrome/browser/resources/md_history/externs.js
[modify] https://crrev.com/c404172705fb41940274e3a984af52fa4d39b9de/chrome/browser/resources/md_history/history.js
[modify] https://crrev.com/c404172705fb41940274e3a984af52fa4d39b9de/chrome/browser/resources/md_history/history_toolbar.html
[modify] https://crrev.com/c404172705fb41940274e3a984af52fa4d39b9de/chrome/browser/resources/md_history/history_toolbar.js
[modify] https://crrev.com/c404172705fb41940274e3a984af52fa4d39b9de/chrome/browser/resources/md_history/icons.html
[modify] https://crrev.com/c404172705fb41940274e3a984af52fa4d39b9de/chrome/browser/ui/webui/browsing_history_handler.cc
[modify] https://crrev.com/c404172705fb41940274e3a984af52fa4d39b9de/chrome/browser/ui/webui/md_history_ui.cc
[modify] https://crrev.com/c404172705fb41940274e3a984af52fa4d39b9de/chrome/test/data/webui/md_history/history_toolbar_test.js
[modify] https://crrev.com/c404172705fb41940274e3a984af52fa4d39b9de/chrome/test/data/webui/md_history/test_util.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d6559120982e84a24b5eb67382c6463b839035e

commit 4d6559120982e84a24b5eb67382c6463b839035e
Author: Sky Malice <skym@chromium.org>
Date: Tue Oct 03 19:05:45 2017

Delete showing synced history notification on iOS.

Bug:  762974 
Change-Id: Iab4a94e3714c0da72042001f3437438c6a97dea3
Reviewed-on: https://chromium-review.googlesource.com/695934
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506131}
[modify] https://crrev.com/4d6559120982e84a24b5eb67382c6463b839035e/ios/chrome/app/strings/ios_strings.grd
[modify] https://crrev.com/4d6559120982e84a24b5eb67382c6463b839035e/ios/chrome/browser/ui/history/history_collection_view_controller.h
[modify] https://crrev.com/4d6559120982e84a24b5eb67382c6463b839035e/ios/chrome/browser/ui/history/history_collection_view_controller.mm
[modify] https://crrev.com/4d6559120982e84a24b5eb67382c6463b839035e/ios/chrome/browser/ui/history/history_collection_view_controller_unittest.mm
[modify] https://crrev.com/4d6559120982e84a24b5eb67382c6463b839035e/ios/chrome/browser/ui/history/history_entries_status_item.h
[modify] https://crrev.com/4d6559120982e84a24b5eb67382c6463b839035e/ios/chrome/browser/ui/history/history_entries_status_item.mm
[modify] https://crrev.com/4d6559120982e84a24b5eb67382c6463b839035e/ios/chrome/browser/ui/history/history_entries_status_item_unittest.mm
[modify] https://crrev.com/4d6559120982e84a24b5eb67382c6463b839035e/ios/chrome/browser/ui/history/history_panel_view_controller.mm
[modify] https://crrev.com/4d6559120982e84a24b5eb67382c6463b839035e/ios/chrome/browser/ui/history/history_ui_egtest.mm

Awesome, thanks Sky! Can we mark this as Fixed?

+Kingston as FYI

All the user facing parts of this are completed. but the code cleanup I mentiond in comment #9 is not done. I'd prefer to leave this open to track the cleanup.

While cleanup would be nice, the thrust of this has been done. Closing.