Fix tests in form_structure_browsertest.mm |
||
Issue descriptionAs of 07/09/17, 31 tests in form_structure_browsertest.mm are failing. This is an umbrella bug about fixing them.
,
Oct 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3edd34a42000f33f0d3d82e0398b70be1d05b6b7 commit 3edd34a42000f33f0d3d82e0398b70be1d05b6b7 Author: Olivier Robin <olivierrobin@chromium.org> Date: Thu Oct 19 15:48:03 2017 Implement IsLabelValid IsLabelValid checks if an inferred label is valid or not. A valid label does not contain only special characters. Special characters are " *:-()\u2013" as defined in FormOrFieldsetsToFormData in form_autofill_util.cc. Bug: 762970 Change-Id: Id44b9efc2500de638c54336ac589c68127d33be9 Reviewed-on: https://chromium-review.googlesource.com/722699 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#510097} [modify] https://crrev.com/3edd34a42000f33f0d3d82e0398b70be1d05b6b7/components/autofill/ios/browser/resources/autofill_controller.js [modify] https://crrev.com/3edd34a42000f33f0d3d82e0398b70be1d05b6b7/ios/chrome/browser/autofill/form_structure_browsertest.mm
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b65d478ac0049cdf8f707c7c64a9341a4216c040 commit b65d478ac0049cdf8f707c7c64a9341a4216c040 Author: Olivier Robin <olivierrobin@chromium.org> Date: Fri Oct 20 08:33:31 2017 Fix autofill browser tests for select elements Bug: 762970 Change-Id: Ifc0ce9b537a44539bc129879e2411fc031762047 Reviewed-on: https://chromium-review.googlesource.com/723463 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#510379} [modify] https://crrev.com/b65d478ac0049cdf8f707c7c64a9341a4216c040/components/autofill/ios/browser/resources/autofill_controller.js [modify] https://crrev.com/b65d478ac0049cdf8f707c7c64a9341a4216c040/ios/chrome/browser/autofill/form_structure_browsertest.mm
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eabcf30144a142417248cb12d404d5fc390e7b69 commit eabcf30144a142417248cb12d404d5fc390e7b69 Author: Olivier Robin <olivierrobin@chromium.org> Date: Fri Oct 20 13:08:57 2017 Add is_formless_checkout field Formless checkout is triggered when a page title or URL has one of the keywords 'payment', 'checkout', 'address', 'delivery', 'shipping', 'wallet' Fields that are not in a form and not in a checkout page are not considered by autofill if they have an autocomplete='off' attribute. Bug: 762970 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0f6ee839a015df5814bf4c63269f14889e7e9e64 Reviewed-on: https://chromium-review.googlesource.com/723281 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#510416} [modify] https://crrev.com/eabcf30144a142417248cb12d404d5fc390e7b69/components/autofill/ios/browser/autofill_agent.mm [modify] https://crrev.com/eabcf30144a142417248cb12d404d5fc390e7b69/components/autofill/ios/browser/resources/autofill_controller.js [modify] https://crrev.com/eabcf30144a142417248cb12d404d5fc390e7b69/ios/chrome/browser/autofill/form_structure_browsertest.mm
,
Oct 24 2017
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/56002de475823b87fdd0d2b19d9045d3d5d7a4bd commit 56002de475823b87fdd0d2b19d9045d3d5d7a4bd Author: Olivier Robin <olivierrobin@chromium.org> Date: Tue Oct 24 13:22:53 2017 Remove autofill FailingTestData All tests pass, remove the FailingTestData. Bug: 762970 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: If5ab2d77435f2109166024ac8a5e1b69c9e97f48 Reviewed-on: https://chromium-review.googlesource.com/723469 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Roger McFarlane <rogerm@chromium.org> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by: Jean-François Geyelin <jif@chromium.org> Cr-Commit-Position: refs/heads/master@{#511129} [modify] https://crrev.com/56002de475823b87fdd0d2b19d9045d3d5d7a4bd/chrome/browser/autofill/form_structure_browsertest.cc [modify] https://crrev.com/56002de475823b87fdd0d2b19d9045d3d5d7a4bd/components/autofill/core/browser/autofill_merge_unittest.cc [modify] https://crrev.com/56002de475823b87fdd0d2b19d9045d3d5d7a4bd/components/autofill/core/browser/data_driven_test.cc [modify] https://crrev.com/56002de475823b87fdd0d2b19d9045d3d5d7a4bd/components/autofill/core/browser/data_driven_test.h [modify] https://crrev.com/56002de475823b87fdd0d2b19d9045d3d5d7a4bd/ios/chrome/browser/autofill/form_structure_browsertest.mm |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Oct 19 2017