New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762965 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Read from more log sources in feedbackPrivate.readLogSource()

Project Member Reported by sque@chromium.org, Sep 7 2017

Issue description

See b/65425658

ifconfig
lsusb 
lspci
EVENTLOG
UPDATE_ENGINE.LOG
powerd logs
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9639526f6c40201e5b40c50880d91efc04d85c49

commit 9639526f6c40201e5b40c50880d91efc04d85c49
Author: Simon Que <sque@chromium.org>
Date: Mon Sep 11 19:44:41 2017

feedback_private: Use aliases for SupportedSource enum types

The long namespace paths of SingleLogFileLogSource::SupportedSource and
SingleDebugDaemonLogSource::SupportedSource are hard to read. Create
aliases to make the switch block cases easier to read.

BUG= 762965 
R=afakhry@chromium.org

Change-Id: I100003d5f286f8b2ee71bc4555e6700b2c0404c3
Reviewed-on: https://chromium-review.googlesource.com/656099
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500997}
[modify] https://crrev.com/9639526f6c40201e5b40c50880d91efc04d85c49/chrome/browser/extensions/api/feedback_private/chrome_feedback_private_delegate.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d4abd65ed82d206552a14cac820a440dc9099e4

commit 8d4abd65ed82d206552a14cac820a440dc9099e4
Author: Simon Que <sque@chromium.org>
Date: Mon Sep 11 19:45:59 2017

Add more log files to SingleLogFileLogSource

- eventlog.txt
- update_engine.log
- power_manager.LATEST
- power_manager.PREVIOUS

BUG= 762965 
R=afakhry@chromium.org

Change-Id: I5a5eb22ba53dfee6ebbe0514608e6683a65970ba
Reviewed-on: https://chromium-review.googlesource.com/655957
Commit-Queue: Simon Que <sque@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#500998}
[modify] https://crrev.com/8d4abd65ed82d206552a14cac820a440dc9099e4/chrome/browser/chromeos/system_logs/single_log_file_log_source.cc
[modify] https://crrev.com/8d4abd65ed82d206552a14cac820a440dc9099e4/chrome/browser/chromeos/system_logs/single_log_file_log_source.h

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fd9a465bf9cdce61b18c0db009a2df71d3711ea

commit 8fd9a465bf9cdce61b18c0db009a2df71d3711ea
Author: Simon Que <sque@chromium.org>
Date: Mon Sep 11 20:07:37 2017

Add lspci and ifconfig to SingleDebugDaemonLogSource

BUG= 762965 
R=afakhry@chromium.org

Change-Id: I3e3e7ee3e77bdaf64947059a40014a9b7855fe8a
Reviewed-on: https://chromium-review.googlesource.com/655958
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501009}
[modify] https://crrev.com/8fd9a465bf9cdce61b18c0db009a2df71d3711ea/chrome/browser/chromeos/system_logs/single_debug_daemon_log_source.cc
[modify] https://crrev.com/8fd9a465bf9cdce61b18c0db009a2df71d3711ea/chrome/browser/chromeos/system_logs/single_debug_daemon_log_source.h

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9543219edf8628157ff8b1e8b1a3d81c93b508c2

commit 9543219edf8628157ff8b1e8b1a3d81c93b508c2
Author: Simon Que <sque@chromium.org>
Date: Tue Sep 12 01:45:50 2017

Add new log source types to feedbackPrivate.readLogSource()

- power manager logs
- update engine log
- event log
- lspci
- ifconfig

BUG= 762965 
R=afakhry@chromium.org

Change-Id: I1bde09bffa0727c7cbdbb3c3fff3692451783a3a
Reviewed-on: https://chromium-review.googlesource.com/656106
Commit-Queue: Simon Que <sque@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501145}
[modify] https://crrev.com/9543219edf8628157ff8b1e8b1a3d81c93b508c2/chrome/browser/extensions/api/feedback_private/chrome_feedback_private_delegate.cc
[modify] https://crrev.com/9543219edf8628157ff8b1e8b1a3d81c93b508c2/extensions/common/api/feedback_private.idl

Comment 5 by sque@chromium.org, Sep 12 2017

Labels: Merge-Request-62
Status: Fixed (was: Started)
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 13 2017

Labels: -Merge-Request-62 Hotlist-Merge-Approved Merge-Approved-62
Your change meets the bar and is auto-approved for M62. Please go ahead and merge the CL to branch 3202 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 14 2017

Labels: -merge-approved-62 merge-merged-3202
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa28cc8eb6650cb5cd867ad7bb0f6efe5fcde44b

commit fa28cc8eb6650cb5cd867ad7bb0f6efe5fcde44b
Author: Simon Que <sque@chromium.org>
Date: Thu Sep 14 17:19:36 2017

feedback_private: Use aliases for SupportedSource enum types

The long namespace paths of SingleLogFileLogSource::SupportedSource and
SingleDebugDaemonLogSource::SupportedSource are hard to read. Create
aliases to make the switch block cases easier to read.

BUG= 762965 
R=​afakhry@chromium.org

Change-Id: I100003d5f286f8b2ee71bc4555e6700b2c0404c3
Reviewed-on: https://chromium-review.googlesource.com/656099
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500997}(cherry picked from commit 9639526f6c40201e5b40c50880d91efc04d85c49)
Reviewed-on: https://chromium-review.googlesource.com/662379
Cr-Commit-Position: refs/branch-heads/3202@{#223}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/fa28cc8eb6650cb5cd867ad7bb0f6efe5fcde44b/chrome/browser/extensions/api/feedback_private/chrome_feedback_private_delegate.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/279b9c6f0b007772dce1df3bcdcca47c9c7f6df3

commit 279b9c6f0b007772dce1df3bcdcca47c9c7f6df3
Author: Simon Que <sque@chromium.org>
Date: Thu Sep 14 17:19:52 2017

Add more log files to SingleLogFileLogSource

- eventlog.txt
- update_engine.log
- power_manager.LATEST
- power_manager.PREVIOUS

BUG= 762965 
R=​afakhry@chromium.org

Change-Id: I5a5eb22ba53dfee6ebbe0514608e6683a65970ba
Reviewed-on: https://chromium-review.googlesource.com/655957
Commit-Queue: Simon Que <sque@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500998}(cherry picked from commit 8d4abd65ed82d206552a14cac820a440dc9099e4)
Reviewed-on: https://chromium-review.googlesource.com/665068
Cr-Commit-Position: refs/branch-heads/3202@{#224}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/279b9c6f0b007772dce1df3bcdcca47c9c7f6df3/chrome/browser/chromeos/system_logs/single_log_file_log_source.cc
[modify] https://crrev.com/279b9c6f0b007772dce1df3bcdcca47c9c7f6df3/chrome/browser/chromeos/system_logs/single_log_file_log_source.h

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a6cc8a1b3d365796eb2b1bd3ad086c80d19e06d

commit 4a6cc8a1b3d365796eb2b1bd3ad086c80d19e06d
Author: Simon Que <sque@chromium.org>
Date: Thu Sep 14 17:20:05 2017

Add lspci and ifconfig to SingleDebugDaemonLogSource

BUG= 762965 
R=​afakhry@chromium.org

Change-Id: I3e3e7ee3e77bdaf64947059a40014a9b7855fe8a
Reviewed-on: https://chromium-review.googlesource.com/655958
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501009}(cherry picked from commit 8fd9a465bf9cdce61b18c0db009a2df71d3711ea)
Reviewed-on: https://chromium-review.googlesource.com/664984
Cr-Commit-Position: refs/branch-heads/3202@{#225}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/4a6cc8a1b3d365796eb2b1bd3ad086c80d19e06d/chrome/browser/chromeos/system_logs/single_debug_daemon_log_source.cc
[modify] https://crrev.com/4a6cc8a1b3d365796eb2b1bd3ad086c80d19e06d/chrome/browser/chromeos/system_logs/single_debug_daemon_log_source.h

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/985e6dda480534e25057bb84350640ba3ca40846

commit 985e6dda480534e25057bb84350640ba3ca40846
Author: Simon Que <sque@chromium.org>
Date: Thu Sep 14 19:06:32 2017

[Merge to M-62] Add new log source types to feedbackPrivate.readLogSource()

- power manager logs
- update engine log
- event log
- lspci
- ifconfig

BUG= 762965 
TBR=​afakhry@chromium.org,tbarzic@chromium.org

Change-Id: I1bde09bffa0727c7cbdbb3c3fff3692451783a3a
Reviewed-on: https://chromium-review.googlesource.com/656106
Commit-Queue: Simon Que <sque@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#501145}(cherry picked from commit 9543219edf8628157ff8b1e8b1a3d81c93b508c2)
Reviewed-on: https://chromium-review.googlesource.com/667876
Reviewed-by: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#229}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/985e6dda480534e25057bb84350640ba3ca40846/chrome/browser/extensions/api/feedback_private/chrome_feedback_private_delegate.cc
[modify] https://crrev.com/985e6dda480534e25057bb84350640ba3ca40846/extensions/common/api/feedback_private.idl

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7edfc2602ab97174130354ff80368aa966598645

commit 7edfc2602ab97174130354ff80368aa966598645
Author: Simon Que <sque@chromium.org>
Date: Sat Sep 16 05:49:00 2017

[Merge to M62] Fix power manager log file paths used in feedbackPrivate API

They are powerd.LATEST and powerd.PREVIOUS, not power_manager.*

BUG= 762965 
TBR=afakhry@chromium.org,tbarzic@chromium.org

Change-Id: I353c9444afc8c9dd7514b9127ee0eeef9a999fda
Reviewed-on: https://chromium-review.googlesource.com/668701
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#502491}(cherry picked from commit 8af8704ae2274bb3ef9443bd499193959d508a03)
Reviewed-on: https://chromium-review.googlesource.com/669807
Reviewed-by: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#274}
Cr-Branched-From: fa6a5d87adff761bc16afc5498c3f5944c1daa68-refs/heads/master@{#499098}
[modify] https://crrev.com/7edfc2602ab97174130354ff80368aa966598645/chrome/browser/chromeos/system_logs/single_log_file_log_source.cc
[modify] https://crrev.com/7edfc2602ab97174130354ff80368aa966598645/chrome/browser/chromeos/system_logs/single_log_file_log_source.h
[modify] https://crrev.com/7edfc2602ab97174130354ff80368aa966598645/chrome/browser/extensions/api/feedback_private/chrome_feedback_private_delegate.cc
[modify] https://crrev.com/7edfc2602ab97174130354ff80368aa966598645/extensions/common/api/feedback_private.idl

Comment 13 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 14 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment