Issue metadata
Sign in to add a comment
|
Regression:Unable to drag any tab out from original window on touch device.
Reported by
vku...@etouch.net,
Sep 7 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version:63.0.3208.0 5bfe3ad1decdfd840726e31694347e6d973a3f09-refs/heads/master@{#500160}(32/64 bit). OS:Windows 10(Touch device) What steps will reproduce the problem? (1)Launch chrome and open 3-4 tabs(webpages) (2)Try to drag any tab via tap/touch and observe. Actual: Unable to drag any tab out from original window. Expected: Should be able to drag any tab out from original window. This is a regression issue broken in 'M60' and below is the manual regression range: Good Build: 60.0.3111.0 Bad Build: 60.0.3112.0 CL: https://chromium.googlesource.com/chromium/src/+log/60.0.3111.0..60.0.3112.0?pretty=fuller&n=10000 (Unable to narrow down range as getting all good builds using per-revision bisect and old bisect script)
,
Sep 7 2017
My CL, for a non-OOPIF page, was just a refactor, and wouldn't even have access to the events that would involve moving a tab with touch. I suspect this is more likely related to varkha@'s change in https://codereview.chromium.org/2900423002 ?
,
Sep 7 2017
#2, that CL is not really a suspect since it only touched files in ash (Chrome OS) and this bug is referring to Windows-specific breakage. I will look if anything else in the bisect range can be responsible but I don't have easy access to Windows so I am probably not a good owner for this.
,
Sep 7 2017
2 interesting CLs that I spotted in that range are: [1] https://codereview.chromium.org/2899053007 and [2] https://chromium-review.googlesource.com/c/chromium/src/+/513505 I cannot see the bug there but at least they are possibilities in a sense that they change Browser UI code and also at least [1] is Windows-specific.
,
Sep 7 2017
Are we sure on the regression range? There have been a number of recent changes that may have effected touch generation.
,
Sep 7 2017
girard@ has a patch to restore touch events handling and that should fix that.
,
Sep 8 2017
Fixed with commit e976a3897d7a8abbbacce4c2622cc5ecf5a7b067 https://crrev.com/e976a3897d7a8abbbacce4c2622cc5ecf5a7b067 is only on trunk - hoping to merge it back into M61 soon. This is tracked in issue 762386 .
,
Sep 11 2017
Rechecked this issue on Windows 10 touch device using chrome version 63.0.3212.0 and fix is working as intended. Able to drag any tab out from original window. Adding TE-verified labels for M63 Please refer attached screencast |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by vku...@etouch.net
, Sep 7 2017Owner: wjmaclean@chromium.org
Status: Assigned (was: Unconfirmed)