New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762906 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Regression: [DevTools]Error message doesn't vanish automatically on Audit overlay.

Reported by dchau...@etouch.net, Sep 7 2017

Issue description

Chrome Version: 63.0.3208.0 5bfe3ad1decdfd840726e31694347e6d973a3f09-refs/heads/master@{#500160}(32/64 bit).
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3)

What steps will reproduce the problem?
1. Launch chrome, go to NTP, Open DevTools and click on 'Perform and audit' button under 'Audits' section.
2. Navigate to chrome://settings page in a same tab and observe (Error message is seen on 'Audit' to perform' overlay)
3. Now, Go to www.google.com or any HTTP/HTTPS page and observe 'Audit' to perform' overlay.

After step-3, Error message doesn't go away from 'Audit' to perform' overlay after navigating to any HTTP/HTTPS pages.
After step-3, Error message should go away from 'Audit' to perform' overlay after navigating to any HTTP/HTTPS pages.

Note: In expected Video, We are getting the error message on Audit overlay when opening 2 NTPs and the same error message automatically vanishes after closing the second NTP.

This is a regression issue,broken in M-63 series.

Using the per-revision bisect providing the bisect results,

Good Build: 63.0.3207.0(Revision:499830)
Bad Build: 63.0.3208.0(Revision:500160)

You are probably looking for a change made after 499992 (known good), but no later than 499993 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/bc726f37fe751557cef271e6a3276aea27f8344a..2b61d96e7ce66c12650fd9d7bf83fce4365636c9

Suspect: https://chromium.googlesource.com/chromium/src/+/2b61d96e7ce66c12650fd9d7bf83fce4365636c9

@phulce: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Kindly review the attached screen-cast for reference.
 
Actual behavior.mp4
1.3 MB View Download
Expected behavior.mp4
784 KB View Download
Labels: ReleaseBlock-Stable
762910: Regression:Unable to drag any tab out from original window on touch device.
Labels: -ReleaseBlock-Stable
This is actually a known pre-existing issue that is just being surfaced more frequently (you can try with about:blank in M62 to verify existing behavior).

Removing releaseblock-stable but still should be addressed.
Labels: -Type-Bug-Regression Type-Bug
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d92868cb835e3a37ff49db38e3e42afe110c411

commit 5d92868cb835e3a37ff49db38e3e42afe110c411
Author: Patrick Hulce <phulce@chromium.org>
Date: Tue Oct 03 02:10:17 2017

DevTools: Add tests for audits2 panel

* Introduces Audits2TestRunner and audits2 test folder.
* Adds test coverage for default flow, limited category flow, and
  unauditable page message help text.
* Fixes a bug where help text was not updated on URL change.

BUG= 762911 , 747357 , 762906 , 762897 

Change-Id: Ifa6475e344be28f8260a71e6a4a7b9eb9791b6c4
Reviewed-on: https://chromium-review.googlesource.com/661894
Commit-Queue: Patrick Hulce <phulce@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505924}
[modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/LayoutTests/SlowTests
[add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run-expected.txt
[add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run.js
[add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run-expected.txt
[add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run.js
[add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run-expected.txt
[add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run.js
[modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
[add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/audits2_test_runner/Audits2TestRunner.js
[add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/audits2_test_runner/module.json
[modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js
[modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js
[modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/integration_test_runner.json
[modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js
[modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/services/module.json

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a

commit ef8ea6202d4a01d4f05bff487a78e64e556b3e1a
Author: Kentaro Hara <haraken@chromium.org>
Date: Tue Oct 03 06:21:46 2017

Revert "DevTools: Add tests for audits2 panel"

This reverts commit 5d92868cb835e3a37ff49db38e3e42afe110c411.

Reason for revert: This broke virtual/mojo-loading/http/tests/devtools/audits2/audits2-successful-run.js on Win10.

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/26198

Original change's description:
> DevTools: Add tests for audits2 panel
> 
> * Introduces Audits2TestRunner and audits2 test folder.
> * Adds test coverage for default flow, limited category flow, and
>   unauditable page message help text.
> * Fixes a bug where help text was not updated on URL change.
> 
> BUG= 762911 , 747357 , 762906 , 762897 
> 
> Change-Id: Ifa6475e344be28f8260a71e6a4a7b9eb9791b6c4
> Reviewed-on: https://chromium-review.googlesource.com/661894
> Commit-Queue: Patrick Hulce <phulce@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505924}

TBR=dgozman@chromium.org,chenwilliam@chromium.org,phulce@chromium.org

Change-Id: I28b0a59682a5db00980462f97b56a345354d8998
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  762911 ,  747357 ,  762906 ,  762897 
Reviewed-on: https://chromium-review.googlesource.com/696805
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505967}
[modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/LayoutTests/SlowTests
[delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run-expected.txt
[delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run.js
[delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run-expected.txt
[delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run.js
[delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run-expected.txt
[delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run.js
[modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
[delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/Source/devtools/front_end/audits2_test_runner/Audits2TestRunner.js
[delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/Source/devtools/front_end/audits2_test_runner/module.json
[modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js
[modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/Source/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js
[modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/Source/devtools/front_end/integration_test_runner.json
[modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js
[modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/Source/devtools/front_end/services/module.json

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b995386e813c30ff327f7d3be81a85a62272a30

commit 9b995386e813c30ff327f7d3be81a85a62272a30
Author: Patrick Hulce <phulce@chromium.org>
Date: Thu Oct 05 01:23:39 2017

Reland "DevTools: Add tests for audits2 panel"

Win10 tests will be skipped for now.

This is a reland of 5d92868cb835e3a37ff49db38e3e42afe110c411
Original change's description:

> DevTools: Add tests for audits2 panel
> 
> * Introduces Audits2TestRunner and audits2 test folder.
> * Adds test coverage for default flow, limited category flow, and
>   unauditable page message help text.
> * Fixes a bug where help text was not updated on URL change.
> 
> BUG= 762911 , 747357 , 762906 , 762897 
> 
> Change-Id: Ifa6475e344be28f8260a71e6a4a7b9eb9791b6c4
> Reviewed-on: https://chromium-review.googlesource.com/661894
> Commit-Queue: Patrick Hulce <phulce@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505924}

Bug:  762911 ,  747357 ,  762906 ,  762897 
Change-Id: Iaf210e383e86fbfe0e31b372d8b87c461e8beecb
Reviewed-on: https://chromium-review.googlesource.com/701294
Reviewed-by: Will Chen <chenwilliam@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Patrick Hulce <phulce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506608}
[modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run-expected.txt
[add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run.js
[add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run-expected.txt
[add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run.js
[add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run-expected.txt
[add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run.js
[modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
[add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/audits2_test_runner/Audits2TestRunner.js
[add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/audits2_test_runner/module.json
[modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js
[modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js
[modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/integration_test_runner.json
[modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js
[modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/services/module.json

Comment 7 by phulce@chromium.org, Oct 10 2017

Status: Fixed (was: Assigned)

Sign in to add a comment