Media Controls: Re-enable gzip |
||
Issue descriptionGzipping of Media Controls CSS was temporarily disabled. Go back and turn it on.
,
Sep 29 2017
Also, is there a bigger effort to gzip more structures? Is the CSS already minified? What's the size impact?
,
Oct 2 2017
CSS resources were historically gzipped but in crrev.com/c/657024 we moved from an <include> to a <structure> to be able to embed images. The structure tag does not support compression so we temporarily disabled it. Now we would like to re-enable it. We have seen around a 53kb regression in resource sizes by not using gzip.
,
Oct 2 2017
Sounds like this is a one-off, but having compression support opens up the possibility of compressing other <structure> objects. Great!
,
Oct 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18e58e4ab2b8837fd40481ef3527c677bf4c95ef commit 18e58e4ab2b8837fd40481ef3527c677bf4c95ef Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Oct 03 10:07:30 2017 Media Controls: Enable Gzip of CSS resources. When we moved the CSS files to use "chrome_html" so we can embed images we had to remove gzip because Grit doesn't support the compress attribute on <structure> tags. This adds support for the compress attribute and re-enables gzip in the media controls. BUG= 762902 Change-Id: I304d4c28c800f4977aaa3d975c4a456722bf601e Reviewed-on: https://chromium-review.googlesource.com/692020 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#505996} [modify] https://crrev.com/18e58e4ab2b8837fd40481ef3527c677bf4c95ef/third_party/WebKit/Source/modules/media_controls/MediaControlsResourceLoader.cpp [modify] https://crrev.com/18e58e4ab2b8837fd40481ef3527c677bf4c95ef/third_party/WebKit/Source/modules/media_controls/resources/media_controls_resources.grd [modify] https://crrev.com/18e58e4ab2b8837fd40481ef3527c677bf4c95ef/tools/grit/grit/node/base.py [modify] https://crrev.com/18e58e4ab2b8837fd40481ef3527c677bf4c95ef/tools/grit/grit/node/include.py [modify] https://crrev.com/18e58e4ab2b8837fd40481ef3527c677bf4c95ef/tools/grit/grit/node/structure.py [modify] https://crrev.com/18e58e4ab2b8837fd40481ef3527c677bf4c95ef/tools/grit/grit/node/structure_unittest.py
,
Oct 3 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by thestig@chromium.org
, Sep 29 2017