New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 762897 link

Starred by 1 user
Status: Verified
Owner:
█ phulce@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary "Try Again" message displays on 'Audit to perform' overlay after clicking on 'Cancel' button.

Reported by db...@etouch.net, Sep 7 2017 
Chrome Version: 63.0.3208.0 5bfe3ad1decdfd840726e31694347e6d973a3f09-refs/heads/master@{#500160}(32/64 bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6,10.12.3)

What steps will reproduce the problem?
(1) Launch chrome, navigate to https://permission.site/ and open dev tools on it.
(2) Navigate to 'Audits' section, click on 'Perform an audit' then click on 'Run audit'.
(3) Click on Cancel button to cancelling audit and observe.

Actual: Unnecessary "Try Again" message displays on 'Audit to perform' overlay after clicking on Cancel button.

Expected: Try Again" message should not displays on 'Audit to perform' overlay after clicking on Cancel button .

This is Regression issue broken in 'M-63' and and will soon update other info,
Good Build: 63.0.3207.0
Bad Build: 63.0.3208.0

You are probably looking for a change made after 499992 (known good), but no later than 499993 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/bc726f37fe751557cef271e6a3276aea27f8344a..2b61d96e7ce66c12650fd9d7bf83fce4365636c9

Suspect: https://chromium.googlesource.com/chromium/src/+/2b61d96e7ce66c12650fd9d7bf83fce4365636c9
Actual_msg.mov
4.8 MB Download
Expected_Msg.mov
3.9 MB Download

Comment 1 by msrchandra@chromium.org, Sep 7 2017

Labels: ReleaseBlock-Stable
762910: Regression:Unable to drag any tab out from original window on touch device.

Comment 2 by msrchandra@chromium.org, Sep 7 2017 

Apologies for Comment#1. Please ignore.
Adding RB Label as this is a recent Regression. Please remove if not required. Thank You.

Comment 3 by jmukthavaram@chromium.org, Sep 19 2017 

phulce@,
Still we are able to reproduce the issue on latest Canary#63.0.3218.0 .
Could you please take a look into this issue as it is marked as stable blocker.
Thanks..!

Comment 4 by phulce@chromium.org, Sep 22 2017

Status: Started (was: Assigned)
There's a fix in progress for many of these race condition issues that starting surfacing in the UI by the referenced CL. https://chromium-review.googlesource.com/c/chromium/src/+/661894

Comment 5 by jmukthavaram@chromium.org, Sep 27 2017

Labels: Needs-Triage-M63
phulce@,
Friendly ping to get an update on this issue as it is marked as stable blocker.
Thanks..!

Comment 6 by phulce@chromium.org, Sep 27 2017 

Fix has been completed and just awaiting review which has been slow due to BlinkOn + OOO for most of the team.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d92868cb835e3a37ff49db38e3e42afe110c411

commit 5d92868cb835e3a37ff49db38e3e42afe110c411
Author: Patrick Hulce <phulce@chromium.org>
Date: Tue Oct 03 02:10:17 2017

DevTools: Add tests for audits2 panel

* Introduces Audits2TestRunner and audits2 test folder.
* Adds test coverage for default flow, limited category flow, and
  unauditable page message help text.
* Fixes a bug where help text was not updated on URL change.

BUG= 762911 , 747357 , 762906 , 762897 

Change-Id: Ifa6475e344be28f8260a71e6a4a7b9eb9791b6c4
Reviewed-on: https://chromium-review.googlesource.com/661894
Commit-Queue: Patrick Hulce <phulce@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505924}
[modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/LayoutTests/SlowTests
[add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run-expected.txt
[add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run.js
[add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run-expected.txt
[add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run.js
[add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run-expected.txt
[add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run.js
[modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
[add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/audits2_test_runner/Audits2TestRunner.js
[add] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/audits2_test_runner/module.json
[modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js
[modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js
[modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/integration_test_runner.json
[modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js
[modify] https://crrev.com/5d92868cb835e3a37ff49db38e3e42afe110c411/third_party/WebKit/Source/devtools/front_end/services/module.json
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a

commit ef8ea6202d4a01d4f05bff487a78e64e556b3e1a
Author: Kentaro Hara <haraken@chromium.org>
Date: Tue Oct 03 06:21:46 2017

Revert "DevTools: Add tests for audits2 panel"

This reverts commit 5d92868cb835e3a37ff49db38e3e42afe110c411.

Reason for revert: This broke virtual/mojo-loading/http/tests/devtools/audits2/audits2-successful-run.js on Win10.

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/26198

Original change's description:
> DevTools: Add tests for audits2 panel
> 
> * Introduces Audits2TestRunner and audits2 test folder.
> * Adds test coverage for default flow, limited category flow, and
>   unauditable page message help text.
> * Fixes a bug where help text was not updated on URL change.
> 
> BUG= 762911 , 747357 , 762906 , 762897 
> 
> Change-Id: Ifa6475e344be28f8260a71e6a4a7b9eb9791b6c4
> Reviewed-on: https://chromium-review.googlesource.com/661894
> Commit-Queue: Patrick Hulce <phulce@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505924}

TBR=dgozman@chromium.org,chenwilliam@chromium.org,phulce@chromium.org

Change-Id: I28b0a59682a5db00980462f97b56a345354d8998
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  762911 ,  747357 ,  762906 ,  762897 
Reviewed-on: https://chromium-review.googlesource.com/696805
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#505967}
[modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/LayoutTests/SlowTests
[delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run-expected.txt
[delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run.js
[delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run-expected.txt
[delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run.js
[delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run-expected.txt
[delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run.js
[modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
[delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/Source/devtools/front_end/audits2_test_runner/Audits2TestRunner.js
[delete] https://crrev.com/9180088761b18dae4d9e290698c7b0b130c0737c/third_party/WebKit/Source/devtools/front_end/audits2_test_runner/module.json
[modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js
[modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/Source/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js
[modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/Source/devtools/front_end/integration_test_runner.json
[modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js
[modify] https://crrev.com/ef8ea6202d4a01d4f05bff487a78e64e556b3e1a/third_party/WebKit/Source/devtools/front_end/services/module.json
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b995386e813c30ff327f7d3be81a85a62272a30

commit 9b995386e813c30ff327f7d3be81a85a62272a30
Author: Patrick Hulce <phulce@chromium.org>
Date: Thu Oct 05 01:23:39 2017

Reland "DevTools: Add tests for audits2 panel"

Win10 tests will be skipped for now.

This is a reland of 5d92868cb835e3a37ff49db38e3e42afe110c411
Original change's description:

> DevTools: Add tests for audits2 panel
> 
> * Introduces Audits2TestRunner and audits2 test folder.
> * Adds test coverage for default flow, limited category flow, and
>   unauditable page message help text.
> * Fixes a bug where help text was not updated on URL change.
> 
> BUG= 762911 , 747357 , 762906 , 762897 
> 
> Change-Id: Ifa6475e344be28f8260a71e6a4a7b9eb9791b6c4
> Reviewed-on: https://chromium-review.googlesource.com/661894
> Commit-Queue: Patrick Hulce <phulce@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#505924}

Bug:  762911 ,  747357 ,  762906 ,  762897 
Change-Id: Iaf210e383e86fbfe0e31b372d8b87c461e8beecb
Reviewed-on: https://chromium-review.googlesource.com/701294
Reviewed-by: Will Chen <chenwilliam@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Patrick Hulce <phulce@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506608}
[modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run-expected.txt
[add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run.js
[add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run-expected.txt
[add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-prevent-run.js
[add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run-expected.txt
[add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run.js
[modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/audits2/Audits2Panel.js
[add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/audits2_test_runner/Audits2TestRunner.js
[add] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/audits2_test_runner/module.json
[modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/audits2_worker/Audits2Service.js
[modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js
[modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/integration_test_runner.json
[modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/services/ServiceManager.js
[modify] https://crrev.com/9b995386e813c30ff327f7d3be81a85a62272a30/third_party/WebKit/Source/devtools/front_end/services/module.json

Comment 10 by jmukthavaram@chromium.org, Oct 10 2017

Labels: TE-Verified-M63 TE-Verified-63.0.3236.0
Tested this issue on Windows 7, Mac 10.12.6 & Ubuntu 14.04 using latest Canary#63.0.3236.0 as per the steps mentioned in Comment#0.

Error message is not displayed upon clicking cancel button while performing Audit in dev tools.As it is working as intended,adding TE Verified labels.

Please find the attached screencast for reference.

Thanks..!
762897.mp4
1.8 MB View Download

Comment 11 by phulce@chromium.org, Oct 10 2017

Status: Verified (was: Started)
►

Sign in to add a comment