New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 762893 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Buttons on screenshot appears misplaced in ' Network' section of devtools.

Reported by rp...@etouch.net, Sep 7 2017

Issue description

Version: 63.0.3208.0 5bfe3ad1decdfd840726e31694347e6d973a3f09-refs/heads/master@{#500160}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS,Mac OS X(10.11.6,10.12.3)

What steps will reproduce the problem?
1. Launch chrome, navigate to NTP and open devtools.
2. Now go to 'Network' section and click on 'Capture screenshot' icon and then press 'F5' to reload and capture filmstrip.
3. Now double click to zoom image and drag devtools window to RHS and press tab key to bring focus on 'Next frame' button on screenshot,observe
 
Actual: Buttons(Previous frame and Next frame) on screenshot appears misplaced after pressing 'Tab' key
Expected: Buttons(Previous frame and Next frame) on screenshot shouldn't appear misplaced after pressing 'Tab' key

This is regression issue, broken in ‘M 58’ and will soon update other info :
Good build:58.0.3017.0
Bad build: 58.0.3018.0
 
Actual_video.mp4
1.3 MB View Download
Expected_video.mp4
1.0 MB View Download
Actual_screenshot.png
185 KB View Download

Comment 1 Deleted

Comment 2 by rp...@etouch.net, Sep 7 2017

Using the per-revision bisect providing the bisect results,
Good build: 58.0.3017.0 (Revision: 451477).
Bad build: 58.0.3018.0 (Revision: 451537).

You are probably looking for a change made after 451522 (known good), but no lat
er than 451523 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/0fea64cb0a598ecd2051bb7c58e6fbf9422b1aef..3e3774f369e1e642d06e895276b08814b279c20c?pretty=fuller&n=100

From the CL above, assigning the issue to the concern owner 

@dgozman- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Suspect : https://chromium.googlesource.com/chromium/src/+/3e3774f369e1e642d06e895276b08814b279c20c

Thanks!
Owner: l...@chromium.org
Erik, mind taking a look?
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e105595288ee836d3d793e7aec419cb40d3de10d

commit e105595288ee836d3d793e7aec419cb40d3de10d
Author: Erik Luo <luoe@chromium.org>
Date: Thu Nov 30 03:01:24 2017

DevTools: add scroller to filmstrip dialog image

By placing the image inside a scrolling container, none of the dialog's
children will overflow after this CL.

Screenshot: https://imgur.com/a/CIkCU

Bug:  762893 
Change-Id: I8ba3dc7cc09e629f09917c1fa24309c698777d3f
Reviewed-on: https://chromium-review.googlesource.com/772787
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520402}
[modify] https://crrev.com/e105595288ee836d3d793e7aec419cb40d3de10d/third_party/WebKit/Source/devtools/front_end/perf_ui/FilmStripView.js
[modify] https://crrev.com/e105595288ee836d3d793e7aec419cb40d3de10d/third_party/WebKit/Source/devtools/front_end/perf_ui/filmStripDialog.css

Comment 5 by l...@chromium.org, Nov 30 2017

Status: Fixed (was: Assigned)
Update:
Retested above issue on Windows (7,8,10),Linux and Mac using latest Canary #64.0.3282.0 and issue is still reproducible. Kindly review an attached screen cast.

Thank you!
FixedVideo.mp4
1.1 MB View Download
Labels: TE-Verified- TE-Verified-64.0.282.0
As per Comment# 6 adding appropriate TE-Verified labels.
Thank You.
Labels: -TE-Verified- TE-Verified-M64
Labels: -TE-Verified-64.0.282.0 TE-Verified-64.0.3282.0
Labels: -TE-Verified-M64 -TE-Verified-64.0.3282.0
Apologies for the wrong comments# 7,8,9. Removing TE-Verified labels.

Comment 11 by l...@chromium.org, Dec 1 2017

Status: Assigned (was: Fixed)
Thanks for the verification, it's not fixed...  I'll take another look.

Comment 12 by rp...@etouch.net, Dec 7 2017

Update :
Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1) using Dev build #64.0.3282.14 and issue is still reproducible. Kindly review an attached screen cast.
Actual_Video.mp4
549 KB View Download
Status: WontFix (was: Assigned)
Extreme UI conditions.

Sign in to add a comment